[INFO] fetching crate critical-once-cell 0.1.0... [INFO] checking critical-once-cell-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate critical-once-cell 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate critical-once-cell 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate critical-once-cell 0.1.0 [INFO] finished tweaking crates.io crate critical-once-cell 0.1.0 [INFO] tweaked toml for crates.io crate critical-once-cell 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding critical-section v0.2.8 (latest: v1.1.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c605efc4046f0f49a5e73de4356196dc5ebd7426ff2e5749209d35bae04b1a8d [INFO] running `Command { std: "docker" "start" "-a" "c605efc4046f0f49a5e73de4356196dc5ebd7426ff2e5749209d35bae04b1a8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c605efc4046f0f49a5e73de4356196dc5ebd7426ff2e5749209d35bae04b1a8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c605efc4046f0f49a5e73de4356196dc5ebd7426ff2e5749209d35bae04b1a8d", kill_on_drop: false }` [INFO] [stdout] c605efc4046f0f49a5e73de4356196dc5ebd7426ff2e5749209d35bae04b1a8d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec109fb646b53f5df6ce170861571c38d7d9e9e47808824594bdfbaa3c73bbc5 [INFO] running `Command { std: "docker" "start" "-a" "ec109fb646b53f5df6ce170861571c38d7d9e9e47808824594bdfbaa3c73bbc5", kill_on_drop: false }` [INFO] [stderr] Checking bare-metal v1.0.0 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Checking critical-section v0.2.8 [INFO] [stderr] Checking critical-once-cell v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:32 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn set(&self, value: T) -> Result<(), T> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | critical_section::with(|_| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 115 | | let cell = unsafe { &mut *self.inner.get() }; [INFO] [stdout] 116 | | [INFO] [stdout] 117 | | if cell.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 122 | | } [INFO] [stdout] 123 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:153:57 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn get_or_init(&self, f: F) -> &T [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | self.get_or_try_init::<_, Infallible>(|| Ok(f())) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:32 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn get_or_try_init(&self, f: F) -> Result<&T, E> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | critical_section::with(|_| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 189 | | let cell = unsafe { &mut *self.inner.get() }; [INFO] [stdout] 190 | | [INFO] [stdout] 191 | | if cell.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 195 | | Ok(unsafe { cell.as_ref().unwrap_unchecked() }) [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:19 [INFO] [stdout] | [INFO] [stdout] 276 | pub const fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | Self { [INFO] [stdout] 278 | cell: CriticalOnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:279:19 [INFO] [stdout] | [INFO] [stdout] 276 | pub const fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | init: Cell::new(Some(f)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:40 [INFO] [stdout] | [INFO] [stdout] 289 | this.cell.get_or_init(|| match this.init.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `critical-once-cell` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:32 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn set(&self, value: T) -> Result<(), T> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | critical_section::with(|_| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 115 | | let cell = unsafe { &mut *self.inner.get() }; [INFO] [stdout] 116 | | [INFO] [stdout] 117 | | if cell.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 122 | | } [INFO] [stdout] 123 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:153:57 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn get_or_init(&self, f: F) -> &T [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | self.get_or_try_init::<_, Infallible>(|| Ok(f())) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:32 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn get_or_try_init(&self, f: F) -> Result<&T, E> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | critical_section::with(|_| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 189 | | let cell = unsafe { &mut *self.inner.get() }; [INFO] [stdout] 190 | | [INFO] [stdout] 191 | | if cell.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 195 | | Ok(unsafe { cell.as_ref().unwrap_unchecked() }) [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:19 [INFO] [stdout] | [INFO] [stdout] 276 | pub const fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | Self { [INFO] [stdout] 278 | cell: CriticalOnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:279:19 [INFO] [stdout] | [INFO] [stdout] 276 | pub const fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | init: Cell::new(Some(f)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:40 [INFO] [stdout] | [INFO] [stdout] 289 | this.cell.get_or_init(|| match this.init.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:389:31 [INFO] [stdout] | [INFO] [stdout] 387 | let cell = cell.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | [INFO] [stdout] 389 | thread::spawn(move || { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 390 | | let value = Box::new(i); [INFO] [stdout] 391 | | let res = cell.set(value); [INFO] [stdout] ... | [INFO] [stdout] 397 | | } [INFO] [stdout] 398 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:404:27 [INFO] [stdout] | [INFO] [stdout] 404 | .map(|handle| handle.join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:438:31 [INFO] [stdout] | [INFO] [stdout] 437 | let counter = counter.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | thread::spawn(move || { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 439 | | counter.fetch_add(1, Ordering::Relaxed); [INFO] [stdout] 440 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `critical-once-cell` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "ec109fb646b53f5df6ce170861571c38d7d9e9e47808824594bdfbaa3c73bbc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec109fb646b53f5df6ce170861571c38d7d9e9e47808824594bdfbaa3c73bbc5", kill_on_drop: false }` [INFO] [stdout] ec109fb646b53f5df6ce170861571c38d7d9e9e47808824594bdfbaa3c73bbc5