[INFO] fetching crate criterion-polyglot 0.1.0... [INFO] checking criterion-polyglot-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate criterion-polyglot 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate criterion-polyglot 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate criterion-polyglot 0.1.0 [INFO] finished tweaking crates.io crate criterion-polyglot 0.1.0 [INFO] tweaked toml for crates.io crate criterion-polyglot 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cargo_metadata v0.15.4 (latest: v0.18.1) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding test-binary v2.0.0 (latest: v3.0.2) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e95508a112ff16d9175c1e69ed7ae60bc9c965b1db9734a9d303b534933fc1c [INFO] running `Command { std: "docker" "start" "-a" "5e95508a112ff16d9175c1e69ed7ae60bc9c965b1db9734a9d303b534933fc1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e95508a112ff16d9175c1e69ed7ae60bc9c965b1db9734a9d303b534933fc1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e95508a112ff16d9175c1e69ed7ae60bc9c965b1db9734a9d303b534933fc1c", kill_on_drop: false }` [INFO] [stdout] 5e95508a112ff16d9175c1e69ed7ae60bc9c965b1db9734a9d303b534933fc1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8eb496023236489ddb10336be7a0470bd426724c9bcbcc5f101c2061d8064bc4 [INFO] running `Command { std: "docker" "start" "-a" "8eb496023236489ddb10336be7a0470bd426724c9bcbcc5f101c2061d8064bc4", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling criterion-polyglot v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking cc v1.1.15 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking test-binary v2.0.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c/mod.rs:67:57 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn spawn(executable: impl AsRef) -> CommunicatingBenchmark { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let command = Command::new(executable.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | CommunicatingBenchmark::start("running C", command, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/go/mod.rs:33:58 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn spawn(executable: impl AsRef) -> CommunicatingBenchmark { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let command = Command::new(executable.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | CommunicatingBenchmark::start("running Go", command, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ruby/mod.rs:14:52 [INFO] [stdout] | [INFO] [stdout] 9 | let bench_file = make_spec_tempfile(self::SOURCE_EXTENSION, HARNESS, &spec); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let ruby_path = get_criterion_env_var("RUBY", "ruby"); [INFO] [stdout] 11 | let mut command = Command::new(ruby_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | CommunicatingBenchmark::start("Ruby", command, Some(bench_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/zig/mod.rs:56:59 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn spawn(executable: impl AsRef) -> CommunicatingBenchmark { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let command = Command::new(executable.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | CommunicatingBenchmark::start("running Zig", command, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:25:64 [INFO] [stdout] | [INFO] [stdout] 25 | let temp_files = temp_files.into_iter().filter_map(|f| f.keep().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 100 | mut command: Command, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | temp_files: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) -> Self { [INFO] [stdout] 103 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let stdout = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stderr_task = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | child: Some(child), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 100 | mut command: Command, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | temp_files: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) -> Self { [INFO] [stdout] 103 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let stdout = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stderr_task = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | stderr_task: Some(stderr_task), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 100 | mut command: Command, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | temp_files: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) -> Self { [INFO] [stdout] 103 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let stdout = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stderr_task = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | temp_files: temp_files.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:237:67 [INFO] [stdout] | [INFO] [stdout] 237 | let temp_files = self.temp_files.drain(..).filter_map(|f| f.keep().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `criterion-polyglot` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c/mod.rs:67:57 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn spawn(executable: impl AsRef) -> CommunicatingBenchmark { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let command = Command::new(executable.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | CommunicatingBenchmark::start("running C", command, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/go/mod.rs:33:58 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn spawn(executable: impl AsRef) -> CommunicatingBenchmark { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let command = Command::new(executable.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | CommunicatingBenchmark::start("running Go", command, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ruby/mod.rs:14:52 [INFO] [stdout] | [INFO] [stdout] 9 | let bench_file = make_spec_tempfile(self::SOURCE_EXTENSION, HARNESS, &spec); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let ruby_path = get_criterion_env_var("RUBY", "ruby"); [INFO] [stdout] 11 | let mut command = Command::new(ruby_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | CommunicatingBenchmark::start("Ruby", command, Some(bench_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/zig/mod.rs:56:59 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn spawn(executable: impl AsRef) -> CommunicatingBenchmark { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let command = Command::new(executable.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | CommunicatingBenchmark::start("running Zig", command, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:25:64 [INFO] [stdout] | [INFO] [stdout] 25 | let temp_files = temp_files.into_iter().filter_map(|f| f.keep().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 100 | mut command: Command, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | temp_files: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) -> Self { [INFO] [stdout] 103 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let stdout = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stderr_task = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | child: Some(child), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 100 | mut command: Command, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | temp_files: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) -> Self { [INFO] [stdout] 103 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let stdout = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stderr_task = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | stderr_task: Some(stderr_task), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 100 | mut command: Command, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | temp_files: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) -> Self { [INFO] [stdout] 103 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let stdout = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stderr_task = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | temp_files: temp_files.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:237:67 [INFO] [stdout] | [INFO] [stdout] 237 | let temp_files = self.temp_files.drain(..).filter_map(|f| f.keep().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `criterion-polyglot` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "8eb496023236489ddb10336be7a0470bd426724c9bcbcc5f101c2061d8064bc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8eb496023236489ddb10336be7a0470bd426724c9bcbcc5f101c2061d8064bc4", kill_on_drop: false }` [INFO] [stdout] 8eb496023236489ddb10336be7a0470bd426724c9bcbcc5f101c2061d8064bc4