[INFO] fetching crate crepe 0.1.8... [INFO] checking crepe-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate crepe 0.1.8 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate crepe 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crepe 0.1.8 [INFO] finished tweaking crates.io crate crepe 0.1.8 [INFO] tweaked toml for crates.io crate crepe 0.1.8 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 700ae149451bc5d81e2812bb82a4b96169ebaae1eb826c47b2db142338c60f49 [INFO] running `Command { std: "docker" "start" "-a" "700ae149451bc5d81e2812bb82a4b96169ebaae1eb826c47b2db142338c60f49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "700ae149451bc5d81e2812bb82a4b96169ebaae1eb826c47b2db142338c60f49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "700ae149451bc5d81e2812bb82a4b96169ebaae1eb826c47b2db142338c60f49", kill_on_drop: false }` [INFO] [stdout] 700ae149451bc5d81e2812bb82a4b96169ebaae1eb826c47b2db142338c60f49 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1833e05ad21388db4ab4d07652ac27f55bdaded7a855169ad277631f1147b399 [INFO] running `Command { std: "docker" "start" "-a" "1833e05ad21388db4ab4d07652ac27f55bdaded7a855169ad277631f1147b399", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking crepe v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `paren_token` is never read [INFO] [stdout] --> src/parse.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Relation { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 52 | pub paren_token: token::Paren, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Relation` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `arrow_token` and `semi_token` are never read [INFO] [stdout] --> src/parse.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 98 | pub struct Rule { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 99 | pub goal: Fact, [INFO] [stdout] 100 | pub arrow_token: Token![<-], [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 101 | pub clauses: Punctuated, [INFO] [stdout] 102 | pub semi_token: Token![;], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Rule` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `paren_token` is never read [INFO] [stdout] --> src/parse.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 161 | pub struct Fact { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 164 | pub paren_token: token::Paren, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Fact` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `for_token` and `in_token` are never read [INFO] [stdout] --> src/parse.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 195 | pub struct For { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 196 | pub for_token: Token![for], [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 197 | pub pat: Pat, [INFO] [stdout] 198 | pub in_token: Token![in], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `For` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:731:35 [INFO] [stdout] | [INFO] [stdout] 731 | .map(|(f, stratum)| f(make_updates(context, stratum, &indices))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:864:14 [INFO] [stdout] | [INFO] [stdout] 809 | let stratum: HashSet<_> = stratum.iter().collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 819 | let empty_cond: proc_macro2::TokenStream = current_rels [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 828 | .chain(std::iter::once(quote! {true})) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 831 | let new_decls: proc_macro2::TokenStream = current_rels [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 844 | let rules: proc_macro2::TokenStream = context [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 851 | let set_update_to_new: proc_macro2::TokenStream = current_rels [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 864 | Box::new(move |updates| { [INFO] [stdout] | ______________^ [INFO] [stdout] 865 | | quote! { [INFO] [stdout] 866 | | let mut __crepe_first_iteration = true; [INFO] [stdout] 867 | | while __crepe_first_iteration || !(#empty_cond) { [INFO] [stdout] ... | [INFO] [stdout] 874 | | } [INFO] [stdout] 875 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut relations: Vec = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let mut rules: Vec = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Self { relations, rules }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 75 | let attribute = if input.peek(Token![@]) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | #[allow(clippy::mixed_read_write_in_expression)] [INFO] [stdout] 83 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | attribute, [INFO] [stdout] 85 | | attrs: input.call(Attribute::parse_outer)?, [INFO] [stdout] 86 | | visibility: input.parse()?, [INFO] [stdout] ... | [INFO] [stdout] 92 | | semi_token: input.parse()?, [INFO] [stdout] 93 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 170 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | #[allow(clippy::mixed_read_write_in_expression)] [INFO] [stdout] 172 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | negate: input.parse()?, [INFO] [stdout] 174 | | relation: input.parse()?, [INFO] [stdout] 175 | | paren_token: parenthesized!(content in input), [INFO] [stdout] ... | [INFO] [stdout] 189 | | )?, [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crepe` (lib) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1833e05ad21388db4ab4d07652ac27f55bdaded7a855169ad277631f1147b399", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1833e05ad21388db4ab4d07652ac27f55bdaded7a855169ad277631f1147b399", kill_on_drop: false }` [INFO] [stdout] 1833e05ad21388db4ab4d07652ac27f55bdaded7a855169ad277631f1147b399