[INFO] fetching crate credstash 0.9.2... [INFO] checking credstash-0.9.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate credstash 0.9.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate credstash 0.9.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate credstash 0.9.2 [INFO] finished tweaking crates.io crate credstash 0.9.2 [INFO] tweaked toml for crates.io crate credstash 0.9.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate credstash 0.9.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59a98fddc7c036a6333316bd27e608bad08f9db90ca42ff2d30d854022ca961f [INFO] running `Command { std: "docker" "start" "-a" "59a98fddc7c036a6333316bd27e608bad08f9db90ca42ff2d30d854022ca961f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59a98fddc7c036a6333316bd27e608bad08f9db90ca42ff2d30d854022ca961f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59a98fddc7c036a6333316bd27e608bad08f9db90ca42ff2d30d854022ca961f", kill_on_drop: false }` [INFO] [stdout] 59a98fddc7c036a6333316bd27e608bad08f9db90ca42ff2d30d854022ca961f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd2fce2cfd2d3b57d6666f85f9bf2c0dfec414e6fe4c628499313caae507a1e5 [INFO] running `Command { std: "docker" "start" "-a" "cd2fce2cfd2d3b57d6666f85f9bf2c0dfec414e6fe4c628499313caae507a1e5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling semver v1.0.17 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling rustls v0.20.8 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Compiling serde_json v1.0.96 [INFO] [stderr] Compiling async-trait v0.1.68 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking cpufeatures v0.2.7 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking shlex v1.1.0 [INFO] [stderr] Checking zeroize v1.6.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking xml-rs v0.8.14 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Checking rustls-pemfile v1.0.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Compiling rusoto_core v0.48.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking aes v0.8.2 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.4 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Checking clap v4.3.4 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking h2 v0.3.19 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v0.14.26 [INFO] [stderr] Checking rusoto_credential v0.48.0 [INFO] [stderr] Checking hyper-rustls v0.23.2 [INFO] [stderr] Checking rusoto_signature v0.48.0 [INFO] [stderr] Checking rusoto_ec2 v0.48.0 [INFO] [stderr] Checking rusoto_sts v0.48.0 [INFO] [stderr] Checking rusoto_dynamodb v0.48.0 [INFO] [stderr] Checking rusoto_kms v0.48.0 [INFO] [stderr] Checking credstash v0.9.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:412:12 [INFO] [stdout] | [INFO] [stdout] 359 | let provider = match credential { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | CredStashCredential::DefaultCredentialsProvider => { [INFO] [stdout] 361 | let client = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | Client::new_with(DefaultCredentialsProvider::new()?, HttpClient::new()?); [INFO] [stdout] 363 | let dynamo_client = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | DynamoDbClient::new_with_client(client.clone(), default_region.clone()); [INFO] [stdout] 365 | let kms_client = KmsClient::new_with_client(client, default_region); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | let sts = StsClient::new_with( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | let mut sts_role_provider = StsAssumeRoleSessionCredentialsProvider::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | let client = Client::new_with(sts_role_provider, HttpClient::new()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | let dynamo_client = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | DynamoDbClient::new_with_client(client.clone(), default_region.clone()); [INFO] [stdout] 393 | let kms_client = KmsClient::new_with_client(client, default_region); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let client = Client::new_with(profile_provider, HttpClient::new()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | let dynamo_client = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | DynamoDbClient::new_with_client(client.clone(), default_region.clone()); [INFO] [stdout] 407 | let kms_client = KmsClient::new_with_client(client, default_region); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | let (dynamo_client, kms_client) = provider; [INFO] [stdout] | ------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 412 | Ok(CredStashClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 413 | | dynamo_client, [INFO] [stdout] 414 | | kms_client, [INFO] [stdout] 415 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:412:12 [INFO] [stdout] | [INFO] [stdout] 359 | let provider = match credential { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | CredStashCredential::DefaultCredentialsProvider => { [INFO] [stdout] 361 | let client = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | Client::new_with(DefaultCredentialsProvider::new()?, HttpClient::new()?); [INFO] [stdout] 363 | let dynamo_client = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | DynamoDbClient::new_with_client(client.clone(), default_region.clone()); [INFO] [stdout] 365 | let kms_client = KmsClient::new_with_client(client, default_region); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | let sts = StsClient::new_with( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | let mut sts_role_provider = StsAssumeRoleSessionCredentialsProvider::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | let client = Client::new_with(sts_role_provider, HttpClient::new()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | let dynamo_client = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | DynamoDbClient::new_with_client(client.clone(), default_region.clone()); [INFO] [stdout] 393 | let kms_client = KmsClient::new_with_client(client, default_region); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let client = Client::new_with(profile_provider, HttpClient::new()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | let dynamo_client = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | DynamoDbClient::new_with_client(client.clone(), default_region.clone()); [INFO] [stdout] 407 | let kms_client = KmsClient::new_with_client(client, default_region); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | let (dynamo_client, kms_client) = provider; [INFO] [stdout] | ------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 412 | Ok(CredStashClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 413 | | dynamo_client, [INFO] [stdout] 414 | | kms_client, [INFO] [stdout] 415 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `credstash` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `credstash` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "cd2fce2cfd2d3b57d6666f85f9bf2c0dfec414e6fe4c628499313caae507a1e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd2fce2cfd2d3b57d6666f85f9bf2c0dfec414e6fe4c628499313caae507a1e5", kill_on_drop: false }` [INFO] [stdout] cd2fce2cfd2d3b57d6666f85f9bf2c0dfec414e6fe4c628499313caae507a1e5