[INFO] fetching crate credo 0.8.0... [INFO] checking credo-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate credo 0.8.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate credo 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate credo 0.8.0 [INFO] finished tweaking crates.io crate credo 0.8.0 [INFO] tweaked toml for crates.io crate credo 0.8.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 125 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding aead v0.4.3 (latest: v0.5.2) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding async_executors v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding audi v0.2.4 (latest: v0.3.0) [INFO] [stderr] Adding blanket v0.2.0 (latest: v0.4.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding bs58 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding chacha20 v0.8.2 (latest: v0.9.1) [INFO] [stderr] Adding chacha20poly1305 v0.9.1 (latest: v0.10.1) [INFO] [stderr] Adding cipher v0.3.0 (latest: v0.4.4) [INFO] [stderr] Adding crypto_box v0.7.2 (latest: v0.9.1) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding litl v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding litl-val v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding ordered-float v3.9.2 (latest: v4.2.2) [INFO] [stderr] Adding poly1305 v0.7.2 (latest: v0.8.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding ridl v0.6.1 (latest: v0.7.0) [INFO] [stderr] Adding salsa20 v0.9.0 (latest: v0.10.2) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding universal-hash v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding x25519-dalek v1.2.0 (latest: v2.0.1) [INFO] [stderr] Adding xsalsa20poly1305 v0.8.0 (latest: v0.9.1) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d1d98209469a0f9b20b02dafe241ddb4c2872285dc08489c3a74e0d87360bff [INFO] running `Command { std: "docker" "start" "-a" "7d1d98209469a0f9b20b02dafe241ddb4c2872285dc08489c3a74e0d87360bff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d1d98209469a0f9b20b02dafe241ddb4c2872285dc08489c3a74e0d87360bff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d1d98209469a0f9b20b02dafe241ddb4c2872285dc08489c3a74e0d87360bff", kill_on_drop: false }` [INFO] [stdout] 7d1d98209469a0f9b20b02dafe241ddb4c2872285dc08489c3a74e0d87360bff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96c9add6494d4d4a388aade626f1505bcd74b92564d3e06a1a9d84d11155720d [INFO] running `Command { std: "docker" "start" "-a" "96c9add6494d4d4a388aade626f1505bcd74b92564d3e06a1a9d84d11155720d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking litl-nanval v0.2.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking tagged-box v0.1.1 [INFO] [stderr] Checking bs58 v0.4.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling async_executors v0.6.0 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking poly1305 v0.7.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Compiling deepsize_derive v0.1.2 [INFO] [stderr] Compiling blanket v0.2.0 [INFO] [stderr] Checking deepsize v0.2.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking chacha20 v0.8.2 [INFO] [stderr] Checking salsa20 v0.9.0 [INFO] [stderr] Checking xsalsa20poly1305 v0.8.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking chacha20poly1305 v0.9.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking litl-val v0.1.0 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking x25519-dalek v1.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking crypto_box v0.7.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking ti64 v0.1.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking litl v0.5.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking ridl v0.6.1 [INFO] [stderr] Checking audi v0.2.4 [INFO] [stderr] Checking mofo v0.2.2 [INFO] [stderr] Checking caro v0.7.1 [INFO] [stderr] Checking credo v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `future` [INFO] [stdout] --> src/scope.rs:9:39 [INFO] [stdout] | [INFO] [stdout] 9 | use futures::{channel::mpsc::channel, future, stream, Future, FutureExt, Stream, StreamExt}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `future` [INFO] [stdout] --> src/scope.rs:9:39 [INFO] [stdout] | [INFO] [stdout] 9 | use futures::{channel::mpsc::channel, future, stream, Future, FutureExt, Stream, StreamExt}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_with_telepathy(name: String, telepathy: caro::Node, background: Mofo) -> Credo { [INFO] [stdout] | --------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Credo(Rc::new(RefCell::new(CredoInner { [INFO] [stdout] | _______________^ [INFO] [stdout] 60 | | name, [INFO] [stdout] 61 | | telepathy, [INFO] [stdout] 62 | | scopes: HashMap::new(), [INFO] [stdout] 63 | | background, [INFO] [stdout] 64 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:24 [INFO] [stdout] | [INFO] [stdout] 310 | pub fn new_v1(signer_secret: &SignerSecret, kind: ClaimBody) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | Claim::CredoV1(signer_secret.sign(CredoV1Claim { [INFO] [stdout] | ________________________^ [INFO] [stdout] 312 | | by: signer_secret.pub_id(), [INFO] [stdout] 313 | | made_at: ti64::now(), [INFO] [stdout] 314 | | body: kind, [INFO] [stdout] 315 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:216:21 [INFO] [stdout] | [INFO] [stdout] 190 | async fn add_child(&self, child: Scope) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let parent = self.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .for_each(move |_parent_update| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let parent_clone = parent.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let child = child.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let span = trace_span!( [INFO] [stdout] | _________________________----___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | | "Credo::receive_parent_update", [INFO] [stdout] 212 | | node = %child.full_id(), [INFO] [stdout] 213 | | scope = ?child.id(), [INFO] [stdout] 214 | | parent = %parent_clone.full_id(), [INFO] [stdout] 215 | | ); [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | / async move { [INFO] [stdout] 217 | | let new_state = child.current_state_as_of(ti64::now()); [INFO] [stdout] 218 | | trace!(new_state = ?new_state, own_claims = ?(*child.0).borrow().own_claims, "Updating listeners on parent update"); [INFO] [stdout] 219 | | let listeners = (*child.0).borrow().listeners.clone(); [INFO] [stdout] 220 | | listeners.broadcast(new_state).await; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 237 | let (updates_tx, updates_rx) = channel(100); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | let self_clone = self.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | [INFO] [stdout] 241 | / stream::once(async move { [INFO] [stdout] 242 | | self_clone [INFO] [stdout] 243 | | .add_update_listener(Listener::new( [INFO] [stdout] 244 | | &format!("{}_{:?}", listener_prefix, rand::random::()), [INFO] [stdout] ... | [INFO] [stdout] 250 | | }) [INFO] [stdout] 251 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:265:69 [INFO] [stdout] | [INFO] [stdout] 265 | .ok_or_else(|| MakeClaimError::CredentialMissingFor(Box::new(kind.clone())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 313 | let telepathy = (*self.0).borrow().telepathy.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | let mut state_rx = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | Err(AddClaimError::ScopeUpdatesStoppedBeforeClaimValid) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:553:25 [INFO] [stdout] | [INFO] [stdout] 538 | let (successes, errors) = matching_entries [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | .or_else(|| errors.into_iter().next()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:562:37 [INFO] [stdout] | [INFO] [stdout] 562 | .and_then(|mut secrets| secrets.remove(&self.id()).and_then(|res| res.ok())) [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 273 | pub fn deserialize<'de, D, T>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | Ok(Rc::new(T::deserialize(deserializer)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `credo` (lib test) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_with_telepathy(name: String, telepathy: caro::Node, background: Mofo) -> Credo { [INFO] [stdout] | --------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Credo(Rc::new(RefCell::new(CredoInner { [INFO] [stdout] | _______________^ [INFO] [stdout] 60 | | name, [INFO] [stdout] 61 | | telepathy, [INFO] [stdout] 62 | | scopes: HashMap::new(), [INFO] [stdout] 63 | | background, [INFO] [stdout] 64 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:24 [INFO] [stdout] | [INFO] [stdout] 310 | pub fn new_v1(signer_secret: &SignerSecret, kind: ClaimBody) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | Claim::CredoV1(signer_secret.sign(CredoV1Claim { [INFO] [stdout] | ________________________^ [INFO] [stdout] 312 | | by: signer_secret.pub_id(), [INFO] [stdout] 313 | | made_at: ti64::now(), [INFO] [stdout] 314 | | body: kind, [INFO] [stdout] 315 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:216:21 [INFO] [stdout] | [INFO] [stdout] 190 | async fn add_child(&self, child: Scope) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let parent = self.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .for_each(move |_parent_update| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let parent_clone = parent.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let child = child.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let span = trace_span!( [INFO] [stdout] | _________________________----___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | | "Credo::receive_parent_update", [INFO] [stdout] 212 | | node = %child.full_id(), [INFO] [stdout] 213 | | scope = ?child.id(), [INFO] [stdout] 214 | | parent = %parent_clone.full_id(), [INFO] [stdout] 215 | | ); [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | / async move { [INFO] [stdout] 217 | | let new_state = child.current_state_as_of(ti64::now()); [INFO] [stdout] 218 | | trace!(new_state = ?new_state, own_claims = ?(*child.0).borrow().own_claims, "Updating listeners on parent update"); [INFO] [stdout] 219 | | let listeners = (*child.0).borrow().listeners.clone(); [INFO] [stdout] 220 | | listeners.broadcast(new_state).await; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 237 | let (updates_tx, updates_rx) = channel(100); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | let self_clone = self.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | [INFO] [stdout] 241 | / stream::once(async move { [INFO] [stdout] 242 | | self_clone [INFO] [stdout] 243 | | .add_update_listener(Listener::new( [INFO] [stdout] 244 | | &format!("{}_{:?}", listener_prefix, rand::random::()), [INFO] [stdout] ... | [INFO] [stdout] 250 | | }) [INFO] [stdout] 251 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:265:69 [INFO] [stdout] | [INFO] [stdout] 265 | .ok_or_else(|| MakeClaimError::CredentialMissingFor(Box::new(kind.clone())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 313 | let telepathy = (*self.0).borrow().telepathy.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | let mut state_rx = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | Err(AddClaimError::ScopeUpdatesStoppedBeforeClaimValid) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:553:25 [INFO] [stdout] | [INFO] [stdout] 538 | let (successes, errors) = matching_entries [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | .or_else(|| errors.into_iter().next()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:562:37 [INFO] [stdout] | [INFO] [stdout] 562 | .and_then(|mut secrets| secrets.remove(&self.id()).and_then(|res| res.ok())) [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 273 | pub fn deserialize<'de, D, T>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | Ok(Rc::new(T::deserialize(deserializer)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `credo` (lib) due to 10 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "96c9add6494d4d4a388aade626f1505bcd74b92564d3e06a1a9d84d11155720d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96c9add6494d4d4a388aade626f1505bcd74b92564d3e06a1a9d84d11155720d", kill_on_drop: false }` [INFO] [stdout] 96c9add6494d4d4a388aade626f1505bcd74b92564d3e06a1a9d84d11155720d