[INFO] fetching crate credentials 1.0.0-beta.1... [INFO] checking credentials-1.0.0-beta.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate credentials 1.0.0-beta.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate credentials 1.0.0-beta.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate credentials 1.0.0-beta.1 [INFO] finished tweaking crates.io crate credentials 1.0.0-beta.1 [INFO] tweaked toml for crates.io crate credentials 1.0.0-beta.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate credentials 1.0.0-beta.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 587bfb08aa3e0cb53c501a68533a30e9d1211d20f62ec55c0c6bc8e46f282b72 [INFO] running `Command { std: "docker" "start" "-a" "587bfb08aa3e0cb53c501a68533a30e9d1211d20f62ec55c0c6bc8e46f282b72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "587bfb08aa3e0cb53c501a68533a30e9d1211d20f62ec55c0c6bc8e46f282b72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "587bfb08aa3e0cb53c501a68533a30e9d1211d20f62ec55c0c6bc8e46f282b72", kill_on_drop: false }` [INFO] [stdout] 587bfb08aa3e0cb53c501a68533a30e9d1211d20f62ec55c0c6bc8e46f282b72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39afe3be8e3b05901609f1200902e85d291626fe6d887a321544710012a474b3 [INFO] running `Command { std: "docker" "start" "-a" "39afe3be8e3b05901609f1200902e85d291626fe6d887a321544710012a474b3", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking rustls-pemfile v0.2.1 [INFO] [stderr] Checking rustls-native-certs v0.6.1 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking rustls v0.20.2 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing-subscriber v0.3.4 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-rustls v0.23.2 [INFO] [stderr] Checking h2 v0.3.9 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stderr] Checking hyper-rustls v0.23.0 [INFO] [stderr] Checking reqwest v0.11.8 [INFO] [stderr] Checking credentials v1.0.0-beta.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 123 | .map_err(|err| Error::Credential { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | name: name_ref.to_owned(), [INFO] [stdout] 125 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | source: Box::new(Error::NonUnicodePath { [INFO] [stdout] | _____________________^ [INFO] [stdout] 135 | | path: path_ref.to_owned(), [INFO] [stdout] 136 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 142 | .map_err(|err| Error::Credential { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | name: path_str.to_owned(), [INFO] [stdout] 144 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:198:35 [INFO] [stdout] | [INFO] [stdout] 198 | with_client(|client| Box::pin(client.var(name))).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:204:35 [INFO] [stdout] | [INFO] [stdout] 204 | with_client(|client| Box::pin(client.file(path))).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:171:73 [INFO] [stdout] | [INFO] [stdout] 171 | Secretfile::read_internal(read).map_err(|err| Error::Secretfile(Box::new(err))) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let path = path.as_ref(); [INFO] [stdout] 177 | let mut file = File::open(path).map_err(|err| Error::FileRead { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Secretfile::read(&mut file).map_err(|err| Error::FileRead { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:179:21 [INFO] [stdout] | [INFO] [stdout] 177 | let mut file = File::open(path).map_err(|err| Error::FileRead { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | path: path.to_owned(), [INFO] [stdout] 179 | source: Box::new(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 181 | Secretfile::read(&mut file).map_err(|err| Error::FileRead { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | path: path.to_owned(), [INFO] [stdout] 183 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:214:50 [INFO] [stdout] | [INFO] [stdout] 214 | .map_err(|err| Error::Secretfile(Box::new(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:49:49 [INFO] [stdout] | [INFO] [stdout] 49 | .map_err(|err| Error::MissingVaultToken(Box::new(err))) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 93 | fn new(client: reqwest::Client, addr: U, token: S) -> Result [INFO] [stdout] | ----------------------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 99 | | client, [INFO] [stdout] 100 | | addr: addr.into(), [INFO] [stdout] 101 | | token: token.into(), [INFO] [stdout] 102 | | secrets: BTreeMap::new(), [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 111 | let mkerr = |err| Error::Url { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | url: url.clone(), [INFO] [stdout] 113 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:124:37 [INFO] [stdout] | [INFO] [stdout] 124 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:130:41 [INFO] [stdout] | [INFO] [stdout] 130 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 16 | fs::read_to_string(KUBERNETES_TOKEN_PATH).map_err(|err| Error::FileRead { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | path: Path::new(KUBERNETES_TOKEN_PATH).to_owned(), [INFO] [stdout] 18 | source: Box::new(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mkerr = |err| Error::Url { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | url: url.to_owned(), [INFO] [stdout] 56 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:68:33 [INFO] [stdout] | [INFO] [stdout] 68 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:84:37 [INFO] [stdout] | [INFO] [stdout] 84 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `credentials` (lib) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 123 | .map_err(|err| Error::Credential { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | name: name_ref.to_owned(), [INFO] [stdout] 125 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | source: Box::new(Error::NonUnicodePath { [INFO] [stdout] | _____________________^ [INFO] [stdout] 135 | | path: path_ref.to_owned(), [INFO] [stdout] 136 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 142 | .map_err(|err| Error::Credential { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | name: path_str.to_owned(), [INFO] [stdout] 144 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:198:35 [INFO] [stdout] | [INFO] [stdout] 198 | with_client(|client| Box::pin(client.var(name))).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:204:35 [INFO] [stdout] | [INFO] [stdout] 204 | with_client(|client| Box::pin(client.file(path))).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:171:73 [INFO] [stdout] | [INFO] [stdout] 171 | Secretfile::read_internal(read).map_err(|err| Error::Secretfile(Box::new(err))) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let path = path.as_ref(); [INFO] [stdout] 177 | let mut file = File::open(path).map_err(|err| Error::FileRead { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Secretfile::read(&mut file).map_err(|err| Error::FileRead { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:179:21 [INFO] [stdout] | [INFO] [stdout] 177 | let mut file = File::open(path).map_err(|err| Error::FileRead { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | path: path.to_owned(), [INFO] [stdout] 179 | source: Box::new(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 181 | Secretfile::read(&mut file).map_err(|err| Error::FileRead { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | path: path.to_owned(), [INFO] [stdout] 183 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secretfile.rs:214:50 [INFO] [stdout] | [INFO] [stdout] 214 | .map_err(|err| Error::Secretfile(Box::new(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:49:49 [INFO] [stdout] | [INFO] [stdout] 49 | .map_err(|err| Error::MissingVaultToken(Box::new(err))) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 93 | fn new(client: reqwest::Client, addr: U, token: S) -> Result [INFO] [stdout] | ----------------------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 99 | | client, [INFO] [stdout] 100 | | addr: addr.into(), [INFO] [stdout] 101 | | token: token.into(), [INFO] [stdout] 102 | | secrets: BTreeMap::new(), [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 111 | let mkerr = |err| Error::Url { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | url: url.clone(), [INFO] [stdout] 113 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:124:37 [INFO] [stdout] | [INFO] [stdout] 124 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:130:41 [INFO] [stdout] | [INFO] [stdout] 130 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 16 | fs::read_to_string(KUBERNETES_TOKEN_PATH).map_err(|err| Error::FileRead { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | path: Path::new(KUBERNETES_TOKEN_PATH).to_owned(), [INFO] [stdout] 18 | source: Box::new(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mkerr = |err| Error::Url { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | url: url.to_owned(), [INFO] [stdout] 56 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:68:33 [INFO] [stdout] | [INFO] [stdout] 68 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/kubernetes.rs:84:37 [INFO] [stdout] | [INFO] [stdout] 84 | .map_err(|err| (&mkerr)(Error::Other(err.into())))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `credentials` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "39afe3be8e3b05901609f1200902e85d291626fe6d887a321544710012a474b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39afe3be8e3b05901609f1200902e85d291626fe6d887a321544710012a474b3", kill_on_drop: false }` [INFO] [stdout] 39afe3be8e3b05901609f1200902e85d291626fe6d887a321544710012a474b3