[INFO] fetching crate create-rust-github-repo 0.5.4... [INFO] checking create-rust-github-repo-0.5.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate create-rust-github-repo 0.5.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate create-rust-github-repo 0.5.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate create-rust-github-repo 0.5.4 [INFO] finished tweaking crates.io crate create-rust-github-repo 0.5.4 [INFO] tweaked toml for crates.io crate create-rust-github-repo 0.5.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate create-rust-github-repo 0.5.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8da98f4c8c7e5f3d54d3662b4975c2a0c2c843abda2d0c4762fa43702a2cbae6 [INFO] running `Command { std: "docker" "start" "-a" "8da98f4c8c7e5f3d54d3662b4975c2a0c2c843abda2d0c4762fa43702a2cbae6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8da98f4c8c7e5f3d54d3662b4975c2a0c2c843abda2d0c4762fa43702a2cbae6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8da98f4c8c7e5f3d54d3662b4975c2a0c2c843abda2d0c4762fa43702a2cbae6", kill_on_drop: false }` [INFO] [stdout] 8da98f4c8c7e5f3d54d3662b4975c2a0c2c843abda2d0c4762fa43702a2cbae6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b40fa78fe88d4841e315b5d60de6d4d01417459663120d12d0f971cbfaefef37 [INFO] running `Command { std: "docker" "start" "-a" "b40fa78fe88d4841e315b5d60de6d4d01417459663120d12d0f971cbfaefef37", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling derive-new v0.6.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling derive_setters v0.1.6 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking create-rust-github-repo v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 276 | pub fn spawn_and_wait(&self, command: impl AsRef, current_dir: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | / Command::new(&self.cmd) [INFO] [stdout] 278 | | .args(&self.args) [INFO] [stdout] 279 | | .arg("-c") [INFO] [stdout] 280 | | .arg(command) [INFO] [stdout] 281 | | .current_dir(current_dir) [INFO] [stdout] 282 | | .spawn()? [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn exec(&self, command: impl AsRef, current_dir: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | self.spawn_and_wait(command, current_dir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn is_success(&self, command: impl AsRef, current_dir: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | self.spawn_and_wait(command, current_dir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:5 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn replace_args(args: impl IntoIterator, substitutions: &HashMap<&str, &str>) -> Vec { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | / args.into_iter() [INFO] [stdout] 340 | | .map(|arg| replace_all(arg, substitutions)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `create-rust-github-repo` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 276 | pub fn spawn_and_wait(&self, command: impl AsRef, current_dir: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | / Command::new(&self.cmd) [INFO] [stdout] 278 | | .args(&self.args) [INFO] [stdout] 279 | | .arg("-c") [INFO] [stdout] 280 | | .arg(command) [INFO] [stdout] 281 | | .current_dir(current_dir) [INFO] [stdout] 282 | | .spawn()? [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn exec(&self, command: impl AsRef, current_dir: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | self.spawn_and_wait(command, current_dir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn is_success(&self, command: impl AsRef, current_dir: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | self.spawn_and_wait(command, current_dir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:5 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn replace_args(args: impl IntoIterator, substitutions: &HashMap<&str, &str>) -> Vec { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | / args.into_iter() [INFO] [stdout] 340 | | .map(|arg| replace_all(arg, substitutions)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `create-rust-github-repo` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "b40fa78fe88d4841e315b5d60de6d4d01417459663120d12d0f971cbfaefef37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b40fa78fe88d4841e315b5d60de6d4d01417459663120d12d0f971cbfaefef37", kill_on_drop: false }` [INFO] [stdout] b40fa78fe88d4841e315b5d60de6d4d01417459663120d12d0f971cbfaefef37