[INFO] fetching crate creak 0.3.0... [INFO] checking creak-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate creak 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate creak 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate creak 0.3.0 [INFO] finished tweaking crates.io crate creak 0.3.0 [INFO] tweaked toml for crates.io crate creak 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate creak 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d5c496ecf26f1f9a04bc7922fa1b59fb3b2405b879c39c66704ee9818b5fbb6 [INFO] running `Command { std: "docker" "start" "-a" "9d5c496ecf26f1f9a04bc7922fa1b59fb3b2405b879c39c66704ee9818b5fbb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d5c496ecf26f1f9a04bc7922fa1b59fb3b2405b879c39c66704ee9818b5fbb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d5c496ecf26f1f9a04bc7922fa1b59fb3b2405b879c39c66704ee9818b5fbb6", kill_on_drop: false }` [INFO] [stdout] 9d5c496ecf26f1f9a04bc7922fa1b59fb3b2405b879c39c66704ee9818b5fbb6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a442fe70f04299516d20c1494cb5d4093c5921703af9f9e97f8f988169f4764 [INFO] running `Command { std: "docker" "start" "-a" "8a442fe70f04299516d20c1494cb5d4093c5921703af9f9e97f8f988169f4764", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Checking tinyvec v0.3.4 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Checking lewton v0.10.1 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking minimp3 v0.5.0 [INFO] [stderr] Checking creak v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | decoder: FormatDecoder::open(path)? [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn open_raw>(path: P, spec: RawAudioSpec) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let f = File::open(path).map_err(DecoderError::IOError)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | decoder: FormatDecoder::Raw(RawDecoder::new(BufReader::new(f), spec)?) [INFO] [stdout] 158 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Err(DecoderError::NoExtension) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/raw.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(mut reader: R, spec: RawAudioSpec) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | reader, [INFO] [stdout] 27 | | spec, [INFO] [stdout] 28 | | info [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/raw.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn into_samples<'a>(self) -> Result>>, DecoderError> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(match self.spec.sample_format { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | RawSampleFormat::Float32 => sample_iterator!(move |reader: &mut R| { [INFO] [stdout] 95 | | const SIZEOF_FLOAT: usize = 4; [INFO] [stdout] 96 | | let mut buf = [0; SIZEOF_FLOAT]; [INFO] [stdout] ... | [INFO] [stdout] 158 | | RawSampleFormat::Signed64 => sample_iterator!(signed i64), [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let reader = WavReader::open(path).map_err(hound_err_to_decoder_err)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | spec: reader.spec(), [INFO] [stdout] 18 | | reader [INFO] [stdout] 19 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn into_samples(self) -> Result>>, DecoderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let spec = self.spec; [INFO] [stdout] 34 | Ok(match (spec.bits_per_sample, spec.sample_format) { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | (8, hound::SampleFormat::Int) => { [INFO] [stdout] 36 | | let iter = self.reader.into_samples::() [INFO] [stdout] 37 | | .map(|sample| [INFO] [stdout] ... | [INFO] [stdout] 80 | | (other_bps, other_format) => return Err(DecoderError::FormatError(format!("wav: format '{}-bit {:?}' is not supported", other... [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | / sample [INFO] [stdout] 39 | | .map(|sample| sample as f32 / i8::MAX as f32) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / sample [INFO] [stdout] 48 | | .map(|sample| sample as f32 / i16::MAX as f32) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | / sample [INFO] [stdout] 59 | | .map(|sample| sample as f32 / MAX_I24 as f32) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 67 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / sample [INFO] [stdout] 69 | | .map(|sample| sample as f32 / i32::MAX as f32) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/vorbis.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let f = File::open(path).map_err(|err| DecoderError::IOError(err))?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let reader = match OggStreamReader::new(f) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(reader) => reader, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | channels: reader.ident_hdr.audio_channels as usize, [INFO] [stdout] 26 | | sample_rate: reader.ident_hdr.audio_sample_rate, [INFO] [stdout] 27 | | reader, [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/vorbis.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn into_samples(mut self) -> Result>>, DecoderError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(Box::new(OggSampleIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | cur_packet: self.reader.read_dec_packet_itl().map_err(vorbis_err_to_decoder_err)?, [INFO] [stdout] 44 | | reader: self.reader, [INFO] [stdout] 45 | | packet_cursor: 0, [INFO] [stdout] 46 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/mp3.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let f = File::open(path).map_err(|err| DecoderError::IOError(err))?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut reader = Mp3Reader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Err(other) => return Err(mp3_err_to_decoder_err(other)) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | sample_rate: first_frame.sample_rate as _, [INFO] [stdout] 29 | | channels: first_frame.channels as _, [INFO] [stdout] 30 | | first_frame, [INFO] [stdout] 31 | | reader, [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/mp3.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn into_samples(self) -> Result>>, DecoderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Box::new(Mp3SampleIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | expected_channels: self.channels, [INFO] [stdout] 50 | | expected_sample_rate: self.sample_rate, [INFO] [stdout] 51 | | cur_frame: self.first_frame, [INFO] [stdout] 52 | | frame_cursor: 0, [INFO] [stdout] 53 | | reader: self.reader [INFO] [stdout] 54 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/flac.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let reader = FlacReader::open(path).map_err(flac_err_as_decoder_err)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let (sample_rate, channels) = (reader.streaminfo().sample_rate, reader.streaminfo().channels); [INFO] [stdout] 18 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | sample_rate, [INFO] [stdout] 20 | | channels: channels as _, [INFO] [stdout] 21 | | reader [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/flac.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn into_samples(self) -> Result>>, DecoderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Box::new(FlacSampleIterator::new(self.reader))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `creak` (lib test) due to 18 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | decoder: FormatDecoder::open(path)? [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn open_raw>(path: P, spec: RawAudioSpec) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let f = File::open(path).map_err(DecoderError::IOError)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | decoder: FormatDecoder::Raw(RawDecoder::new(BufReader::new(f), spec)?) [INFO] [stdout] 158 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Err(DecoderError::NoExtension) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/raw.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(mut reader: R, spec: RawAudioSpec) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | reader, [INFO] [stdout] 27 | | spec, [INFO] [stdout] 28 | | info [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/raw.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn into_samples<'a>(self) -> Result>>, DecoderError> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(match self.spec.sample_format { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | RawSampleFormat::Float32 => sample_iterator!(move |reader: &mut R| { [INFO] [stdout] 95 | | const SIZEOF_FLOAT: usize = 4; [INFO] [stdout] 96 | | let mut buf = [0; SIZEOF_FLOAT]; [INFO] [stdout] ... | [INFO] [stdout] 158 | | RawSampleFormat::Signed64 => sample_iterator!(signed i64), [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let reader = WavReader::open(path).map_err(hound_err_to_decoder_err)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | spec: reader.spec(), [INFO] [stdout] 18 | | reader [INFO] [stdout] 19 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn into_samples(self) -> Result>>, DecoderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let spec = self.spec; [INFO] [stdout] 34 | Ok(match (spec.bits_per_sample, spec.sample_format) { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | (8, hound::SampleFormat::Int) => { [INFO] [stdout] 36 | | let iter = self.reader.into_samples::() [INFO] [stdout] 37 | | .map(|sample| [INFO] [stdout] ... | [INFO] [stdout] 80 | | (other_bps, other_format) => return Err(DecoderError::FormatError(format!("wav: format '{}-bit {:?}' is not supported", other... [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | / sample [INFO] [stdout] 39 | | .map(|sample| sample as f32 / i8::MAX as f32) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / sample [INFO] [stdout] 48 | | .map(|sample| sample as f32 / i16::MAX as f32) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | / sample [INFO] [stdout] 59 | | .map(|sample| sample as f32 / MAX_I24 as f32) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/wav.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 67 | .map(|sample| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / sample [INFO] [stdout] 69 | | .map(|sample| sample as f32 / i32::MAX as f32) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/vorbis.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let f = File::open(path).map_err(|err| DecoderError::IOError(err))?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let reader = match OggStreamReader::new(f) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(reader) => reader, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | channels: reader.ident_hdr.audio_channels as usize, [INFO] [stdout] 26 | | sample_rate: reader.ident_hdr.audio_sample_rate, [INFO] [stdout] 27 | | reader, [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/vorbis.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn into_samples(mut self) -> Result>>, DecoderError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(Box::new(OggSampleIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | cur_packet: self.reader.read_dec_packet_itl().map_err(vorbis_err_to_decoder_err)?, [INFO] [stdout] 44 | | reader: self.reader, [INFO] [stdout] 45 | | packet_cursor: 0, [INFO] [stdout] 46 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/mp3.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let f = File::open(path).map_err(|err| DecoderError::IOError(err))?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut reader = Mp3Reader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Err(other) => return Err(mp3_err_to_decoder_err(other)) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | sample_rate: first_frame.sample_rate as _, [INFO] [stdout] 29 | | channels: first_frame.channels as _, [INFO] [stdout] 30 | | first_frame, [INFO] [stdout] 31 | | reader, [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/mp3.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn into_samples(self) -> Result>>, DecoderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Box::new(Mp3SampleIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | expected_channels: self.channels, [INFO] [stdout] 50 | | expected_sample_rate: self.sample_rate, [INFO] [stdout] 51 | | cur_frame: self.first_frame, [INFO] [stdout] 52 | | frame_cursor: 0, [INFO] [stdout] 53 | | reader: self.reader [INFO] [stdout] 54 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/flac.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let reader = FlacReader::open(path).map_err(flac_err_as_decoder_err)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let (sample_rate, channels) = (reader.streaminfo().sample_rate, reader.streaminfo().channels); [INFO] [stdout] 18 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | sample_rate, [INFO] [stdout] 20 | | channels: channels as _, [INFO] [stdout] 21 | | reader [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/flac.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn into_samples(self) -> Result>>, DecoderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Box::new(FlacSampleIterator::new(self.reader))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `creak` (lib) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "8a442fe70f04299516d20c1494cb5d4093c5921703af9f9e97f8f988169f4764", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a442fe70f04299516d20c1494cb5d4093c5921703af9f9e97f8f988169f4764", kill_on_drop: false }` [INFO] [stdout] 8a442fe70f04299516d20c1494cb5d4093c5921703af9f9e97f8f988169f4764