[INFO] fetching crate crate2nix 0.14.1... [INFO] checking crate2nix-0.14.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate crate2nix 0.14.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate crate2nix 0.14.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crate2nix 0.14.1 [INFO] finished tweaking crates.io crate crate2nix 0.14.1 [INFO] tweaked toml for crates.io crate crate2nix 0.14.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate crate2nix 0.14.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6cf1f1d6df6fb308a6521f2dd83a77450aa723ad1b81702d60914deebd5493cd [INFO] running `Command { std: "docker" "start" "-a" "6cf1f1d6df6fb308a6521f2dd83a77450aa723ad1b81702d60914deebd5493cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6cf1f1d6df6fb308a6521f2dd83a77450aa723ad1b81702d60914deebd5493cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cf1f1d6df6fb308a6521f2dd83a77450aa723ad1b81702d60914deebd5493cd", kill_on_drop: false }` [INFO] [stdout] 6cf1f1d6df6fb308a6521f2dd83a77450aa723ad1b81702d60914deebd5493cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2927ea23886ab1524718439b324a619dfde28be0c13e688474623a9488daaad9 [INFO] running `Command { std: "docker" "start" "-a" "2927ea23886ab1524718439b324a619dfde28be0c13e688474623a9488daaad9", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde_json v1.0.118 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tinyvec v1.6.1 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking nix-base32 v0.1.1 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking colored-diff v0.2.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking crate2nix v0.14.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 126 | metadata: IndexedMetadata, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | ) -> Result { [INFO] [stdout] 128 | let crate2nix_json = crate::config::Config::read_from_or_default( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(BuildInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 137 | | root_package_id: metadata.root.clone(), [INFO] [stdout] 138 | | workspace_members: metadata [INFO] [stdout] 139 | | .workspace_members [INFO] [stdout] ... | [INFO] [stdout] 157 | | config: config.clone(), [INFO] [stdout] 158 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(path).context(format!("while opening {}", path.to_string_lossy()))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | serde_json::from_reader(reader).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 170 | fn deserialize(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | String::deserialize(d).and_then(|string| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn merge(metadatas: Vec) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut package_ids = HashSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let mut packages = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut node_package_ids = HashSet::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut nodes = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(MergedMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | packages, [INFO] [stdout] 73 | | root, [INFO] [stdout] 74 | | workspace_members: workspace_members.into_iter().unique().collect(), [INFO] [stdout] 75 | | nodes, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 106 | let pkgs_by_id: BTreeMap = packages [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let nodes_by_id: BTreeMap = nodes [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(IndexedMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | root: root.as_ref().map(|id| id_shortener.shorten(id)), [INFO] [stdout] 128 | | workspace_members: workspace_members [INFO] [stdout] 129 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 134 | | id_shortener, [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 104 | let generated = reader.lines().any(|l| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | l.map(|l| l.contains("@generated by crate2nix")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 67 | let build_dependencies = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let dependencies = resolved_dependencies.filtered_dependencies(|d| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let dev_dependencies = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let configured_source = if is_root_or_workspace_member { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let configured_source = package_path [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let source = if let Some(configured) = configured_source { [INFO] [stdout] | ------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(CrateDerivation { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | crate_name: package.name.clone(), [INFO] [stdout] 160 | | edition: package.edition.to_string(), [INFO] [stdout] 161 | | authors: package.authors.clone(), [INFO] [stdout] ... | [INFO] [stdout] 191 | | is_root_or_workspace_member, [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:133:32 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|target| BuildTarget::new(target, &package_path).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | .and_then(|target| BuildTarget::new(target, &package_path).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 492 | package_path: impl AsRef, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | Ok(ResolvedSource::LocalDirectory(LocalDirectorySource { [INFO] [stdout] | ____________^ [INFO] [stdout] 508 | | path, [INFO] [stdout] 509 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn crates_io_source(name: String, version: Version) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let prefetchable = CratesIoSource { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(config::Source::CratesIo { [INFO] [stdout] | ________^ [INFO] [stdout] 30 | | name, [INFO] [stdout] 31 | | version, [INFO] [stdout] 32 | | sha256, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | Ok(config::Source::Git { url, rev, sha256 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 91 | let generated = reader.lines().any(|l| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | l.map(|l| l.contains("@generated by crate2nix")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:128:31 [INFO] [stdout] | [INFO] [stdout] 128 | .and_then(|m| m.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn find_duplicates<'a, T: Ord>(source: impl Iterator) -> Vec<&'a T> { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let mut seen = BTreeSet::new(); [INFO] [stdout] 15 | source.filter(|v| !seen.insert(*v)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crate2nix` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 126 | metadata: IndexedMetadata, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | ) -> Result { [INFO] [stdout] 128 | let crate2nix_json = crate::config::Config::read_from_or_default( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(BuildInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 137 | | root_package_id: metadata.root.clone(), [INFO] [stdout] 138 | | workspace_members: metadata [INFO] [stdout] 139 | | .workspace_members [INFO] [stdout] ... | [INFO] [stdout] 157 | | config: config.clone(), [INFO] [stdout] 158 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(path).context(format!("while opening {}", path.to_string_lossy()))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | serde_json::from_reader(reader).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 170 | fn deserialize(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | String::deserialize(d).and_then(|string| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn merge(metadatas: Vec) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut package_ids = HashSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let mut packages = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut node_package_ids = HashSet::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut nodes = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(MergedMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | packages, [INFO] [stdout] 73 | | root, [INFO] [stdout] 74 | | workspace_members: workspace_members.into_iter().unique().collect(), [INFO] [stdout] 75 | | nodes, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 106 | let pkgs_by_id: BTreeMap = packages [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let nodes_by_id: BTreeMap = nodes [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(IndexedMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | root: root.as_ref().map(|id| id_shortener.shorten(id)), [INFO] [stdout] 128 | | workspace_members: workspace_members [INFO] [stdout] 129 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 134 | | id_shortener, [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 104 | let generated = reader.lines().any(|l| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | l.map(|l| l.contains("@generated by crate2nix")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 67 | let build_dependencies = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let dependencies = resolved_dependencies.filtered_dependencies(|d| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let dev_dependencies = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let configured_source = if is_root_or_workspace_member { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let configured_source = package_path [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let source = if let Some(configured) = configured_source { [INFO] [stdout] | ------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(CrateDerivation { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | crate_name: package.name.clone(), [INFO] [stdout] 160 | | edition: package.edition.to_string(), [INFO] [stdout] 161 | | authors: package.authors.clone(), [INFO] [stdout] ... | [INFO] [stdout] 191 | | is_root_or_workspace_member, [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:133:32 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|target| BuildTarget::new(target, &package_path).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | .and_then(|target| BuildTarget::new(target, &package_path).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 492 | package_path: impl AsRef, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | Ok(ResolvedSource::LocalDirectory(LocalDirectorySource { [INFO] [stdout] | ____________^ [INFO] [stdout] 508 | | path, [INFO] [stdout] 509 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn crates_io_source(name: String, version: Version) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let prefetchable = CratesIoSource { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(config::Source::CratesIo { [INFO] [stdout] | ________^ [INFO] [stdout] 30 | | name, [INFO] [stdout] 31 | | version, [INFO] [stdout] 32 | | sha256, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | Ok(config::Source::Git { url, rev, sha256 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 91 | let generated = reader.lines().any(|l| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | l.map(|l| l.contains("@generated by crate2nix")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources.rs:128:31 [INFO] [stdout] | [INFO] [stdout] 128 | .and_then(|m| m.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 262 | fn from_value_unwrap(json: impl Fn() -> serde_json::Value) -> T [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | from_value(json()).unwrap_or_else(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | from_value_unwrap(|| serde_json::json!($($json)+)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 300 | let crate_dir: TempDir = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | inner: from_json!( [INFO] [stdout] | ________________- [INFO] [stdout] 305 | | { [INFO] [stdout] 306 | | "name": name, [INFO] [stdout] 307 | | "version": version, [INFO] [stdout] ... | [INFO] [stdout] 313 | | "features": {}, [INFO] [stdout] 314 | | }), [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_json` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn find_duplicates<'a, T: Ord>(source: impl Iterator) -> Vec<&'a T> { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let mut seen = BTreeSet::new(); [INFO] [stdout] 15 | source.filter(|v| !seen.insert(*v)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crate2nix` (lib test) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "2927ea23886ab1524718439b324a619dfde28be0c13e688474623a9488daaad9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2927ea23886ab1524718439b324a619dfde28be0c13e688474623a9488daaad9", kill_on_drop: false }` [INFO] [stdout] 2927ea23886ab1524718439b324a619dfde28be0c13e688474623a9488daaad9