[INFO] fetching crate cranelift-interpreter 0.111.0... [INFO] checking cranelift-interpreter-0.111.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cranelift-interpreter 0.111.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cranelift-interpreter 0.111.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cranelift-interpreter 0.111.0 [INFO] finished tweaking crates.io crate cranelift-interpreter 0.111.0 [INFO] tweaked toml for crates.io crate cranelift-interpreter 0.111.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0a2feca94ae29d6d07f53aebf7809dfdec29450aafd149652e2efa58b1c2e77 [INFO] running `Command { std: "docker" "start" "-a" "b0a2feca94ae29d6d07f53aebf7809dfdec29450aafd149652e2efa58b1c2e77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0a2feca94ae29d6d07f53aebf7809dfdec29450aafd149652e2efa58b1c2e77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0a2feca94ae29d6d07f53aebf7809dfdec29450aafd149652e2efa58b1c2e77", kill_on_drop: false }` [INFO] [stdout] b0a2feca94ae29d6d07f53aebf7809dfdec29450aafd149652e2efa58b1c2e77 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ded09149bcd6a8b0023e38c867815fb570dae5e8a6f8690dd586311d56edaf7 [INFO] running `Command { std: "docker" "start" "-a" "3ded09149bcd6a8b0023e38c867815fb570dae5e8a6f8690dd586311d56edaf7", kill_on_drop: false }` [INFO] [stderr] Compiling cranelift-isle v0.111.0 [INFO] [stderr] Compiling cranelift-codegen-shared v0.111.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking cranelift-bitset v0.111.0 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Checking slice-group-by v0.3.1 [INFO] [stderr] Checking arbitrary v1.3.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling cranelift-codegen-meta v0.111.0 [INFO] [stderr] Checking cranelift-entity v0.111.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking cranelift-bforest v0.111.0 [INFO] [stderr] Checking cranelift-control v0.111.0 [INFO] [stderr] Checking regalloc2 v0.9.3 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling cranelift-codegen v0.111.0 [INFO] [stderr] Checking cranelift-reader v0.111.0 [INFO] [stderr] Checking cranelift-frontend v0.111.0 [INFO] [stderr] Checking cranelift-interpreter v0.111.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:313:8 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn step<'a, I>(state: &mut dyn State<'a>, inst_context: I) -> Result, StepError> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | Ok(match inst.opcode() { [INFO] [stdout] | ________^ [INFO] [stdout] 314 | | Opcode::Jump => { [INFO] [stdout] 315 | | if let InstructionData::Jump { destination, .. } = inst { [INFO] [stdout] 316 | | continue_at(destination)? [INFO] [stdout] ... | [INFO] [stdout] 1288 | | Opcode::X86Cvtt2dq => unimplemented!("X86Cvtt2dq"), [INFO] [stdout] 1289 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:147:70 [INFO] [stdout] | [INFO] [stdout] 147 | let assign_multiple = |values: &[DataValue]| ControlFlow::Assign(SmallVec::from(values)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 237 | let branch_args = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | state.collect_values(block.args_slice(&state.get_current_function().dfg.value_lists)); [INFO] [stdout] 239 | Ok(ControlFlow::ContinueAt( [INFO] [stdout] | ____________^ [INFO] [stdout] 240 | | block.block(&state.get_current_function().dfg.value_lists), [INFO] [stdout] 241 | | branch_args, [INFO] [stdout] 242 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:283:16 [INFO] [stdout] | [INFO] [stdout] 269 | args: SmallVec<[DataValue; 1]>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(match func_ref { [INFO] [stdout] | ________________^ [INFO] [stdout] 284 | | InterpreterFunctionRef::Function(func) => make_ctrl_flow(func, args), [INFO] [stdout] 285 | | InterpreterFunctionRef::LibCall(libcall) => { [INFO] [stdout] 286 | | debug_assert!( [INFO] [stdout] ... | [INFO] [stdout] 308 | | } [INFO] [stdout] 309 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:1490:5 [INFO] [stdout] | [INFO] [stdout] 1486 | fn fold_vector(v: DataValue, ty: types::Type, init: DataValue, op: F) -> ValueResult [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1490 | extractlanes(&v, ty)?.into_iter().try_fold(init, op) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cranelift-interpreter` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:763:28 [INFO] [stdout] | [INFO] [stdout] 747 | let funcs = parse_functions(code).unwrap().to_vec(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 751 | let result = Interpreter::new(state) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 763 | assert_eq!(result, ControlFlow::Return(smallvec![DataValue::I64(26)])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:972:13 [INFO] [stdout] | [INFO] [stdout] 956 | let func = parse_functions(code).unwrap().into_iter().next().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 968 | let result = Interpreter::new(state).call_by_name("%test", &[]).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 972 | ControlFlow::Return(smallvec![DataValue::F32(Ieee32::with_float(1.0))]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:313:8 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn step<'a, I>(state: &mut dyn State<'a>, inst_context: I) -> Result, StepError> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | Ok(match inst.opcode() { [INFO] [stdout] | ________^ [INFO] [stdout] 314 | | Opcode::Jump => { [INFO] [stdout] 315 | | if let InstructionData::Jump { destination, .. } = inst { [INFO] [stdout] 316 | | continue_at(destination)? [INFO] [stdout] ... | [INFO] [stdout] 1288 | | Opcode::X86Cvtt2dq => unimplemented!("X86Cvtt2dq"), [INFO] [stdout] 1289 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:147:70 [INFO] [stdout] | [INFO] [stdout] 147 | let assign_multiple = |values: &[DataValue]| ControlFlow::Assign(SmallVec::from(values)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 237 | let branch_args = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | state.collect_values(block.args_slice(&state.get_current_function().dfg.value_lists)); [INFO] [stdout] 239 | Ok(ControlFlow::ContinueAt( [INFO] [stdout] | ____________^ [INFO] [stdout] 240 | | block.block(&state.get_current_function().dfg.value_lists), [INFO] [stdout] 241 | | branch_args, [INFO] [stdout] 242 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:283:16 [INFO] [stdout] | [INFO] [stdout] 269 | args: SmallVec<[DataValue; 1]>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(match func_ref { [INFO] [stdout] | ________________^ [INFO] [stdout] 284 | | InterpreterFunctionRef::Function(func) => make_ctrl_flow(func, args), [INFO] [stdout] 285 | | InterpreterFunctionRef::LibCall(libcall) => { [INFO] [stdout] 286 | | debug_assert!( [INFO] [stdout] ... | [INFO] [stdout] 308 | | } [INFO] [stdout] 309 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/step.rs:1490:5 [INFO] [stdout] | [INFO] [stdout] 1486 | fn fold_vector(v: DataValue, ty: types::Type, init: DataValue, op: F) -> ValueResult [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1490 | extractlanes(&v, ty)?.into_iter().try_fold(init, op) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:914:9 [INFO] [stdout] | [INFO] [stdout] 912 | let itr = dv.iter_lanes(ty).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 913 | [INFO] [stdout] 914 | / itr.map(|e| { [INFO] [stdout] 915 | | if let Some(v) = e.into_int_signed().ok() { [INFO] [stdout] 916 | | v [INFO] [stdout] 917 | | } else { [INFO] [stdout] 918 | | 0 [INFO] [stdout] 919 | | } [INFO] [stdout] 920 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cranelift-interpreter` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "3ded09149bcd6a8b0023e38c867815fb570dae5e8a6f8690dd586311d56edaf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ded09149bcd6a8b0023e38c867815fb570dae5e8a6f8690dd586311d56edaf7", kill_on_drop: false }` [INFO] [stdout] 3ded09149bcd6a8b0023e38c867815fb570dae5e8a6f8690dd586311d56edaf7