[INFO] fetching crate cradle 0.2.2... [INFO] checking cradle-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cradle 0.2.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cradle 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cradle 0.2.2 [INFO] finished tweaking crates.io crate cradle 0.2.2 [INFO] tweaked toml for crates.io crate cradle 0.2.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate cradle 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 822c3f8952278d68792443673fe3b6ebf4608de58abf3e1d7e73843fdab25cb2 [INFO] running `Command { std: "docker" "start" "-a" "822c3f8952278d68792443673fe3b6ebf4608de58abf3e1d7e73843fdab25cb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "822c3f8952278d68792443673fe3b6ebf4608de58abf3e1d7e73843fdab25cb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "822c3f8952278d68792443673fe3b6ebf4608de58abf3e1d7e73843fdab25cb2", kill_on_drop: false }` [INFO] [stdout] 822c3f8952278d68792443673fe3b6ebf4608de58abf3e1d7e73843fdab25cb2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fe3e579246238ce28a376b2374a3223a65126c313db5e538fec47d2643c16c4 [INFO] running `Command { std: "docker" "start" "-a" "5fe3e579246238ce28a376b2374a3223a65126c313db5e538fec47d2643c16c4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking executable-path v1.0.0 [INFO] [stderr] Checking unindent v0.1.8 [INFO] [stderr] Checking pretty_assertions v1.2.1 [INFO] [stderr] Checking cradle v0.2.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collected_output.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 18 | mut source: impl Read + Send + 'static, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | mut relay_sink: impl Write + Send + 'static, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> JoinHandle>>> { [INFO] [stdout] 21 | thread::spawn(move || -> io::Result>> { [INFO] [stdout] | _______________________^ [INFO] [stdout] 22 | | let mut collected = if capture_stream { [INFO] [stdout] 23 | | Some(Vec::new()) [INFO] [stdout] 24 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 40 | | Ok(collected) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collected_output.rs:56:27 [INFO] [stdout] | [INFO] [stdout] 47 | mut child_stdin: ChildStdin, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let stdin_join_handle = config.stdin.clone().map(|config_stdin| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | thread::spawn(move || -> io::Result<()> { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 57 | | child_stdin.write_all(&config_stdin)?; [INFO] [stdout] 58 | | Ok(()) [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:192:24 [INFO] [stdout] | [INFO] [stdout] 188 | fn run_output(self) -> O [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | panic_on_error(self.run_result()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cradle` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5fe3e579246238ce28a376b2374a3223a65126c313db5e538fec47d2643c16c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fe3e579246238ce28a376b2374a3223a65126c313db5e538fec47d2643c16c4", kill_on_drop: false }` [INFO] [stdout] 5fe3e579246238ce28a376b2374a3223a65126c313db5e538fec47d2643c16c4