[INFO] fetching crate crabguard 0.1.4... [INFO] checking crabguard-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate crabguard 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate crabguard 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crabguard 0.1.4 [INFO] finished tweaking crates.io crate crabguard 0.1.4 [INFO] tweaked toml for crates.io crate crabguard 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate crabguard 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ca8ffbac6e63fcd976869729d4f1180ad2e6ef2e5cec800bd91eae881fcd084 [INFO] running `Command { std: "docker" "start" "-a" "6ca8ffbac6e63fcd976869729d4f1180ad2e6ef2e5cec800bd91eae881fcd084", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ca8ffbac6e63fcd976869729d4f1180ad2e6ef2e5cec800bd91eae881fcd084", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ca8ffbac6e63fcd976869729d4f1180ad2e6ef2e5cec800bd91eae881fcd084", kill_on_drop: false }` [INFO] [stdout] 6ca8ffbac6e63fcd976869729d4f1180ad2e6ef2e5cec800bd91eae881fcd084 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67f35ea43554861021389bbebb7c38b8fe1c4bd98a6ffac9a0e47885e739aede [INFO] running `Command { std: "docker" "start" "-a" "67f35ea43554861021389bbebb7c38b8fe1c4bd98a6ffac9a0e47885e739aede", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling semver v1.0.19 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking shlex v1.2.0 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking zeroize v1.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling portable-atomic v1.4.3 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Compiling rusoto_core v0.48.0 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking clap_builder v4.4.4 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking clap v4.4.4 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking rusoto_credential v0.48.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking rusoto_signature v0.48.0 [INFO] [stderr] Checking rusoto_s3 v0.48.0 [INFO] [stderr] Checking crabguard v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `delete` is never used [INFO] [stdout] --> src/storage/mod.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait Storage { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 12 | async fn delete(&self, plaintext_filename: &str) -> Result<(), String>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/local.rs:52:85 [INFO] [stdout] | [INFO] [stdout] 52 | async fn batch_delete(&self, _filenames: HashSet) -> Result<(), String> { [INFO] [stdout] | __________________________________---------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | | todo!() [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/s3.rs:101:84 [INFO] [stdout] | [INFO] [stdout] 101 | async fn batch_delete(&self, filenames: HashSet) -> Result<(), String> { [INFO] [stdout] | __________________________________--------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | | // Convert the filenames into a Vec [INFO] [stdout] 103 | | let filenames_vec: Vec = filenames.into_iter().collect(); [INFO] [stdout] ... | [INFO] [stdout] 131 | | Ok(()) [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crabguard` (bin "crabguard" test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `delete` is never used [INFO] [stdout] --> src/storage/mod.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait Storage { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 12 | async fn delete(&self, plaintext_filename: &str) -> Result<(), String>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/local.rs:52:85 [INFO] [stdout] | [INFO] [stdout] 52 | async fn batch_delete(&self, _filenames: HashSet) -> Result<(), String> { [INFO] [stdout] | __________________________________---------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | | todo!() [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/s3.rs:101:84 [INFO] [stdout] | [INFO] [stdout] 101 | async fn batch_delete(&self, filenames: HashSet) -> Result<(), String> { [INFO] [stdout] | __________________________________--------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | | // Convert the filenames into a Vec [INFO] [stdout] 103 | | let filenames_vec: Vec = filenames.into_iter().collect(); [INFO] [stdout] ... | [INFO] [stdout] 131 | | Ok(()) [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crabguard` (bin "crabguard") due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "67f35ea43554861021389bbebb7c38b8fe1c4bd98a6ffac9a0e47885e739aede", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67f35ea43554861021389bbebb7c38b8fe1c4bd98a6ffac9a0e47885e739aede", kill_on_drop: false }` [INFO] [stdout] 67f35ea43554861021389bbebb7c38b8fe1c4bd98a6ffac9a0e47885e739aede