[INFO] fetching crate crabchess 0.1.15... [INFO] checking crabchess-0.1.15 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate crabchess 0.1.15 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate crabchess 0.1.15 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crabchess 0.1.15 [INFO] finished tweaking crates.io crate crabchess 0.1.15 [INFO] tweaked toml for crates.io crate crabchess 0.1.15 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding compact_str v0.7.1 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98b270c30e2e77a2f650e0fe413d8947a2ca52c7dbade60cf3e36bc671693a9c [INFO] running `Command { std: "docker" "start" "-a" "98b270c30e2e77a2f650e0fe413d8947a2ca52c7dbade60cf3e36bc671693a9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98b270c30e2e77a2f650e0fe413d8947a2ca52c7dbade60cf3e36bc671693a9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98b270c30e2e77a2f650e0fe413d8947a2ca52c7dbade60cf3e36bc671693a9c", kill_on_drop: false }` [INFO] [stdout] 98b270c30e2e77a2f650e0fe413d8947a2ca52c7dbade60cf3e36bc671693a9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44b5a42562bef966b559e79caa1461104eb080e8709afc2dd2c6f5b59e330a7d [INFO] running `Command { std: "docker" "start" "-a" "44b5a42562bef966b559e79caa1461104eb080e8709afc2dd2c6f5b59e330a7d", kill_on_drop: false }` [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libmimalloc-sys v0.1.39 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking ufmt-write v0.1.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking mimalloc v0.1.43 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling ufmt-macros v0.3.0 [INFO] [stderr] Checking ufmt v0.2.0 [INFO] [stderr] Checking crabchess v0.1.15 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:26:10 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn increment(&mut self, value: T) -> isize { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | *self [INFO] [stdout] | __________^ [INFO] [stdout] 27 | | .map [INFO] [stdout] 28 | | .entry(value) [INFO] [stdout] 29 | | .and_modify(|count| { [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:40:10 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn decrement(&mut self, value: T) -> isize { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | *self [INFO] [stdout] | __________^ [INFO] [stdout] 41 | | .map [INFO] [stdout] 42 | | .entry(value) [INFO] [stdout] 43 | | .and_modify(|count| { [INFO] [stdout] ... | [INFO] [stdout] 47 | | *count -= 1; [INFO] [stdout] 48 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 75 | fn from(value: Counter) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | / value [INFO] [stdout] 77 | | .map [INFO] [stdout] 78 | | .into_iter() [INFO] [stdout] 79 | | .flat_map(|(v, c)| repeat(v).take(c.try_into().unwrap_or(0))) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:79:32 [INFO] [stdout] | [INFO] [stdout] 79 | .flat_map(|(v, c)| repeat(v).take(c.try_into().unwrap_or(0))) [INFO] [stdout] | ------ ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pgn.rs:444:12 [INFO] [stdout] | [INFO] [stdout] 441 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 443 | [INFO] [stdout] 444 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 445 | | pgn: String::new(), [INFO] [stdout] 446 | | iter: buf.lines(), [INFO] [stdout] 447 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/positions.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | board: Board::from_fen_slice(STAUNTON_PATTERN).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/positions/moves.rs:227:42 [INFO] [stdout] | [INFO] [stdout] 227 | candidates.retain(|cand| cand.pseudolegal_is_legal(position).unwrap().as_bool()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/positions/moves.rs:899:12 [INFO] [stdout] | [INFO] [stdout] 843 | let Some(ambiguous_piece_sqs) = Self::ambiguous_pieces( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 879 | let mut output = CompactString::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 899 | Ok(Some(output)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crabchess` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "44b5a42562bef966b559e79caa1461104eb080e8709afc2dd2c6f5b59e330a7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44b5a42562bef966b559e79caa1461104eb080e8709afc2dd2c6f5b59e330a7d", kill_on_drop: false }` [INFO] [stdout] 44b5a42562bef966b559e79caa1461104eb080e8709afc2dd2c6f5b59e330a7d