[INFO] fetching crate cosmogony 0.14.5... [INFO] checking cosmogony-0.14.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cosmogony 0.14.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cosmogony 0.14.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cosmogony 0.14.5 [INFO] finished tweaking crates.io crate cosmogony 0.14.5 [INFO] tweaked toml for crates.io crate cosmogony 0.14.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding as-slice v0.1.5 (latest: v0.2.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding generic-array v0.13.3 (latest: v1.1.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding geojson v0.22.4 (latest: v0.24.1) [INFO] [stderr] Adding hash32 v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.6.1 (latest: v0.8.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding pdqselect v0.1.0 (latest: v0.1.1) [INFO] [stderr] Adding protobuf v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding protobuf-codegen v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding rstar v0.8.4 (latest: v0.12.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ca8a7d775da6f99e4043fc889cc1aa7efcf0510c4655f384d8d9712d234a76b [INFO] running `Command { std: "docker" "start" "-a" "3ca8a7d775da6f99e4043fc889cc1aa7efcf0510c4655f384d8d9712d234a76b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ca8a7d775da6f99e4043fc889cc1aa7efcf0510c4655f384d8d9712d234a76b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ca8a7d775da6f99e4043fc889cc1aa7efcf0510c4655f384d8d9712d234a76b", kill_on_drop: false }` [INFO] [stdout] 3ca8a7d775da6f99e4043fc889cc1aa7efcf0510c4655f384d8d9712d234a76b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6868b36b1fe046d576b458317e65bdcb393de58a0831cfdbf68bcfb005a1486 [INFO] running `Command { std: "docker" "start" "-a" "c6868b36b1fe046d576b458317e65bdcb393de58a0831cfdbf68bcfb005a1486", kill_on_drop: false }` [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking generic-array v0.13.3 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling heapless v0.6.1 [INFO] [stderr] Checking hash32 v0.1.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking pdqselect v0.1.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking pub-iterator-type v0.1.1 [INFO] [stderr] Checking as-slice v0.1.5 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rstar v0.8.4 [INFO] [stderr] Checking geo-types v0.7.13 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking par-map v0.1.4 [INFO] [stderr] Compiling protobuf-codegen v2.28.0 [INFO] [stderr] Compiling protobuf-codegen-pure v2.28.0 [INFO] [stderr] Compiling osmpbfreader v0.16.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking flat_map v0.0.10 [INFO] [stderr] Checking geojson v0.22.4 [INFO] [stderr] Checking cosmogony v0.14.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | reader: impl std::io::BufRead, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | ) -> impl std::iter::Iterator> { [INFO] [stdout] 10 | / reader [INFO] [stdout] 11 | | .lines() [INFO] [stdout] 12 | | .map(|l| l.map_err(|err| err.into())) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | .map(|l| l.and_then(|l| serde_json::from_str(&l).map_err(|err| anyhow!("{}", err)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 16 | fn from_json_stream(reader: impl std::io::BufRead) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let zones = read_zones(reader).collect::>()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | Ok(Cosmogony { [INFO] [stdout] | ________^ [INFO] [stdout] 20 | | zones, [INFO] [stdout] 21 | | ..Default::default() [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zone.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 203 | fn deserialize_geom<'de, D>(d: D) -> Result>, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Option::::deserialize(d).map(|option| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zone.rs:274:5 [INFO] [stdout] | [INFO] [stdout] 269 | fn deserialize_as_rect<'de, D>(d: D) -> Result>, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | Option::>::deserialize(d).map(|option| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cosmogony` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | reader: impl std::io::BufRead, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | ) -> impl std::iter::Iterator> { [INFO] [stdout] 10 | / reader [INFO] [stdout] 11 | | .lines() [INFO] [stdout] 12 | | .map(|l| l.map_err(|err| err.into())) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | .map(|l| l.and_then(|l| serde_json::from_str(&l).map_err(|err| anyhow!("{}", err)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 16 | fn from_json_stream(reader: impl std::io::BufRead) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let zones = read_zones(reader).collect::>()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | Ok(Cosmogony { [INFO] [stdout] | ________^ [INFO] [stdout] 20 | | zones, [INFO] [stdout] 21 | | ..Default::default() [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zone.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 203 | fn deserialize_geom<'de, D>(d: D) -> Result>, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Option::::deserialize(d).map(|option| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zone.rs:274:5 [INFO] [stdout] | [INFO] [stdout] 269 | fn deserialize_as_rect<'de, D>(d: D) -> Result>, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | Option::>::deserialize(d).map(|option| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cosmogony` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c6868b36b1fe046d576b458317e65bdcb393de58a0831cfdbf68bcfb005a1486", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6868b36b1fe046d576b458317e65bdcb393de58a0831cfdbf68bcfb005a1486", kill_on_drop: false }` [INFO] [stdout] c6868b36b1fe046d576b458317e65bdcb393de58a0831cfdbf68bcfb005a1486