[INFO] fetching crate cosmic-text 0.12.1... [INFO] checking cosmic-text-0.12.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cosmic-text 0.12.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cosmic-text 0.12.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cosmic-text 0.12.1 [INFO] finished tweaking crates.io crate cosmic-text 0.12.1 [INFO] tweaked toml for crates.io crate cosmic-text 0.12.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 146 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding font-types v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding fontdb v0.16.2 (latest: v0.21.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding quick-xml v0.32.0 (latest: v0.36.1) [INFO] [stderr] Adding read-fonts v0.20.0 (latest: v0.21.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding rustybuzz v0.14.1 (latest: v0.18.0) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding skrifa v0.20.0 (latest: v0.21.0) [INFO] [stderr] Adding strict-num v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding ttf-parser v0.20.0 (latest: v0.24.1) [INFO] [stderr] Adding ttf-parser v0.21.1 (latest: v0.24.1) [INFO] [stderr] Adding unicode-bidi-mirroring v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding unicode-ccc v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yazi v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding zeno v0.2.3 (latest: v0.3.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e94b466fcd93631934cfe82fd05252c3c96dcb6e1bba6919b5ac0341f52b1aeb [INFO] running `Command { std: "docker" "start" "-a" "e94b466fcd93631934cfe82fd05252c3c96dcb6e1bba6919b5ac0341f52b1aeb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e94b466fcd93631934cfe82fd05252c3c96dcb6e1bba6919b5ac0341f52b1aeb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e94b466fcd93631934cfe82fd05252c3c96dcb6e1bba6919b5ac0341f52b1aeb", kill_on_drop: false }` [INFO] [stdout] e94b466fcd93631934cfe82fd05252c3c96dcb6e1bba6919b5ac0341f52b1aeb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e33de28c29e171c7f6938571d84b53d819c657bea8ab1c97d844a957d937ed1 [INFO] running `Command { std: "docker" "start" "-a" "7e33de28c29e171c7f6938571d84b53d819c657bea8ab1c97d844a957d937ed1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking fontconfig-parser v0.5.7 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking zeno v0.2.3 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking yazi v0.1.6 [INFO] [stderr] Checking unicode-bidi-mirroring v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking unicode-ccc v0.2.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking unicode-script v0.5.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unicode-properties v0.1.2 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rangemap v1.5.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking fontdb v0.16.2 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking font-types v0.6.0 [INFO] [stderr] Checking rustybuzz v0.14.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking read-fonts v0.20.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking skrifa v0.20.0 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking swash v0.1.18 [INFO] [stderr] Checking cosmic-text v0.12.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edit/mod.rs:343:36 [INFO] [stdout] | [INFO] [stdout] 341 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | ) -> T { [INFO] [stdout] 343 | self.inner.with_buffer_mut(|buffer| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 344 | | let mut borrowed = BorrowedWithFontSystem { [INFO] [stdout] 345 | | inner: buffer, [INFO] [stdout] 346 | | font_system: self.font_system, [INFO] [stdout] 347 | | }; [INFO] [stdout] 348 | | f(&mut borrowed) [INFO] [stdout] 349 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edit/editor.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn new(buffer: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Self { [INFO] [stdout] 100 | buffer_ref: buffer.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font/mod.rs:160:14 [INFO] [stdout] | [INFO] [stdout] 149 | let data = match &info.source { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 161 | | id: info.id, [INFO] [stdout] 162 | | monospace_fallback, [INFO] [stdout] 163 | | #[cfg(feature = "swash")] [INFO] [stdout] ... | [INFO] [stdout] 172 | | data, [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font/system.rs:241:29 [INFO] [stdout] | [INFO] [stdout] 241 | .map(|id| match Font::new(&self.db, *id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swash.rs:94:10 [INFO] [stdout] | [INFO] [stdout] 71 | let font = match font_system.get_font(cache_key.font_id) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Some(some) => some, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let path = outline.path(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Some(path.commands().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edit/mod.rs:343:36 [INFO] [stdout] | [INFO] [stdout] 341 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | ) -> T { [INFO] [stdout] 343 | self.inner.with_buffer_mut(|buffer| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 344 | | let mut borrowed = BorrowedWithFontSystem { [INFO] [stdout] 345 | | inner: buffer, [INFO] [stdout] 346 | | font_system: self.font_system, [INFO] [stdout] 347 | | }; [INFO] [stdout] 348 | | f(&mut borrowed) [INFO] [stdout] 349 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edit/editor.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn new(buffer: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Self { [INFO] [stdout] 100 | buffer_ref: buffer.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font/mod.rs:160:14 [INFO] [stdout] | [INFO] [stdout] 149 | let data = match &info.source { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 161 | | id: info.id, [INFO] [stdout] 162 | | monospace_fallback, [INFO] [stdout] 163 | | #[cfg(feature = "swash")] [INFO] [stdout] ... | [INFO] [stdout] 172 | | data, [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cosmic-text` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font/system.rs:241:29 [INFO] [stdout] | [INFO] [stdout] 241 | .map(|id| match Font::new(&self.db, *id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swash.rs:94:10 [INFO] [stdout] | [INFO] [stdout] 71 | let font = match font_system.get_font(cache_key.font_id) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Some(some) => some, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let path = outline.path(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Some(path.commands().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cosmic-text` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "7e33de28c29e171c7f6938571d84b53d819c657bea8ab1c97d844a957d937ed1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e33de28c29e171c7f6938571d84b53d819c657bea8ab1c97d844a957d937ed1", kill_on_drop: false }` [INFO] [stdout] 7e33de28c29e171c7f6938571d84b53d819c657bea8ab1c97d844a957d937ed1