[INFO] fetching crate coredump-to-stack 0.1.22... [INFO] checking coredump-to-stack-0.1.22 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate coredump-to-stack 0.1.22 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate coredump-to-stack 0.1.22 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate coredump-to-stack 0.1.22 [INFO] finished tweaking crates.io crate coredump-to-stack 0.1.22 [INFO] tweaked toml for crates.io crate coredump-to-stack 0.1.22 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding gimli v0.26.2 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding object v0.29.0 (latest: v0.36.4) [INFO] [stderr] Adding wasmparser v0.57.0 (latest: v0.216.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97122601d42800f079fa6e42a32e20d75a53af190eecbdc6491ba14b31960b27 [INFO] running `Command { std: "docker" "start" "-a" "97122601d42800f079fa6e42a32e20d75a53af190eecbdc6491ba14b31960b27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97122601d42800f079fa6e42a32e20d75a53af190eecbdc6491ba14b31960b27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97122601d42800f079fa6e42a32e20d75a53af190eecbdc6491ba14b31960b27", kill_on_drop: false }` [INFO] [stdout] 97122601d42800f079fa6e42a32e20d75a53af190eecbdc6491ba14b31960b27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9382fb598c2cc3fc5cf90b573d9f8e01ab7ae71cc84b1cbdbc5025b5643d5538 [INFO] running `Command { std: "docker" "start" "-a" "9382fb598c2cc3fc5cf90b573d9f8e01ab7ae71cc84b1cbdbc5025b5643d5538", kill_on_drop: false }` [INFO] [stderr] Checking wasm-coredump-types v0.1.22 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking wasmparser v0.57.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking wasm-coredump-encoder v0.1.22 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking core-wasm-ast v0.1.22 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking wasm-printer v0.1.22 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking wasm-parser v0.1.22 [INFO] [stderr] Checking wasmgdb_ddbug_parser v0.3.3 [INFO] [stderr] Checking coredump-to-stack v0.1.22 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 42 | let coredump = wasm_parser::parse(coredump_bytes) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | coredump, [INFO] [stdout] 47 | | func_names: None, [INFO] [stdout] 48 | | debug_module: None, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 53 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let name_section = wasm_parser::parse_custom_section_name(name_section_bytes)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let func_names = name_section [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let func_names = func_names.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | coredump: self.coredump, [INFO] [stdout] 97 | | func_names: Some(func_names.clone()), [INFO] [stdout] 98 | | debug_module: Some(debug_module.to_owned()), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn with_debug_module(self, bytes: &[u8]) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let module = wasm_parser::parse(&bytes) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | .map_err(|err| format!("failed to parse Wasm module: {}", err))?; [INFO] [stdout] 105 | let module = core_wasm_ast::traverse::WasmModule::new(Arc::new(module)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | let func_names = module.func_names.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | [INFO] [stdout] 109 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | coredump: self.coredump, [INFO] [stdout] 111 | | func_names: Some(func_names.clone()), [INFO] [stdout] 112 | | debug_module: Some(bytes.to_owned()), [INFO] [stdout] 113 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&wasmgdb_ddbug_parser::Function<'_>` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:150:55 [INFO] [stdout] | [INFO] [stdout] 150 | new.insert(demangle(&k).to_string(), v.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 42 | let coredump = wasm_parser::parse(coredump_bytes) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | coredump, [INFO] [stdout] 47 | | func_names: None, [INFO] [stdout] 48 | | debug_module: None, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 53 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let name_section = wasm_parser::parse_custom_section_name(name_section_bytes)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let func_names = name_section [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let func_names = func_names.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | coredump: self.coredump, [INFO] [stdout] 97 | | func_names: Some(func_names.clone()), [INFO] [stdout] 98 | | debug_module: Some(debug_module.to_owned()), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coredump-to-stack` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn with_debug_module(self, bytes: &[u8]) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let module = wasm_parser::parse(&bytes) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | .map_err(|err| format!("failed to parse Wasm module: {}", err))?; [INFO] [stdout] 105 | let module = core_wasm_ast::traverse::WasmModule::new(Arc::new(module)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | let func_names = module.func_names.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | [INFO] [stdout] 109 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | coredump: self.coredump, [INFO] [stdout] 111 | | func_names: Some(func_names.clone()), [INFO] [stdout] 112 | | debug_module: Some(bytes.to_owned()), [INFO] [stdout] 113 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&wasmgdb_ddbug_parser::Function<'_>` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:150:55 [INFO] [stdout] | [INFO] [stdout] 150 | new.insert(demangle(&k).to_string(), v.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coredump-to-stack` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9382fb598c2cc3fc5cf90b573d9f8e01ab7ae71cc84b1cbdbc5025b5643d5538", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9382fb598c2cc3fc5cf90b573d9f8e01ab7ae71cc84b1cbdbc5025b5643d5538", kill_on_drop: false }` [INFO] [stdout] 9382fb598c2cc3fc5cf90b573d9f8e01ab7ae71cc84b1cbdbc5025b5643d5538