[INFO] fetching crate core_cbc_casper 0.1.0... [INFO] checking core_cbc_casper-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate core_cbc_casper 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate core_cbc_casper 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate core_cbc_casper 0.1.0 [INFO] finished tweaking crates.io crate core_cbc_casper 0.1.0 [INFO] tweaked toml for crates.io crate core_cbc_casper 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate core_cbc_casper 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b1bc66c6f8c99220e15d024383dc065f1415608d925e3d3e51c9b3146f0963e [INFO] running `Command { std: "docker" "start" "-a" "6b1bc66c6f8c99220e15d024383dc065f1415608d925e3d3e51c9b3146f0963e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b1bc66c6f8c99220e15d024383dc065f1415608d925e3d3e51c9b3146f0963e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b1bc66c6f8c99220e15d024383dc065f1415608d925e3d3e51c9b3146f0963e", kill_on_drop: false }` [INFO] [stdout] 6b1bc66c6f8c99220e15d024383dc065f1415608d925e3d3e51c9b3146f0963e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11e4812f601852b2a03f93650d6bcfdfcbc3d2a6ebf7851bc2f07b861a4ce99c [INFO] running `Command { std: "docker" "start" "-a" "11e4812f601852b2a03f93650d6bcfdfcbc3d2a6ebf7851bc2f07b861a4ce99c", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking constant_time_eq v0.1.4 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking itertools v0.8.1 [INFO] [stderr] Checking static_assertions v0.2.5 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.9 [INFO] [stderr] Compiling bincode v1.2.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking fixed-hash v0.3.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking blake2 v0.7.1 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking core_cbc_casper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests_common/vote_count.rs:176:34 [INFO] [stdout] | [INFO] [stdout] 168 | let justification = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | recursor(&justification, HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:172:15 [INFO] [stdout] | [INFO] [stdout] 171 | fn from(protoblock: ProtoBlock) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Block(Arc::new(protoblock)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 201 | let prevblock = Block::optimized_ghost(latest_messages, validators_weights)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(Block::from(ProtoBlock::new(Some(prevblock), D::default()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn new(prevblock: Option>, data: D) -> Self { [INFO] [stdout] | --------------------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | Block::from(ProtoBlock::new(prevblock, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:227:21 [INFO] [stdout] | [INFO] [stdout] 223 | prevblock_message: Option>>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | incomplete_block: Block, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | ) -> Self { [INFO] [stdout] 226 | let prevblock = prevblock_message.map(|message| Block::from(&message)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Block::from(ProtoBlock { [INFO] [stdout] | _____________________^ [INFO] [stdout] 228 | | prevblock, [INFO] [stdout] 229 | | ..((**incomplete_block.arc()).clone()) [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:271:29 [INFO] [stdout] | [INFO] [stdout] 271 | .filter(|block| block.prevblock() == Some(self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:271:50 [INFO] [stdout] | [INFO] [stdout] 271 | .filter(|block| block.prevblock() == Some(self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 381 | let protocol_state = Self::find_all_accessible_blocks(latest_messages_honest); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | let genesis_blocks = protocol_state [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | / internal( [INFO] [stdout] 389 | | genesis_blocks, [INFO] [stdout] 390 | | &protocol_state.iter().collect(), [INFO] [stdout] 391 | | scoring_function, [INFO] [stdout] ... | [INFO] [stdout] 394 | | .max_by(|left, right| right.id().cmp(&left.id())) [INFO] [stdout] 395 | | .cloned() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:348:39 [INFO] [stdout] | [INFO] [stdout] 348 | .map(|block| (*block, block.children(&protocol_state))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:464:9 [INFO] [stdout] | [INFO] [stdout] 407 | let protocol_state = Self::find_all_accessible_blocks(latest_messages_honest); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let genesis_blocks: HashSet<&Block> = protocol_state [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | let mut latest_messages_validators = HashMap::new(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let mut result = HashSet::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | / result [INFO] [stdout] 465 | | .into_iter() [INFO] [stdout] 466 | | .max_by(|left, right| right.id().cmp(&left.id())) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:568:9 [INFO] [stdout] | [INFO] [stdout] 471 | block: Block, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | let latest_containing_block: HashSet<&Message>> = latest_messages_honest [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 495 | let latest_agreeing_in_validator_view: HashMap<_, HashMap<_, Message>>> = [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 509 | let neighbours: HashMap<&D::ValidatorName, HashSet<&D::ValidatorName>> = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 558 | let p = neighbours [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 564 | let mut mx_clqs = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 568 | / mx_clqs [INFO] [stdout] 569 | | .into_iter() [INFO] [stdout] 570 | | .filter(|x| { [INFO] [stdout] 571 | | x.iter().fold(>::ZERO, |acc, validator| { [INFO] [stdout] ... | [INFO] [stdout] 575 | | }) > safety_oracle_threshold [INFO] [stdout] 576 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:486:29 [INFO] [stdout] | [INFO] [stdout] 486 | .map(|message| (message.sender().clone(), message.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:486:55 [INFO] [stdout] | [INFO] [stdout] 486 | .map(|message| (message.sender().clone(), message.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:492:49 [INFO] [stdout] | [INFO] [stdout] 492 | .filter(|&message| block.is_member(&Block::from(message))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:503:78 [INFO] [stdout] | [INFO] [stdout] 503 | ... .filter(|(_validator, message)| block.is_member(&Block::from(message))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:553:67 [INFO] [stdout] | [INFO] [stdout] 546 | let mut rnew = r.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 547 | rnew.insert(i); [INFO] [stdout] 548 | let pnew: HashSet<&D::ValidatorName> = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 549 | p.intersection(&neighbours[i]).cloned().collect(); [INFO] [stdout] 550 | let xnew: HashSet<&D::ValidatorName> = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | bron_kerbosch::(rnew, pnew, xnew, mx_clqs, neighbours.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:623:29 [INFO] [stdout] | [INFO] [stdout] 623 | .map(|message| (Block::from(message), message.sender().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:623:51 [INFO] [stdout] | [INFO] [stdout] 623 | .map(|message| (Block::from(message), message.sender().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:704:48 [INFO] [stdout] | [INFO] [stdout] 704 | .map(|validator| validators.insert(validator.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:737:26 [INFO] [stdout] | [INFO] [stdout] 734 | length if length == 1 => blocks.iter().next().cloned().and_then(|block| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | .map(|children| (Some(block), >::ZERO, children.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:737:38 [INFO] [stdout] | [INFO] [stdout] 734 | length if length == 1 => blocks.iter().next().cloned().and_then(|block| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | .map(|children| (Some(block), >::ZERO, children.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:737:73 [INFO] [stdout] | [INFO] [stdout] 734 | length if length == 1 => blocks.iter().next().cloned().and_then(|block| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | .map(|children| (Some(block), >::ZERO, children.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:742:66 [INFO] [stdout] | [INFO] [stdout] 742 | best.and_then(|best| visited.get(&block).map(|children| (best, children))); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:799:9 [INFO] [stdout] | [INFO] [stdout] 795 | let (visited, genesis, latest_blocks) = Self::parse_blockchains(latest_messages); [INFO] [stdout] | ------- ------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 796 | [INFO] [stdout] 797 | let mut b_in_lms_validators = HashMap::, HashSet>::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 798 | [INFO] [stdout] 799 | / Block::pick_heaviest( [INFO] [stdout] 800 | | &genesis, [INFO] [stdout] 801 | | &visited, [INFO] [stdout] 802 | | validators_weights, [INFO] [stdout] ... | [INFO] [stdout] 805 | | ) [INFO] [stdout] 806 | | .and_then(|(opt_block, ..)| opt_block) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/justification.rs:362:61 [INFO] [stdout] | [INFO] [stdout] 362 | ... .map(|messages| messages.insert(new_message.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/justification.rs:414:57 [INFO] [stdout] | [INFO] [stdout] 414 | .for_each(|message| queue.push_back(message.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new(sender: E::ValidatorName, justification: Justification, estimate: E) -> Self { [INFO] [stdout] | ------------------------ ------------------------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let proto = ProtoMessage { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Message(Arc::new(proto), id) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:239:51 [INFO] [stdout] | [INFO] [stdout] 239 | ... .map(|mut v| v.insert(lhs_prime.clone())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/util/hash.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / fixed_hash::construct_fixed_hash!( [INFO] [stdout] 22 | | pub struct Hash(64); [INFO] [stdout] 23 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fixed_hash::construct_fixed_hash` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:198:33 [INFO] [stdout] | [INFO] [stdout] 190 | default_state: Self, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | validators_weights: Option>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | state_fault_weight: Option, [INFO] [stdout] 193 | latest_messages: Option>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | thr: Option, [INFO] [stdout] 195 | equivocators: Option>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | validators_weights: validators_weights.unwrap_or(default_state.validators_weights), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:200:30 [INFO] [stdout] | [INFO] [stdout] 190 | default_state: Self, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | validators_weights: Option>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | state_fault_weight: Option, [INFO] [stdout] 193 | latest_messages: Option>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | thr: Option, [INFO] [stdout] 195 | equivocators: Option>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | latest_messages: latest_messages.unwrap_or(default_state.latest_messages), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 190 | default_state: Self, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | validators_weights: Option>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | state_fault_weight: Option, [INFO] [stdout] 193 | latest_messages: Option>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | thr: Option, [INFO] [stdout] 195 | equivocators: Option>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | equivocators: equivocators.unwrap_or(default_state.equivocators), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 312 | pub fn new(weights: HashMap) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | Weights(Arc::new(RwLock::new(weights))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 327 | pub fn insert(&mut self, validator: V, weight: U) -> Result>> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | / self.write() [INFO] [stdout] 329 | | .map_err(Error::WriteLockError) [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:330:18 [INFO] [stdout] | [INFO] [stdout] 327 | pub fn insert(&mut self, validator: V, weight: U) -> Result>> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | .map(|mut hash_map| { [INFO] [stdout] | __________________^ [INFO] [stdout] 331 | | hash_map.insert(validator, weight); [INFO] [stdout] 332 | | true [INFO] [stdout] 333 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:362:28 [INFO] [stdout] | [INFO] [stdout] 358 | .and_then(|hash_map| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | .ok_or(Error::NotFound) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 35 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `core_cbc_casper` (lib) due to 36 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "11e4812f601852b2a03f93650d6bcfdfcbc3d2a6ebf7851bc2f07b861a4ce99c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11e4812f601852b2a03f93650d6bcfdfcbc3d2a6ebf7851bc2f07b861a4ce99c", kill_on_drop: false }` [INFO] [stdout] 11e4812f601852b2a03f93650d6bcfdfcbc3d2a6ebf7851bc2f07b861a4ce99c