[INFO] fetching crate cordwood 0.0.4... [INFO] checking cordwood-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cordwood 0.0.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cordwood 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cordwood 0.0.4 [INFO] finished tweaking crates.io crate cordwood 0.0.4 [INFO] tweaked toml for crates.io crate cordwood 0.0.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate cordwood 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b4cf170047da1cb962002d02aa380bbd63a1a540153ae0a622f1837933927bd [INFO] running `Command { std: "docker" "start" "-a" "4b4cf170047da1cb962002d02aa380bbd63a1a540153ae0a622f1837933927bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b4cf170047da1cb962002d02aa380bbd63a1a540153ae0a622f1837933927bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b4cf170047da1cb962002d02aa380bbd63a1a540153ae0a622f1837933927bd", kill_on_drop: false }` [INFO] [stdout] 4b4cf170047da1cb962002d02aa380bbd63a1a540153ae0a622f1837933927bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e63a758f09a54d8c29e3f9512e1a1c1821a827fea9c00a6198f7ad39121fa3bc [INFO] running `Command { std: "docker" "start" "-a" "e63a758f09a54d8c29e3f9512e1a1c1821a827fea9c00a6198f7ad39121fa3bc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling libaio-futures v0.2.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking rlp v0.5.2 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking impl-rlp v0.3.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking hash-db v0.15.2 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking hash256-std-hasher v0.15.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking triehash v0.8.4 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking keccak-hasher v0.15.3 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking lru v0.12.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking shale v0.1.9 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking fixed-hash v0.8.0 [INFO] [stderr] Checking primitive-types v0.12.2 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking scan_fmt v0.2.6 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling typed-builder-macro v0.18.1 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking typed-builder v0.18.1 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking growth-ring v0.3.1 [INFO] [stderr] Checking cordwood v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/account.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 74 | let mut stream = rlp::RlpStream::new_list(4); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | stream.out().into() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:316:18 [INFO] [stdout] | [INFO] [stdout] 316 | Ok(match self.merkle.get(sub_key, root) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 363 | let (db_fd, reset) = file::open_dir(db_path, cfg.truncate).map_err(DBError::System)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | [INFO] [stdout] 365 | let merkle_fd = file::touch_dir("merkle", db_fd.as_fd()).map_err(DBError::System)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let merkle_meta_fd = file::touch_dir("meta", merkle_fd.as_fd()).map_err(DBError::System)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | let merkle_payload_fd = file::touch_dir("compact", merkle_fd.as_fd()).map_err(DBError::System)?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 368 | [INFO] [stdout] 369 | let blob_fd = file::touch_dir("blob", db_fd.as_fd()).map_err(DBError::System)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | let blob_meta_fd = file::touch_dir("meta", blob_fd.as_fd()).map_err(DBError::System)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | let blob_payload_fd = file::touch_dir("compact", blob_fd.as_fd()).map_err(DBError::System)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | [INFO] [stdout] 373 | let file0 = crate::file::File::new(0, SPACE_RESERVED, merkle_meta_fd.as_fd()).map_err(DBError::System)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let cached = Universe { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | let (sender, inbound) = tokio::sync::mpsc::channel(cfg.buffer.max_buffered); [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | let disk_requester = crate::storage::DiskBufferRequester::new(sender); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | let buffer = cfg.buffer.clone(); [INFO] [stdout] 467 | let disk_thread = Some(std::thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 477 | let staging = Universe { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | let (mut db_header_ref, merkle_payload_header_ref, blob_payload_header_ref) = unsafe { [INFO] [stdout] | ------------- ------------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | let merkle_space = shale::compact::CompactSpace::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | let blob_space = shale::compact::CompactSpace::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | let mut latest = DBRev { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 578 | | inner: Mutex::new(DBInner { [INFO] [stdout] 579 | | latest, [INFO] [stdout] 580 | | disk_thread, [INFO] [stdout] ... | [INFO] [stdout] 588 | | rev_cfg: cfg.rev.clone(), [INFO] [stdout] 589 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:736:14 [INFO] [stdout] | [INFO] [stdout] 653 | let mut inner = self.inner.lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 700 | let (db_header_ref, merkle_payload_header_ref, blob_payload_header_ref) = unsafe { [INFO] [stdout] | ------------- ------------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 716 | let merkle_space = shale::compact::CompactSpace::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 726 | let blob_space = shale::compact::CompactSpace::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | Some(Revision { [INFO] [stdout] | ______________^ [INFO] [stdout] 737 | | _m: inner, [INFO] [stdout] 738 | | rev: DBRev { [INFO] [stdout] 739 | | header: db_header_ref, [INFO] [stdout] ... | [INFO] [stdout] 742 | | }, [INFO] [stdout] 743 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 45 | let fd = match Self::open_file(rootfd, &fname, false) { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Ok(fd) => fd, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let fd = Self::create_file(rootfd, &fname); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(File { fd, fid }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 179 | let mut stream = rlp::RlpStream::new_list(17); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | stream.out().into() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 233 | let mut r = store.get_item(self.1).unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let mut stream = rlp::RlpStream::new_list(2); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | stream.out().into() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:1514:12 [INFO] [stdout] | [INFO] [stdout] 1460 | pub fn get>(&self, key: K, root: ObjPtr) -> Result, MerkleError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1468 | let mut u_ref = self.get_node(root)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1514 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:1557:36 [INFO] [stdout] | [INFO] [stdout] 1557 | .map(|(ptr, nib)| (self.merkle.get_node(*ptr).unwrap(), *nib)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:102:28 [INFO] [stdout] | [INFO] [stdout] 86 | let mut old = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let mut new = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | (space_id, Ash { old, new }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:301:14 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn from_ash(prev: Rc, writes: &[SpaceWrite]) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let delta = StoreDelta::new(prev.as_ref(), writes); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | let prev = RefCell::new(prev); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | Self(Rc::new(StoreRev { prev, delta })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:306:14 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn from_delta(prev: Rc, delta: StoreDelta) -> Self { [INFO] [stdout] | ----------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | let prev = RefCell::new(prev); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Self(Rc::new(StoreRev { prev, delta })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:375:21 [INFO] [stdout] | [INFO] [stdout] 372 | pub fn new(prev: Rc) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | deltas: Rc::new(RefCell::new(StoreRevMutDelta { [INFO] [stdout] | _____________________^ [INFO] [stdout] 376 | | pages: HashMap::new(), [INFO] [stdout] 377 | | plain: Ash::new(), [INFO] [stdout] 378 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:410:10 [INFO] [stdout] | [INFO] [stdout] 398 | let mut pages = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | let deltas = std::mem::replace( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | (StoreDelta(pages), deltas.plain) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 575 | pub fn new(cfg: StoreConfig) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | let space_id = cfg.space_id; [INFO] [stdout] 577 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 578 | | inner: Rc::new(RefCell::new(CachedSpaceInner { [INFO] [stdout] 579 | | cached_pages: lru::LruCache::new(NonZeroUsize::new(cfg.ncached_pages).expect("non-zero cache size")), [INFO] [stdout] 580 | | pinned_pages: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 584 | | space_id, [INFO] [stdout] 585 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:598:14 [INFO] [stdout] | [INFO] [stdout] 590 | let mut pages = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | Some(StoreDelta(pages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:614:12 [INFO] [stdout] | [INFO] [stdout] 610 | let file = self.files.get_file(poff >> file_nbit)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 614 | Ok(Box::new(page)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:746:12 [INFO] [stdout] | [INFO] [stdout] 744 | let mut files = self.files.lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 745 | let file_size = 1 << self.file_nbit; [INFO] [stdout] 746 | Ok(match files.get(&fid) { [INFO] [stdout] | ____________^ [INFO] [stdout] 747 | | Some(f) => f.clone(), [INFO] [stdout] 748 | | None => { [INFO] [stdout] 749 | | files.put( [INFO] [stdout] ... | [INFO] [stdout] 754 | | } [INFO] [stdout] 755 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:856:14 [INFO] [stdout] | [INFO] [stdout] 847 | pub fn new(inbound: mpsc::Receiver, cfg: &DiskBufferConfig, wal: &WALConfig) -> Option { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 848 | const INIT: Option> = None; [INFO] [stdout] 849 | let aiomgr = AIOBuilder::default() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 856 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 857 | | pending: HashMap::new(), [INFO] [stdout] 858 | | cfg: cfg.clone(), [INFO] [stdout] 859 | | inbound, [INFO] [stdout] ... | [INFO] [stdout] 868 | | wal_cfg: wal.clone(), [INFO] [stdout] 869 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:989:29 [INFO] [stdout] | [INFO] [stdout] 989 | .map(|ring| ring.map_err(|_| "WAL Error while writing").unwrap().1) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:1111:38 [INFO] [stdout] | [INFO] [stdout] 1111 | .map(|(_, task)| task.take().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:1145:9 [INFO] [stdout] | [INFO] [stdout] 1140 | let (resp_tx, resp_rx) = oneshot::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1145 | resp_rx.blocking_recv().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:1149:9 [INFO] [stdout] | [INFO] [stdout] 1148 | pub fn write(&self, page_batch: Vec, write_batch: AshRecord) { [INFO] [stdout] | ---------------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1149 | / self.sender [INFO] [stdout] 1150 | | .blocking_send(BufferCmd::WriteBatch(page_batch, write_batch)) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:1160:9 [INFO] [stdout] | [INFO] [stdout] 1159 | pub fn init_wal(&self, waldir: &str, rootfd: OwnedFd) { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1160 | / self.sender [INFO] [stdout] 1161 | | .blocking_send(BufferCmd::InitWAL(rootfd, waldir.to_string())) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:1172:9 [INFO] [stdout] | [INFO] [stdout] 1167 | let (resp_tx, resp_rx) = oneshot::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1172 | resp_rx.blocking_recv().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:1178:9 [INFO] [stdout] | [INFO] [stdout] 1176 | let mut inner = space.inner.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1177 | inner.disk_buffer = self.clone(); [INFO] [stdout] 1178 | / self.sender [INFO] [stdout] 1179 | | .blocking_send(BufferCmd::RegCachedSpace(space.id(), inner.files.clone())) [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cordwood` (lib) due to 27 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e63a758f09a54d8c29e3f9512e1a1c1821a827fea9c00a6198f7ad39121fa3bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e63a758f09a54d8c29e3f9512e1a1c1821a827fea9c00a6198f7ad39121fa3bc", kill_on_drop: false }` [INFO] [stdout] e63a758f09a54d8c29e3f9512e1a1c1821a827fea9c00a6198f7ad39121fa3bc