[INFO] fetching crate cooptex 0.2.1... [INFO] checking cooptex-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cooptex 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cooptex 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cooptex 0.2.1 [INFO] finished tweaking crates.io crate cooptex 0.2.1 [INFO] tweaked toml for crates.io crate cooptex 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cooptex 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bbe4a41296b957d08a9fad1ae4361ecce2b26a5be1d8e3184366a0fad4965cb3 [INFO] running `Command { std: "docker" "start" "-a" "bbe4a41296b957d08a9fad1ae4361ecce2b26a5be1d8e3184366a0fad4965cb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bbe4a41296b957d08a9fad1ae4361ecce2b26a5be1d8e3184366a0fad4965cb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbe4a41296b957d08a9fad1ae4361ecce2b26a5be1d8e3184366a0fad4965cb3", kill_on_drop: false }` [INFO] [stdout] bbe4a41296b957d08a9fad1ae4361ecce2b26a5be1d8e3184366a0fad4965cb3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8825d505e08865d3e7a45bacf966385eb95489e0b48b6b9e9809179c2a97ff46 [INFO] running `Command { std: "docker" "start" "-a" "8825d505e08865d3e7a45bacf966385eb95489e0b48b6b9e9809179c2a97ff46", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling rustversion v1.0.5 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling frunk_core v0.4.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling cc v1.0.71 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling generator v0.7.0 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Compiling frunk_proc_macro_helpers v0.1.0 [INFO] [stderr] Compiling frunk_proc_macros_impl v0.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Compiling frunk_derives v0.4.0 [INFO] [stderr] Checking frunk_proc_macros v0.1.0 [INFO] [stderr] Checking frunk v0.4.0 [INFO] [stderr] Checking cooptex v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(item: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | CoopMutex { [INFO] [stdout] 91 | native: Mutex::new(item), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:33 [INFO] [stdout] | [INFO] [stdout] 106 | THIS_SCOPE.with(|scope| scope.borrow().lock(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:26 [INFO] [stdout] | [INFO] [stdout] 201 | native: StdMutexGuard<'m, T>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let mut held_waiter = mutex.held_waiter.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | _lock_count: Arc::clone(&self.lock_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:320:37 [INFO] [stdout] | [INFO] [stdout] 320 | THIS_SCOPE.with(|s| s.borrow_mut().update_id_for_fairness()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:52:29 [INFO] [stdout] | [INFO] [stdout] 51 | fn lock(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | MaybeLocked::Locked(match self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 53 | | MaybeLocked::Locked(l) => l, [INFO] [stdout] 54 | | MaybeLocked::NotLocked(m) => m.lock(), [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:86:31 [INFO] [stdout] | [INFO] [stdout] 86 | .map(|(i, m)| (i, m.lock())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 106 | fn lock_in_order(self) -> Self::Output [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | self.as_maybe().lock_in_order(Bound::None).as_locked() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 130 | fn as_maybe(self) -> Self::Maybe { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let (h, tail) = self.pop(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | HCons { [INFO] [stdout] 133 | head: MaybeLocked::NotLocked(h), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 130 | fn as_maybe(self) -> Self::Maybe { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let (h, tail) = self.pop(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | tail: tail.as_maybe(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:175:19 [INFO] [stdout] | [INFO] [stdout] 164 | fn lock_in_order(self, bound: Bound) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | let (h, tail) = self.pop(); [INFO] [stdout] | - ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | [INFO] [stdout] 167 | let (before, lock) = if h.lock_before(&bound) { [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | tail: before.lock_in_order(bound), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:218:19 [INFO] [stdout] | [INFO] [stdout] 215 | fn unwrap(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let (h, tail) = self.pop(); [INFO] [stdout] | - ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | HCons { [INFO] [stdout] 218 | head: h.unwrap(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 215 | fn unwrap(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let (h, tail) = self.pop(); [INFO] [stdout] | - ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | tail: tail.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock_in_order.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 230 | fn unwrap(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | self.into_iter().map(|r| r.unwrap()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cooptex` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8825d505e08865d3e7a45bacf966385eb95489e0b48b6b9e9809179c2a97ff46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8825d505e08865d3e7a45bacf966385eb95489e0b48b6b9e9809179c2a97ff46", kill_on_drop: false }` [INFO] [stdout] 8825d505e08865d3e7a45bacf966385eb95489e0b48b6b9e9809179c2a97ff46