[INFO] fetching crate cooklang-fs 0.13.0... [INFO] checking cooklang-fs-0.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cooklang-fs 0.13.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cooklang-fs 0.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cooklang-fs 0.13.0 [INFO] finished tweaking crates.io crate cooklang-fs 0.13.0 [INFO] tweaked toml for crates.io crate cooklang-fs 0.13.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 912cb1ef87e63ad654c6ef6e089bc7d63e2ab71f42d8e28b8eb71cdb1aba63c0 [INFO] running `Command { std: "docker" "start" "-a" "912cb1ef87e63ad654c6ef6e089bc7d63e2ab71f42d8e28b8eb71cdb1aba63c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "912cb1ef87e63ad654c6ef6e089bc7d63e2ab71f42d8e28b8eb71cdb1aba63c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "912cb1ef87e63ad654c6ef6e089bc7d63e2ab71f42d8e28b8eb71cdb1aba63c0", kill_on_drop: false }` [INFO] [stdout] 912cb1ef87e63ad654c6ef6e089bc7d63e2ab71f42d8e28b8eb71cdb1aba63c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2839c3986c2a51bd4854089ebcd60afcc02255dd21a3200e8259ccc9fdaa007c [INFO] running `Command { std: "docker" "start" "-a" "2839c3986c2a51bd4854089ebcd60afcc02255dd21a3200e8259ccc9fdaa007c", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking emojis v0.6.3 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking codesnake v0.2.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking finl_unicode v1.2.0 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking cooklang v0.13.3 [INFO] [stderr] Checking cooklang-fs v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:8 [INFO] [stdout] | [INFO] [stdout] 368 | base_path: impl AsRef, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let grouped = group_images(walker); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | Ok(grouped.filter_map(|e| match e { [INFO] [stdout] | ________^ [INFO] [stdout] 378 | | Entry::Dir(_) => None, [INFO] [stdout] 379 | | Entry::Recipe(r) => Some(r), [INFO] [stdout] 380 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:397:8 [INFO] [stdout] | [INFO] [stdout] 385 | path: impl AsRef, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 397 | Ok(group_images(Walker::new(path, 0).flatten())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:440:15 [INFO] [stdout] | [INFO] [stdout] 400 | fn group_images(walker: impl Iterator) -> impl Iterator { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | iter: walker.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:687:50 [INFO] [stdout] | [INFO] [stdout] 687 | let Some(dir) = path.parent().and_then(|dir| dir.read_dir_utf8().ok()) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:697:21 [INFO] [stdout] | [INFO] [stdout] 697 | .filter(|e| e.file_type().map(|t| t.is_file()).unwrap_or(false)) // skip non-file [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:698:49 [INFO] [stdout] | [INFO] [stdout] 698 | .filter_map(|e| Image::new(recipe_name, DirEntry::new(e.path()).ok()?)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cooklang-fs` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:8 [INFO] [stdout] | [INFO] [stdout] 368 | base_path: impl AsRef, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let grouped = group_images(walker); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | Ok(grouped.filter_map(|e| match e { [INFO] [stdout] | ________^ [INFO] [stdout] 378 | | Entry::Dir(_) => None, [INFO] [stdout] 379 | | Entry::Recipe(r) => Some(r), [INFO] [stdout] 380 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:397:8 [INFO] [stdout] | [INFO] [stdout] 385 | path: impl AsRef, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 397 | Ok(group_images(Walker::new(path, 0).flatten())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:440:15 [INFO] [stdout] | [INFO] [stdout] 400 | fn group_images(walker: impl Iterator) -> impl Iterator { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | iter: walker.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:687:50 [INFO] [stdout] | [INFO] [stdout] 687 | let Some(dir) = path.parent().and_then(|dir| dir.read_dir_utf8().ok()) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:697:21 [INFO] [stdout] | [INFO] [stdout] 697 | .filter(|e| e.file_type().map(|t| t.is_file()).unwrap_or(false)) // skip non-file [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:698:49 [INFO] [stdout] | [INFO] [stdout] 698 | .filter_map(|e| Image::new(recipe_name, DirEntry::new(e.path()).ok()?)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cooklang-fs` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "2839c3986c2a51bd4854089ebcd60afcc02255dd21a3200e8259ccc9fdaa007c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2839c3986c2a51bd4854089ebcd60afcc02255dd21a3200e8259ccc9fdaa007c", kill_on_drop: false }` [INFO] [stdout] 2839c3986c2a51bd4854089ebcd60afcc02255dd21a3200e8259ccc9fdaa007c