[INFO] fetching crate cookie_store 0.21.0... [INFO] checking cookie_store-0.21.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cookie_store 0.21.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cookie_store 0.21.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cookie_store 0.21.0 [INFO] finished tweaking crates.io crate cookie_store 0.21.0 [INFO] tweaked toml for crates.io crate cookie_store 0.21.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding idna v0.3.0 (latest: v1.0.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3607b847b4b2a71d1351511a13622e226a8a5b3d0f23723a7cb25b7878ab1dca [INFO] running `Command { std: "docker" "start" "-a" "3607b847b4b2a71d1351511a13622e226a8a5b3d0f23723a7cb25b7878ab1dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3607b847b4b2a71d1351511a13622e226a8a5b3d0f23723a7cb25b7878ab1dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3607b847b4b2a71d1351511a13622e226a8a5b3d0f23723a7cb25b7878ab1dca", kill_on_drop: false }` [INFO] [stdout] 3607b847b4b2a71d1351511a13622e226a8a5b3d0f23723a7cb25b7878ab1dca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 04440c243e61cc9683a4b84bca04a941fdde602c228873aac690ef5aa25f7215 [INFO] running `Command { std: "docker" "start" "-a" "04440c243e61cc9683a4b84bca04a941fdde602c228873aac690ef5aa25f7215", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking publicsuffix v2.2.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking cookie_store v0.21.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `into_url` is never used [INFO] [stdout] --> src/utils.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait IntoUrl { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 6 | fn into_url(self) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:450:13 [INFO] [stdout] | [INFO] [stdout] 449 | let cookies = reader.lines().map(|line_result| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | / line_result [INFO] [stdout] 451 | | .map_err(Into::into) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:452:34 [INFO] [stdout] | [INFO] [stdout] 452 | .and_then(|line| cookie_from_str(&line).map_err(crate::Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:511:32 [INFO] [stdout] | [INFO] [stdout] 507 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | serializer.collect_seq(self.iter_unexpired().filter(|c| c.is_persistent())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:528:52 [INFO] [stdout] | [INFO] [stdout] 528 | CookieStore::from_cookies(iter::from_fn(|| seq.next_element().transpose()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cookie_store` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `into_url` is never used [INFO] [stdout] --> src/utils.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait IntoUrl { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 6 | fn into_url(self) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:450:13 [INFO] [stdout] | [INFO] [stdout] 449 | let cookies = reader.lines().map(|line_result| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | / line_result [INFO] [stdout] 451 | | .map_err(Into::into) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:452:34 [INFO] [stdout] | [INFO] [stdout] 452 | .and_then(|line| cookie_from_str(&line).map_err(crate::Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:511:32 [INFO] [stdout] | [INFO] [stdout] 507 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | serializer.collect_seq(self.iter_unexpired().filter(|c| c.is_persistent())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cookie_store.rs:528:52 [INFO] [stdout] | [INFO] [stdout] 528 | CookieStore::from_cookies(iter::from_fn(|| seq.next_element().transpose()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cookie_store` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "04440c243e61cc9683a4b84bca04a941fdde602c228873aac690ef5aa25f7215", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04440c243e61cc9683a4b84bca04a941fdde602c228873aac690ef5aa25f7215", kill_on_drop: false }` [INFO] [stdout] 04440c243e61cc9683a4b84bca04a941fdde602c228873aac690ef5aa25f7215