[INFO] fetching crate conv 0.3.3... [INFO] checking conv-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate conv 0.3.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate conv 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate conv 0.3.3 [INFO] finished tweaking crates.io crate conv 0.3.3 [INFO] tweaked toml for crates.io crate conv 0.3.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding quickcheck v0.2.24 (latest: v1.0.3) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a03ac92dc32348363db18628f22cdb4ff8308a43e5f9a37f0382ec17b8940ed [INFO] running `Command { std: "docker" "start" "-a" "1a03ac92dc32348363db18628f22cdb4ff8308a43e5f9a37f0382ec17b8940ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a03ac92dc32348363db18628f22cdb4ff8308a43e5f9a37f0382ec17b8940ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a03ac92dc32348363db18628f22cdb4ff8308a43e5f9a37f0382ec17b8940ed", kill_on_drop: false }` [INFO] [stdout] 1a03ac92dc32348363db18628f22cdb4ff8308a43e5f9a37f0382ec17b8940ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86254a066b1a6cff4191dc129a5ec3566f4d67a0cc18d8079294c983d56c0d2e [INFO] running `Command { std: "docker" "start" "-a" "86254a066b1a6cff4191dc129a5ec3566f4d67a0cc18d8079294c983d56c0d2e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking conv v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/errors.rs:524:13 [INFO] [stdout] | [INFO] [stdout] 524 | Err(no_error) => match no_error {}, [INFO] [stdout] | ^^^^^^^^^^^^^ matches no values because `NoError` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(e: $fname<$t>) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | $name::$fname(e.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | / custom_derive!{ [INFO] [stdout] 228 | | /** [INFO] [stdout] 229 | | A general error enumeration that subsumes all other conversion errors. [INFO] [stdout] ... | [INFO] [stdout] 255 | | } [INFO] [stdout] 256 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `FromName` which comes from the expansion of the macro `custom_derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(e: $fname<$t>) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | $name::$fname(e.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | / custom_derive!{ [INFO] [stdout] 228 | | /** [INFO] [stdout] 229 | | A general error enumeration that subsumes all other conversion errors. [INFO] [stdout] ... | [INFO] [stdout] 255 | | } [INFO] [stdout] 256 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `FromName` which comes from the expansion of the macro `custom_derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(e: $fname<$t>) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | $name::$fname(e.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | / custom_derive!{ [INFO] [stdout] 228 | | /** [INFO] [stdout] 229 | | A general error enumeration that subsumes all other conversion errors. [INFO] [stdout] ... | [INFO] [stdout] 255 | | } [INFO] [stdout] 256 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `FromName` which comes from the expansion of the macro `custom_derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(e: $fname<$t>) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | $name::$fname(e.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 367 | / custom_derive! { [INFO] [stdout] 368 | | /** [INFO] [stdout] 369 | | Indicates that a conversion from a floating point type failed. [INFO] [stdout] 370 | | */ [INFO] [stdout] ... | [INFO] [stdout] 392 | | } [INFO] [stdout] 393 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `FromName` which comes from the expansion of the macro `custom_derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(e: $fname<$t>) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | $name::$fname(e.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 367 | / custom_derive! { [INFO] [stdout] 368 | | /** [INFO] [stdout] 369 | | Indicates that a conversion from a floating point type failed. [INFO] [stdout] 370 | | */ [INFO] [stdout] ... | [INFO] [stdout] 392 | | } [INFO] [stdout] 393 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `FromName` which comes from the expansion of the macro `custom_derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(e: $fname<$t>) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | $name::$fname(e.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | / custom_derive! { [INFO] [stdout] 396 | | /** [INFO] [stdout] 397 | | Indicates that a conversion failed due to a range error. [INFO] [stdout] 398 | | */ [INFO] [stdout] ... | [INFO] [stdout] 415 | | } [INFO] [stdout] 416 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `FromName` which comes from the expansion of the macro `custom_derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(e: $fname<$t>) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | $name::$fname(e.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | / custom_derive! { [INFO] [stdout] 396 | | /** [INFO] [stdout] 397 | | Indicates that a conversion failed due to a range error. [INFO] [stdout] 398 | | */ [INFO] [stdout] ... | [INFO] [stdout] 415 | | } [INFO] [stdout] 416 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `FromName` which comes from the expansion of the macro `custom_derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:574:15 [INFO] [stdout] | [INFO] [stdout] 572 | fn unwrap_or_inf(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | use self::RangeErrorKind::*; [INFO] [stdout] 574 | match self.map_err(Into::into) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:600:15 [INFO] [stdout] | [INFO] [stdout] 598 | fn unwrap_or_saturate(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 599 | use self::RangeErrorKind::*; [INFO] [stdout] 600 | match self.map_err(Into::into) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `conv` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "86254a066b1a6cff4191dc129a5ec3566f4d67a0cc18d8079294c983d56c0d2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86254a066b1a6cff4191dc129a5ec3566f4d67a0cc18d8079294c983d56c0d2e", kill_on_drop: false }` [INFO] [stdout] 86254a066b1a6cff4191dc129a5ec3566f4d67a0cc18d8079294c983d56c0d2e