[INFO] fetching crate containerd-runc-shim 0.1.1... [INFO] checking containerd-runc-shim-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate containerd-runc-shim 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate containerd-runc-shim 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate containerd-runc-shim 0.1.1 [INFO] finished tweaking crates.io crate containerd-runc-shim 0.1.1 [INFO] tweaked toml for crates.io crate containerd-runc-shim 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate containerd-runc-shim 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e145b69076065588332067875b01543b0bb1748e80c1b7f3c188ef15e9fb6a1c [INFO] running `Command { std: "docker" "start" "-a" "e145b69076065588332067875b01543b0bb1748e80c1b7f3c188ef15e9fb6a1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e145b69076065588332067875b01543b0bb1748e80c1b7f3c188ef15e9fb6a1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e145b69076065588332067875b01543b0bb1748e80c1b7f3c188ef15e9fb6a1c", kill_on_drop: false }` [INFO] [stdout] e145b69076065588332067875b01543b0bb1748e80c1b7f3c188ef15e9fb6a1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] abb680a937c512599f2eaa9fdf681e67159c37b7886f6ee754150ef4155e37c4 [INFO] running `Command { std: "docker" "start" "-a" "abb680a937c512599f2eaa9fdf681e67159c37b7886f6ee754150ef4155e37c4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling protobuf v2.27.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling crossbeam-epoch v0.9.7 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling crossbeam-queue v0.3.4 [INFO] [stderr] Compiling signal-hook v0.3.13 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling containerd-shim-protos v0.2.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking go-flag v0.1.0 [INFO] [stderr] Checking path-dedot v3.0.14 [INFO] [stderr] Checking path-absolutize v3.0.11 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking nix v0.22.3 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking os_pipe v1.0.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Compiling protobuf-codegen v2.27.1 [INFO] [stderr] Compiling darling_core v0.12.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling protobuf-codegen-pure v2.27.1 [INFO] [stderr] Checking prctl v1.0.0 [INFO] [stderr] Checking cgroups-rs v0.2.9 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling ttrpc v0.6.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking command-fds v0.2.1 [INFO] [stderr] Compiling darling_macro v0.12.4 [INFO] [stderr] Compiling darling v0.12.4 [INFO] [stderr] Compiling derive_builder_core v0.10.2 [INFO] [stderr] Compiling derive_builder_macro v0.10.2 [INFO] [stderr] Checking derive_builder v0.10.2 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking oci-spec v0.5.5 [INFO] [stderr] Checking containerd-shim v0.3.0 [INFO] [stderr] Checking runc v0.2.0 [INFO] [stderr] Checking containerd-runc-shim v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `uri` is never read [INFO] [stdout] --> src/common.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct ProcessIO { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 42 | pub uri: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 136 | bundle: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | opts: &Options, [INFO] [stdout] 138 | spawner: Option>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut gopts = GlobalOpts::default() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | / gopts [INFO] [stdout] 164 | | .build() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/cgroup.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 66 | let h = hierarchies::auto(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / Cgroup::load(h, path) [INFO] [stdout] 71 | | .add_task(CgroupPid::from(pid as u64)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/cgroup.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 235 | let h = hierarchies::auto(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | let cg = Cgroup::new(h, path); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | cg.delete().unwrap() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/io.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 33 | mut from: R, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | mut to: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | wg_opt: Option<&WaitGroup>, [INFO] [stdout] 36 | on_close_opt: Option>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> JoinHandle<()> { [INFO] [stdout] 38 | let wg_opt_clone = wg_opt.cloned(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 40 | | if let Err(e) = std::io::copy(&mut from, &mut to) { [INFO] [stdout] 41 | | debug!("copy io error: {}", e); [INFO] [stdout] 42 | | } [INFO] [stdout] ... | [INFO] [stdout] 48 | | }; [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/runc.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 278 | fn exec(&mut self, req: ExecProcessRequest) -> Result<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | / self.common [INFO] [stdout] 280 | | .exec(req) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/runc.rs:410:21 [INFO] [stdout] | [INFO] [stdout] 408 | pub fn new(id: &str, bundle: &str, runtime: runc::Runc, stdio: Stdio) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 409 | InitProcess { [INFO] [stdout] 410 | common: CommonProcess { [INFO] [stdout] | _____________________^ [INFO] [stdout] 411 | | state: Status::CREATED, [INFO] [stdout] 412 | | id: id.to_string(), [INFO] [stdout] 413 | | stdio, [INFO] [stdout] ... | [INFO] [stdout] 419 | | console: None, [INFO] [stdout] 420 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/runc.rs:652:81 [INFO] [stdout] | [INFO] [stdout] 652 | monitor_subscribe(Topic::Pid).map_err(|e| runc::error::Error::Other(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(ns: &str, exit: Arc, tx: EventSender) -> Self { [INFO] [stdout] | --------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Self { [INFO] [stdout] 56 | factory: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(ns: &str, exit: Arc, tx: EventSender) -> Self { [INFO] [stdout] | --------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | containers: Arc::new(Mutex::new(Default::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(ns: &str, exit: Arc, tx: EventSender) -> Self { [INFO] [stdout] | --------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tx: Arc::new(Mutex::new(tx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 209 | fn kill(&self, _ctx: &TtrpcContext, req: KillRequest) -> TtrpcResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | info!("Kill request for {:?}", req); [INFO] [stdout] 211 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 224 | fn exec(&self, _ctx: &TtrpcContext, req: ExecProcessRequest) -> TtrpcResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 246 | fn resize_pty(&self, _ctx: &TtrpcContext, req: ResizePtyRequest) -> TtrpcResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 263 | fn close_io(&self, _ctx: &TtrpcContext, _req: CloseIORequest) -> TtrpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | // unnecessary close io here since fd was closed automatically after object was destroyed. [INFO] [stdout] 265 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 268 | fn update(&self, _ctx: &TtrpcContext, req: UpdateTaskRequest) -> TtrpcResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | debug!("Update request for {:?}", req); [INFO] [stdout] 270 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:340:12 [INFO] [stdout] | [INFO] [stdout] 329 | fn shutdown(&self, _ctx: &TtrpcContext, _req: ShutdownRequest) -> TtrpcResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | debug!("Shutdown request"); [INFO] [stdout] 331 | let containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | Ok(Empty::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `uri` is never read [INFO] [stdout] --> src/common.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct ProcessIO { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 42 | pub uri: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 136 | bundle: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | opts: &Options, [INFO] [stdout] 138 | spawner: Option>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut gopts = GlobalOpts::default() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | / gopts [INFO] [stdout] 164 | | .build() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/cgroup.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 66 | let h = hierarchies::auto(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / Cgroup::load(h, path) [INFO] [stdout] 71 | | .add_task(CgroupPid::from(pid as u64)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/io.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 33 | mut from: R, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | mut to: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | wg_opt: Option<&WaitGroup>, [INFO] [stdout] 36 | on_close_opt: Option>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> JoinHandle<()> { [INFO] [stdout] 38 | let wg_opt_clone = wg_opt.cloned(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 40 | | if let Err(e) = std::io::copy(&mut from, &mut to) { [INFO] [stdout] 41 | | debug!("copy io error: {}", e); [INFO] [stdout] 42 | | } [INFO] [stdout] ... | [INFO] [stdout] 48 | | }; [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/runc.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 278 | fn exec(&mut self, req: ExecProcessRequest) -> Result<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | / self.common [INFO] [stdout] 280 | | .exec(req) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/runc.rs:410:21 [INFO] [stdout] | [INFO] [stdout] 408 | pub fn new(id: &str, bundle: &str, runtime: runc::Runc, stdio: Stdio) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 409 | InitProcess { [INFO] [stdout] 410 | common: CommonProcess { [INFO] [stdout] | _____________________^ [INFO] [stdout] 411 | | state: Status::CREATED, [INFO] [stdout] 412 | | id: id.to_string(), [INFO] [stdout] 413 | | stdio, [INFO] [stdout] ... | [INFO] [stdout] 419 | | console: None, [INFO] [stdout] 420 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/runc.rs:652:81 [INFO] [stdout] | [INFO] [stdout] 652 | monitor_subscribe(Topic::Pid).map_err(|e| runc::error::Error::Other(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(ns: &str, exit: Arc, tx: EventSender) -> Self { [INFO] [stdout] | --------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Self { [INFO] [stdout] 56 | factory: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(ns: &str, exit: Arc, tx: EventSender) -> Self { [INFO] [stdout] | --------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | containers: Arc::new(Mutex::new(Default::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(ns: &str, exit: Arc, tx: EventSender) -> Self { [INFO] [stdout] | --------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tx: Arc::new(Mutex::new(tx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 209 | fn kill(&self, _ctx: &TtrpcContext, req: KillRequest) -> TtrpcResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | info!("Kill request for {:?}", req); [INFO] [stdout] 211 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 224 | fn exec(&self, _ctx: &TtrpcContext, req: ExecProcessRequest) -> TtrpcResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 246 | fn resize_pty(&self, _ctx: &TtrpcContext, req: ResizePtyRequest) -> TtrpcResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `containerd-runc-shim` (bin "containerd-shim-runc-v2-rs" test) due to 17 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 263 | fn close_io(&self, _ctx: &TtrpcContext, _req: CloseIORequest) -> TtrpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | // unnecessary close io here since fd was closed automatically after object was destroyed. [INFO] [stdout] 265 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 268 | fn update(&self, _ctx: &TtrpcContext, req: UpdateTaskRequest) -> TtrpcResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | debug!("Update request for {:?}", req); [INFO] [stdout] 270 | let mut containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | Ok(Empty::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synchronous/task.rs:340:12 [INFO] [stdout] | [INFO] [stdout] 329 | fn shutdown(&self, _ctx: &TtrpcContext, _req: ShutdownRequest) -> TtrpcResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | debug!("Shutdown request"); [INFO] [stdout] 331 | let containers = self.containers.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | Ok(Empty::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `containerd-runc-shim` (bin "containerd-shim-runc-v2-rs") due to 16 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "abb680a937c512599f2eaa9fdf681e67159c37b7886f6ee754150ef4155e37c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abb680a937c512599f2eaa9fdf681e67159c37b7886f6ee754150ef4155e37c4", kill_on_drop: false }` [INFO] [stdout] abb680a937c512599f2eaa9fdf681e67159c37b7886f6ee754150ef4155e37c4