[INFO] fetching crate consistent_hash_ring 0.8.0... [INFO] checking consistent_hash_ring-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate consistent_hash_ring 0.8.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate consistent_hash_ring 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate consistent_hash_ring 0.8.0 [INFO] finished tweaking crates.io crate consistent_hash_ring 0.8.0 [INFO] tweaked toml for crates.io crate consistent_hash_ring 0.8.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa315daa24d6f682f1a05ce026e856490821fc77b6dec8c0a58b2f9458acde8e [INFO] running `Command { std: "docker" "start" "-a" "aa315daa24d6f682f1a05ce026e856490821fc77b6dec8c0a58b2f9458acde8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa315daa24d6f682f1a05ce026e856490821fc77b6dec8c0a58b2f9458acde8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa315daa24d6f682f1a05ce026e856490821fc77b6dec8c0a58b2f9458acde8e", kill_on_drop: false }` [INFO] [stdout] aa315daa24d6f682f1a05ce026e856490821fc77b6dec8c0a58b2f9458acde8e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c2f9ce13d89affd0c774b85c0c5721e83d0987b102fd824c113502d38596f40 [INFO] running `Command { std: "docker" "start" "-a" "0c2f9ce13d89affd0c774b85c0c5721e83d0987b102fd824c113502d38596f40", kill_on_drop: false }` [INFO] [stderr] Checking consistent_hash_ring v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 195 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | RingBuilder::default().nodes_iter(iter).build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:624:5 [INFO] [stdout] | [INFO] [stdout] 622 | let mut dst = Prependable::new(dst.resident_ranges()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | [INFO] [stdout] 624 | src.resident_ranges().flat_map(move |src_elt| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:624:36 [INFO] [stdout] | [INFO] [stdout] 622 | let mut dst = Prependable::new(dst.resident_ranges()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | [INFO] [stdout] 624 | src.resident_ranges().flat_map(move |src_elt| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 625 | | let mut out = vec![]; [INFO] [stdout] 626 | | let mut s = *src_elt.keys.start(); [INFO] [stdout] ... | [INFO] [stdout] 662 | | out [INFO] [stdout] 663 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 33 | fn set_insert(&mut self, val: T) -> bool { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | self.binary_search(&val) [INFO] [stdout] 35 | .map_err(|i| self.insert(i, val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 76 | fn map_insert(&mut self, key: K, val: V) -> Option { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | / match self.binary_search_by_key(&&key, first) { [INFO] [stdout] 78 | | Err(i) => { [INFO] [stdout] 79 | | self.insert(i, (key, val)); [INFO] [stdout] 80 | | Err(()) [INFO] [stdout] ... | [INFO] [stdout] 86 | | )), [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 195 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | RingBuilder::default().nodes_iter(iter).build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:624:5 [INFO] [stdout] | [INFO] [stdout] 622 | let mut dst = Prependable::new(dst.resident_ranges()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | [INFO] [stdout] 624 | src.resident_ranges().flat_map(move |src_elt| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:624:36 [INFO] [stdout] | [INFO] [stdout] 622 | let mut dst = Prependable::new(dst.resident_ranges()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | [INFO] [stdout] 624 | src.resident_ranges().flat_map(move |src_elt| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 625 | | let mut out = vec![]; [INFO] [stdout] 626 | | let mut s = *src_elt.keys.start(); [INFO] [stdout] ... | [INFO] [stdout] 662 | | out [INFO] [stdout] 663 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 33 | fn set_insert(&mut self, val: T) -> bool { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | self.binary_search(&val) [INFO] [stdout] 35 | .map_err(|i| self.insert(i, val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 76 | fn map_insert(&mut self, key: K, val: V) -> Option { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | / match self.binary_search_by_key(&&key, first) { [INFO] [stdout] 78 | | Err(i) => { [INFO] [stdout] 79 | | self.insert(i, (key, val)); [INFO] [stdout] 80 | | Err(()) [INFO] [stdout] ... | [INFO] [stdout] 86 | | )), [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `consistent_hash_ring` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `consistent_hash_ring` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "0c2f9ce13d89affd0c774b85c0c5721e83d0987b102fd824c113502d38596f40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c2f9ce13d89affd0c774b85c0c5721e83d0987b102fd824c113502d38596f40", kill_on_drop: false }` [INFO] [stdout] 0c2f9ce13d89affd0c774b85c0c5721e83d0987b102fd824c113502d38596f40