[INFO] fetching crate conserve 24.8.0... [INFO] checking conserve-24.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate conserve 24.8.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate conserve 24.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate conserve 24.8.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate conserve 24.8.0 [INFO] tweaked toml for crates.io crate conserve 24.8.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate conserve 24.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5ac086847a444b8a5161d208cef79340b2692cf15f45ebef06f468a2f0610c3 [INFO] running `Command { std: "docker" "start" "-a" "c5ac086847a444b8a5161d208cef79340b2692cf15f45ebef06f468a2f0610c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5ac086847a444b8a5161d208cef79340b2692cf15f45ebef06f468a2f0610c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5ac086847a444b8a5161d208cef79340b2692cf15f45ebef06f468a2f0610c3", kill_on_drop: false }` [INFO] [stdout] c5ac086847a444b8a5161d208cef79340b2692cf15f45ebef06f468a2f0610c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 357df06edeb6133e10e206a812d7ba0f2a3fee2f76148a99501e3563903e7b50 [INFO] running `Command { std: "docker" "start" "-a" "357df06edeb6133e10e206a812d7ba0f2a3fee2f76148a99501e3563903e7b50", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling cc v1.0.94 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling rustls v0.21.11 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking rustix v0.38.32 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Compiling aws-types v1.2.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking aws-smithy-xml v0.60.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling rstest_macros v0.19.0 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking nutmeg v0.1.4 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking fail v0.5.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking cachedir v0.3.1 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking uzers v0.11.3 [INFO] [stderr] Compiling mutants v0.0.3 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Checking unix_mode v0.1.4 [INFO] [stderr] Checking thousands v0.2.0 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Checking readahead-iterator v0.1.1 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling tracing-test-macro v0.2.4 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking assert_fs v1.1.1 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Compiling proptest-derive v0.4.0 [INFO] [stderr] Checking cp_r v0.5.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking dir-assert v0.2.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.19.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking aws-smithy-types v1.1.8 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking aws-smithy-runtime-api v1.4.0 [INFO] [stderr] Checking aws-smithy-eventstream v0.60.4 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-http v0.60.7 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Checking tracing-appender v0.2.3 [INFO] [stderr] Checking tracing-test v0.2.4 [INFO] [stderr] Checking aws-sigv4 v1.2.0 [INFO] [stderr] Checking aws-smithy-runtime v1.3.0 [INFO] [stderr] Checking aws-smithy-checksums v0.60.7 [INFO] [stderr] Checking aws-runtime v1.2.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.20.0 [INFO] [stderr] Checking aws-sdk-sts v1.20.0 [INFO] [stderr] Checking aws-sdk-sso v1.20.0 [INFO] [stderr] Checking aws-sdk-s3 v1.23.0 [INFO] [stderr] Checking aws-config v1.2.0 [INFO] [stderr] Checking conserve v24.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn create(transport: Arc) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let block_dir = Arc::new(BlockDir::create(transport.sub_transport(BLOCK_DIR))?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | block_dir, [INFO] [stdout] 79 | | transport, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn open(transport: Arc) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let block_dir = Arc::new(BlockDir::open(transport.sub_transport(BLOCK_DIR))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | debug!(?header, "Opened archive"); [INFO] [stdout] 100 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | block_dir, [INFO] [stdout] 102 | | transport, [INFO] [stdout] 103 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 127 | exclude: Exclude, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | ) -> Result> { [INFO] [stdout] 130 | self.open_stored_tree(band_selection)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:172:36 [INFO] [stdout] | [INFO] [stdout] 172 | .filter_map(|dir_name| dir_name.parse().ok())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 198 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | ) -> Result> { [INFO] [stdout] 200 | let archive = self.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let task = monitor.start_task("Find referenced blocks".to_string()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(band_ids [INFO] [stdout] | ____________^ [INFO] [stdout] 203 | | .par_iter() [INFO] [stdout] 204 | | .map(move |band_id| Band::open(&archive, *band_id).expect("Failed to open band")) [INFO] [stdout] 205 | | .flat_map_iter(|band| band.index().iter_entries()) [INFO] [stdout] ... | [INFO] [stdout] 210 | | }) [INFO] [stdout] 211 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:204:33 [INFO] [stdout] | [INFO] [stdout] 200 | let archive = self.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | .map(move |band_id| Band::open(&archive, *band_id).expect("Failed to open band")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:205:35 [INFO] [stdout] | [INFO] [stdout] 205 | .flat_map_iter(|band| band.index().iter_entries()) [INFO] [stdout] | ---- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 217 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | ) -> Result> { [INFO] [stdout] 219 | let referenced = self.referenced_blocks(&self.list_band_ids()?, monitor.clone())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 221 | | .block_dir() [INFO] [stdout] 222 | | .blocks(monitor)? [INFO] [stdout] 223 | | .filter(move |h| !referenced.contains(h))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:275:35 [INFO] [stdout] | [INFO] [stdout] 275 | .map(|(_i, block_id)| block_dir.compressed_size(block_id).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backup.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 161 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let basis_index = if let Some(basis_band_id) = archive.last_band_id()? { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let band = Band::create(archive)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let index_builder = band.index_builder(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(BackupWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | band, [INFO] [stdout] 178 | | index_builder, [INFO] [stdout] 179 | | block_dir: archive.block_dir.clone(), [INFO] [stdout] ... | [INFO] [stdout] 182 | | file_combiner: FileCombiner::new(archive.block_dir.clone(), options.max_block_size), [INFO] [stdout] 183 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backup.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | .all(|hash| block_dir.contains(hash, monitor.clone()).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backup.rs:420:18 [INFO] [stdout] | [INFO] [stdout] 417 | fn new(block_dir: Arc, max_block_size: usize) -> FileCombiner { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | buf: BytesMut::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/band.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|sv| band_version_requirement().matches(&sv)) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/band.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 146 | let transport = archive.transport().sub_transport(&band_id.to_string()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Band { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | band_id, [INFO] [stdout] 162 | | head, [INFO] [stdout] 163 | | transport, [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/band.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 182 | let transport = archive.transport().sub_transport(&band_id.to_string()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(Band { [INFO] [stdout] | ____________^ [INFO] [stdout] 211 | | band_id: band_id.to_owned(), [INFO] [stdout] 212 | | head, [INFO] [stdout] 213 | | transport, [INFO] [stdout] 214 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn open(transport: Arc) -> BlockDir { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | cache: RwLock::new(LruCache::new(BLOCK_CACHE_SIZE.try_into().unwrap())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn open(transport: Arc) -> BlockDir { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | exists: RwLock::new(LruCache::new(EXISTENCE_CACHE_SIZE.try_into().unwrap())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn create(transport: Arc) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | transport.create_dir("")?; [INFO] [stdout] 107 | Ok(BlockDir::open(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:166:15 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn contains(&self, hash: &BlockHash, monitor: Arc) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | match self.transport.metadata(&block_relpath(hash)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn read_address(&self, address: &Address, monitor: Arc) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let bytes = self.get_block_content(&address.hash, monitor)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Ok(bytes.slice(start..end)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 270 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | ) -> Result> { [INFO] [stdout] 272 | let transport = self.transport.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | let task = monitor.start_task("List block subdir".to_string()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Ok(subdirs [INFO] [stdout] | ____________^ [INFO] [stdout] 277 | | .into_par_iter() [INFO] [stdout] 278 | | .map(move |subdir_name| { [INFO] [stdout] 279 | | let r = transport.list_dir(&subdir_name); [INFO] [stdout] ... | [INFO] [stdout] 292 | | // TODO: Report errors on bad names? [INFO] [stdout] 293 | | name.parse().ok())) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:315:30 [INFO] [stdout] | [INFO] [stdout] 315 | |hash| match self.get_block_content(&hash, monitor.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress/snappy.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 34 | let mut out = BytesMut::zeroed(max_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(out.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress/snappy.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 56 | let mut out = BytesMut::zeroed(max_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(out.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 47 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let ait = st [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let bit = lt [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(MergeTrees::new(ait, bit) [INFO] [stdout] | ________^ [INFO] [stdout] 59 | | .map(|me| me.to_entry_change()) [INFO] [stdout] 60 | | .filter(move |c: &EntryChange| include_unchanged || !c.change.is_unchanged())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/excludes.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn from_patterns_and_files(exclude: I1, exclude_from: I2) -> Result [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(Exclude { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | globset: gsb.build()?, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc_lock.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 56 | let archive = archive.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(GarbageCollectionLock { archive, band_id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:298:29 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn iter_entries(self) -> IndexEntryIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | // TODO: An option to pass in a subtree? [INFO] [stdout] 298 | IndexEntryIter::new(self.iter_hunks(), Apath::root(), Exclude::nothing()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:298:63 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn iter_entries(self) -> IndexEntryIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | // TODO: An option to pass in a subtree? [INFO] [stdout] 298 | IndexEntryIter::new(self.iter_hunks(), Apath::root(), Exclude::nothing()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:324:24 [INFO] [stdout] | [INFO] [stdout] 303 | let _span = debug_span!("iter_hunks", ?self.transport).entered(); [INFO] [stdout] | ----- ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | transport: Arc::clone(&self.transport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:316:31 [INFO] [stdout] | [INFO] [stdout] 316 | .filter_map(|dir| self.transport.list_dir(&dir).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jsonio.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / transport [INFO] [stdout] 58 | | .as_ref() [INFO] [stdout] 59 | | .write_file(relpath, s.as_bytes()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jsonio.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 71 | let bytes = match transport.as_ref().read_file(path) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(b) => b, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(err) if err.is_not_found() => return Ok(None), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Err(err) => return Err(err.into()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | }; [INFO] [stdout] 76 | / serde_json::from_slice(&bytes) [INFO] [stdout] 77 | | .map(|t| Some(t)) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/live_tree.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 157 | fn new(root_path: &Path, subtree: Apath, exclude: Exclude) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Iter { [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | root_path: root_path.to_path_buf(), [INFO] [stdout] 172 | | entry_deque, [INFO] [stdout] 173 | | dir_deque, [INFO] [stdout] ... | [INFO] [stdout] 176 | | stats: LiveTreeIterStats::default(), [INFO] [stdout] 177 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(ait: AIT, bit: BIT) -> MergeTrees { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | na: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(ait: AIT, bit: BIT) -> MergeTrees { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | nb: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/owner/unix.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 46 | let users_cache = USERS_CACHE.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | match lchown(path, uid_opt, gid_opt) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/restore.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 216 | .map_err(|source| Error::RestoreFileBlock { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | source: Box::new(source), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/show.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 125 | let bw = BufWriter::new(w); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let index_entries: Vec = band.index().iter_entries().collect(); [INFO] [stdout] 127 | serde_json::ser::to_writer_pretty(bw, &index_entries) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:84:22 [INFO] [stdout] | [INFO] [stdout] 81 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | archive: archive.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 81 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | state: State::BeforeBand(band_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn empty(archive: &Archive, monitor: Arc) -> IterStitchedIndexHunks { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | IterStitchedIndexHunks { [INFO] [stdout] 93 | archive: archive.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn empty(archive: &Archive, monitor: Arc) -> IterStitchedIndexHunks { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | state: State::Done, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stored_tree.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 66 | exclude: Exclude, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / IterStitchedIndexHunks::new(&self.archive, self.band.id(), monitor) [INFO] [stdout] 71 | | .iter_entries(subtree, exclude), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_fixtures.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn entry_iter_to_apath_strings(entry_iter: EntryIter) -> Vec [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | / entry_iter [INFO] [stdout] 199 | | .into_iter() [INFO] [stdout] 200 | | .map(|entry| entry.apath().clone().into()) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:193:21 [INFO] [stdout] | [INFO] [stdout] 185 | pub(self) fn io_error(path: &Path, source: io::Error) -> Error { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | source: Some(Box::new(source)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/local.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 73 | let mut file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(out_buf.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 82 | let runtime = tokio::runtime::Builder::new_current_thread() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let config = load_aws_config(&runtime, None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let client = aws_sdk_s3::Client::new(&config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let location_request = client [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let config = load_aws_config(&runtime, region); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let client = aws_sdk_s3::Client::new(&config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Arc::new(S3Transport { [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | bucket, [INFO] [stdout] 125 | | base_path, [INFO] [stdout] 126 | | client: Arc::new(client), [INFO] [stdout] 127 | | runtime: Arc::new(runtime), [INFO] [stdout] 128 | | storage_class: StorageClass::IntelligentTiering, [INFO] [stdout] 129 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:141:22 [INFO] [stdout] | [INFO] [stdout] 136 | let loader = aws_config::defaults(BehaviorVersion::latest()) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | runtime.block_on(loader.load()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 244 | .map_err(|source| Error { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | source: Some(Box::new(source)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 384 | fn s3_error(key: K, source: SdkError) -> Error [INFO] [stdout] | ------ ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | source: Some(source.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn create(transport: Arc) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let block_dir = Arc::new(BlockDir::create(transport.sub_transport(BLOCK_DIR))?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | block_dir, [INFO] [stdout] 79 | | transport, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn open(transport: Arc) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let block_dir = Arc::new(BlockDir::open(transport.sub_transport(BLOCK_DIR))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | debug!(?header, "Opened archive"); [INFO] [stdout] 100 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | block_dir, [INFO] [stdout] 102 | | transport, [INFO] [stdout] 103 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 127 | exclude: Exclude, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | ) -> Result> { [INFO] [stdout] 130 | self.open_stored_tree(band_selection)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:172:36 [INFO] [stdout] | [INFO] [stdout] 172 | .filter_map(|dir_name| dir_name.parse().ok())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 198 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | ) -> Result> { [INFO] [stdout] 200 | let archive = self.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let task = monitor.start_task("Find referenced blocks".to_string()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(band_ids [INFO] [stdout] | ____________^ [INFO] [stdout] 203 | | .par_iter() [INFO] [stdout] 204 | | .map(move |band_id| Band::open(&archive, *band_id).expect("Failed to open band")) [INFO] [stdout] 205 | | .flat_map_iter(|band| band.index().iter_entries()) [INFO] [stdout] ... | [INFO] [stdout] 210 | | }) [INFO] [stdout] 211 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:204:33 [INFO] [stdout] | [INFO] [stdout] 200 | let archive = self.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | .map(move |band_id| Band::open(&archive, *band_id).expect("Failed to open band")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:205:35 [INFO] [stdout] | [INFO] [stdout] 205 | .flat_map_iter(|band| band.index().iter_entries()) [INFO] [stdout] | ---- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 217 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | ) -> Result> { [INFO] [stdout] 219 | let referenced = self.referenced_blocks(&self.list_band_ids()?, monitor.clone())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 221 | | .block_dir() [INFO] [stdout] 222 | | .blocks(monitor)? [INFO] [stdout] 223 | | .filter(move |h| !referenced.contains(h))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:275:35 [INFO] [stdout] | [INFO] [stdout] 275 | .map(|(_i, block_id)| block_dir.compressed_size(block_id).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backup.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 161 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let basis_index = if let Some(basis_band_id) = archive.last_band_id()? { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let band = Band::create(archive)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let index_builder = band.index_builder(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(BackupWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | band, [INFO] [stdout] 178 | | index_builder, [INFO] [stdout] 179 | | block_dir: archive.block_dir.clone(), [INFO] [stdout] ... | [INFO] [stdout] 182 | | file_combiner: FileCombiner::new(archive.block_dir.clone(), options.max_block_size), [INFO] [stdout] 183 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backup.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | .all(|hash| block_dir.contains(hash, monitor.clone()).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backup.rs:420:18 [INFO] [stdout] | [INFO] [stdout] 417 | fn new(block_dir: Arc, max_block_size: usize) -> FileCombiner { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | buf: BytesMut::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/band.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|sv| band_version_requirement().matches(&sv)) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/band.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 146 | let transport = archive.transport().sub_transport(&band_id.to_string()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Band { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | band_id, [INFO] [stdout] 162 | | head, [INFO] [stdout] 163 | | transport, [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/band.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 182 | let transport = archive.transport().sub_transport(&band_id.to_string()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(Band { [INFO] [stdout] | ____________^ [INFO] [stdout] 211 | | band_id: band_id.to_owned(), [INFO] [stdout] 212 | | head, [INFO] [stdout] 213 | | transport, [INFO] [stdout] 214 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn open(transport: Arc) -> BlockDir { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | cache: RwLock::new(LruCache::new(BLOCK_CACHE_SIZE.try_into().unwrap())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn open(transport: Arc) -> BlockDir { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | exists: RwLock::new(LruCache::new(EXISTENCE_CACHE_SIZE.try_into().unwrap())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn create(transport: Arc) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | transport.create_dir("")?; [INFO] [stdout] 107 | Ok(BlockDir::open(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:166:15 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn contains(&self, hash: &BlockHash, monitor: Arc) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | match self.transport.metadata(&block_relpath(hash)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn read_address(&self, address: &Address, monitor: Arc) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let bytes = self.get_block_content(&address.hash, monitor)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Ok(bytes.slice(start..end)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 51 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 270 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | ) -> Result> { [INFO] [stdout] 272 | let transport = self.transport.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | let task = monitor.start_task("List block subdir".to_string()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Ok(subdirs [INFO] [stdout] | ____________^ [INFO] [stdout] 277 | | .into_par_iter() [INFO] [stdout] 278 | | .map(move |subdir_name| { [INFO] [stdout] 279 | | let r = transport.list_dir(&subdir_name); [INFO] [stdout] ... | [INFO] [stdout] 292 | | // TODO: Report errors on bad names? [INFO] [stdout] 293 | | name.parse().ok())) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockdir.rs:315:30 [INFO] [stdout] | [INFO] [stdout] 315 | |hash| match self.get_block_content(&hash, monitor.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress/snappy.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 34 | let mut out = BytesMut::zeroed(max_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(out.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress/snappy.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 56 | let mut out = BytesMut::zeroed(max_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(out.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 47 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let ait = st [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let bit = lt [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(MergeTrees::new(ait, bit) [INFO] [stdout] | ________^ [INFO] [stdout] 59 | | .map(|me| me.to_entry_change()) [INFO] [stdout] 60 | | .filter(move |c: &EntryChange| include_unchanged || !c.change.is_unchanged())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/excludes.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn from_patterns_and_files(exclude: I1, exclude_from: I2) -> Result [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(Exclude { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | globset: gsb.build()?, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc_lock.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 56 | let archive = archive.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(GarbageCollectionLock { archive, band_id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:298:29 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn iter_entries(self) -> IndexEntryIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | // TODO: An option to pass in a subtree? [INFO] [stdout] 298 | IndexEntryIter::new(self.iter_hunks(), Apath::root(), Exclude::nothing()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:298:63 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn iter_entries(self) -> IndexEntryIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | // TODO: An option to pass in a subtree? [INFO] [stdout] 298 | IndexEntryIter::new(self.iter_hunks(), Apath::root(), Exclude::nothing()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:324:24 [INFO] [stdout] | [INFO] [stdout] 303 | let _span = debug_span!("iter_hunks", ?self.transport).entered(); [INFO] [stdout] | ----- ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | transport: Arc::clone(&self.transport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:316:31 [INFO] [stdout] | [INFO] [stdout] 316 | .filter_map(|dir| self.transport.list_dir(&dir).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jsonio.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / transport [INFO] [stdout] 58 | | .as_ref() [INFO] [stdout] 59 | | .write_file(relpath, s.as_bytes()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jsonio.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 71 | let bytes = match transport.as_ref().read_file(path) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(b) => b, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(err) if err.is_not_found() => return Ok(None), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Err(err) => return Err(err.into()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | }; [INFO] [stdout] 76 | / serde_json::from_slice(&bytes) [INFO] [stdout] 77 | | .map(|t| Some(t)) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/live_tree.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 157 | fn new(root_path: &Path, subtree: Apath, exclude: Exclude) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Iter { [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | root_path: root_path.to_path_buf(), [INFO] [stdout] 172 | | entry_deque, [INFO] [stdout] 173 | | dir_deque, [INFO] [stdout] ... | [INFO] [stdout] 176 | | stats: LiveTreeIterStats::default(), [INFO] [stdout] 177 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(ait: AIT, bit: BIT) -> MergeTrees { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | na: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(ait: AIT, bit: BIT) -> MergeTrees { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | nb: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/owner/unix.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 46 | let users_cache = USERS_CACHE.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | match lchown(path, uid_opt, gid_opt) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/restore.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 216 | .map_err(|source| Error::RestoreFileBlock { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | source: Box::new(source), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/show.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 125 | let bw = BufWriter::new(w); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let index_entries: Vec = band.index().iter_entries().collect(); [INFO] [stdout] 127 | serde_json::ser::to_writer_pretty(bw, &index_entries) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:84:22 [INFO] [stdout] | [INFO] [stdout] 81 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | archive: archive.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 81 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | state: State::BeforeBand(band_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn empty(archive: &Archive, monitor: Arc) -> IterStitchedIndexHunks { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | IterStitchedIndexHunks { [INFO] [stdout] 93 | archive: archive.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stitch.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn empty(archive: &Archive, monitor: Arc) -> IterStitchedIndexHunks { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | state: State::Done, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stored_tree.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 66 | exclude: Exclude, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | monitor: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / IterStitchedIndexHunks::new(&self.archive, self.band.id(), monitor) [INFO] [stdout] 71 | | .iter_entries(subtree, exclude), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_fixtures.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn entry_iter_to_apath_strings(entry_iter: EntryIter) -> Vec [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | / entry_iter [INFO] [stdout] 199 | | .into_iter() [INFO] [stdout] 200 | | .map(|entry| entry.apath().clone().into()) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:193:21 [INFO] [stdout] | [INFO] [stdout] 185 | pub(self) fn io_error(path: &Path, source: io::Error) -> Error { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | source: Some(Box::new(source)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/local.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 73 | let mut file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(out_buf.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 82 | let runtime = tokio::runtime::Builder::new_current_thread() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let config = load_aws_config(&runtime, None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let client = aws_sdk_s3::Client::new(&config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let location_request = client [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let config = load_aws_config(&runtime, region); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let client = aws_sdk_s3::Client::new(&config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Arc::new(S3Transport { [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | bucket, [INFO] [stdout] 125 | | base_path, [INFO] [stdout] 126 | | client: Arc::new(client), [INFO] [stdout] 127 | | runtime: Arc::new(runtime), [INFO] [stdout] 128 | | storage_class: StorageClass::IntelligentTiering, [INFO] [stdout] 129 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:141:22 [INFO] [stdout] | [INFO] [stdout] 136 | let loader = aws_config::defaults(BehaviorVersion::latest()) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | runtime.block_on(loader.load()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 244 | .map_err(|source| Error { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | source: Some(Box::new(source)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/s3.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 384 | fn s3_error(key: K, source: SdkError) -> Error [INFO] [stdout] | ------ ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | source: Some(source.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `conserve` (lib test) due to 52 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 51 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `conserve` (lib) due to 52 previous errors [INFO] running `Command { std: "docker" "inspect" "357df06edeb6133e10e206a812d7ba0f2a3fee2f76148a99501e3563903e7b50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "357df06edeb6133e10e206a812d7ba0f2a3fee2f76148a99501e3563903e7b50", kill_on_drop: false }` [INFO] [stdout] 357df06edeb6133e10e206a812d7ba0f2a3fee2f76148a99501e3563903e7b50