[INFO] fetching crate confitul 0.1.4... [INFO] checking confitul-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate confitul 0.1.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate confitul 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate confitul 0.1.4 [INFO] finished tweaking crates.io crate confitul 0.1.4 [INFO] tweaked toml for crates.io crate confitul 0.1.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding ckey v0.1.1 (latest: v0.4.3) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gethostname v0.2.3 (latest: v0.5.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hashlru v0.6.1 (latest: v0.11.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding vclock v0.2.3 (latest: v0.4.4) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] acdab26dde82fd3baa4ba9450a6e3ca2b5534888a7fb2d0f388af6677de46026 [INFO] running `Command { std: "docker" "start" "-a" "acdab26dde82fd3baa4ba9450a6e3ca2b5534888a7fb2d0f388af6677de46026", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "acdab26dde82fd3baa4ba9450a6e3ca2b5534888a7fb2d0f388af6677de46026", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acdab26dde82fd3baa4ba9450a6e3ca2b5534888a7fb2d0f388af6677de46026", kill_on_drop: false }` [INFO] [stdout] acdab26dde82fd3baa4ba9450a6e3ca2b5534888a7fb2d0f388af6677de46026 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0eda13fc14a0c3f405ac0e0c12078562a2349c835be57133ae1568d8d70fa96a [INFO] running `Command { std: "docker" "start" "-a" "0eda13fc14a0c3f405ac0e0c12078562a2349c835be57133ae1568d8d70fa96a", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking gethostname v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking hashlru v0.6.1 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking ckey v0.1.1 [INFO] [stderr] Checking vclock v0.2.3 [INFO] [stderr] Checking confitul v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_store.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn assign_value(&self, key: CKey, version: VClock, value: V) -> Option> { [INFO] [stdout] | ------------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | / Versioned { [INFO] [stdout] 127 | | version, [INFO] [stdout] 128 | | value: Some(value), [INFO] [stdout] 129 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_store.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn assign_kill(&self, key: CKey, version: VClock) -> Option> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | / Versioned { [INFO] [stdout] 137 | | value: None, [INFO] [stdout] 138 | | version, [INFO] [stdout] 139 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_store.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 284 | let mut suggestion_mode = self.suggestion_mode.write().unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let suggestions = self.drain_suggestions(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | / suggestions [INFO] [stdout] 290 | | .map(|suggestion| self.assign_versioned(suggestion.key, suggestion.versioned)) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `confitul` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_store.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn assign_value(&self, key: CKey, version: VClock, value: V) -> Option> { [INFO] [stdout] | ------------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | / Versioned { [INFO] [stdout] 127 | | version, [INFO] [stdout] 128 | | value: Some(value), [INFO] [stdout] 129 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_store.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn assign_kill(&self, key: CKey, version: VClock) -> Option> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | / Versioned { [INFO] [stdout] 137 | | value: None, [INFO] [stdout] 138 | | version, [INFO] [stdout] 139 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_store.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 284 | let mut suggestion_mode = self.suggestion_mode.write().unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let suggestions = self.drain_suggestions(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | / suggestions [INFO] [stdout] 290 | | .map(|suggestion| self.assign_versioned(suggestion.key, suggestion.versioned)) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `confitul` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "0eda13fc14a0c3f405ac0e0c12078562a2349c835be57133ae1568d8d70fa96a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0eda13fc14a0c3f405ac0e0c12078562a2349c835be57133ae1568d8d70fa96a", kill_on_drop: false }` [INFO] [stdout] 0eda13fc14a0c3f405ac0e0c12078562a2349c835be57133ae1568d8d70fa96a