[INFO] fetching crate confit 1.3.2... [INFO] checking confit-1.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate confit 1.3.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate confit 1.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate confit 1.3.2 [INFO] finished tweaking crates.io crate confit 1.3.2 [INFO] tweaked toml for crates.io crate confit 1.3.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate confit 1.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5643bdd503c30b367c60a7415712596efa2d92cc12d11cb5e11ae699fcbd1f66 [INFO] running `Command { std: "docker" "start" "-a" "5643bdd503c30b367c60a7415712596efa2d92cc12d11cb5e11ae699fcbd1f66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5643bdd503c30b367c60a7415712596efa2d92cc12d11cb5e11ae699fcbd1f66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5643bdd503c30b367c60a7415712596efa2d92cc12d11cb5e11ae699fcbd1f66", kill_on_drop: false }` [INFO] [stdout] 5643bdd503c30b367c60a7415712596efa2d92cc12d11cb5e11ae699fcbd1f66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 891cf80f51f382c103d7db06b52024e4b699fbd7c91ca37738c29e1c36a4a7f8 [INFO] running `Command { std: "docker" "start" "-a" "891cf80f51f382c103d7db06b52024e4b699fbd7c91ca37738c29e1c36a4a7f8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling anyhow v1.0.41 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking deunicode v0.4.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Checking humansize v1.1.1 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling regex v1.5.4 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Compiling chrono-tz v0.5.3 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling include_dir_impl v0.6.1 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking include_dir v0.6.1 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling dummy v0.4.0 [INFO] [stderr] Checking fake v2.4.1 [INFO] [stderr] Checking tera v1.11.0 [INFO] [stderr] Checking confit v1.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `example` is never used [INFO] [stdout] --> src/git.rs:77:6 [INFO] [stdout] | [INFO] [stdout] 57 | pub trait Provider { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 77 | fn example(&self) -> Self::Data { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/git/parse.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | ParseInt(std::num::ParseIntError), [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Err` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 101 | ParseInt(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Input` is never used [INFO] [stdout] --> src/git/parse.rs:143:7 [INFO] [stdout] | [INFO] [stdout] 143 | trait Input: AsRef + Eq + Default {} [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:188:3 [INFO] [stdout] | [INFO] [stdout] 187 | fn collect( provider: impl git::Provider, reqs: Group, errcode: i32,) -> T { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | provider.collect(reqs).unwrap_or_else(&error_status(errcode)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:188:42 [INFO] [stdout] | [INFO] [stdout] 187 | fn collect( provider: impl git::Provider, reqs: Group, errcode: i32,) -> T { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | provider.collect(reqs).unwrap_or_else(&error_status(errcode)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preserves.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn tagged_checks<'a, 'b>(tags: impl Clone + IntoIterator) -> Vec<&'a Check> { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / ALL_CHECKS.iter().filter(move |ch| tags.clone().into_iter() [INFO] [stdout] 113 | | .any(|t| ch.tags.iter().any(|&c| (t == c) ))).collect() [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preserves.rs:112:40 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn tagged_checks<'a, 'b>(tags: impl Clone + IntoIterator) -> Vec<&'a Check> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ALL_CHECKS.iter().filter(move |ch| tags.clone().into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `confit` (bin "confit") due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `example` is never used [INFO] [stdout] --> src/git.rs:77:6 [INFO] [stdout] | [INFO] [stdout] 57 | pub trait Provider { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 77 | fn example(&self) -> Self::Data { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/git/parse.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | ParseInt(std::num::ParseIntError), [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Err` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 101 | ParseInt(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Input` is never used [INFO] [stdout] --> src/git/parse.rs:143:7 [INFO] [stdout] | [INFO] [stdout] 143 | trait Input: AsRef + Eq + Default {} [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:188:3 [INFO] [stdout] | [INFO] [stdout] 187 | fn collect( provider: impl git::Provider, reqs: Group, errcode: i32,) -> T { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | provider.collect(reqs).unwrap_or_else(&error_status(errcode)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:188:42 [INFO] [stdout] | [INFO] [stdout] 187 | fn collect( provider: impl git::Provider, reqs: Group, errcode: i32,) -> T { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | provider.collect(reqs).unwrap_or_else(&error_status(errcode)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preserves.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn tagged_checks<'a, 'b>(tags: impl Clone + IntoIterator) -> Vec<&'a Check> { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / ALL_CHECKS.iter().filter(move |ch| tags.clone().into_iter() [INFO] [stdout] 113 | | .any(|t| ch.tags.iter().any(|&c| (t == c) ))).collect() [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preserves.rs:112:40 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn tagged_checks<'a, 'b>(tags: impl Clone + IntoIterator) -> Vec<&'a Check> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ALL_CHECKS.iter().filter(move |ch| tags.clone().into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `confit` (bin "confit" test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "891cf80f51f382c103d7db06b52024e4b699fbd7c91ca37738c29e1c36a4a7f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "891cf80f51f382c103d7db06b52024e4b699fbd7c91ca37738c29e1c36a4a7f8", kill_on_drop: false }` [INFO] [stdout] 891cf80f51f382c103d7db06b52024e4b699fbd7c91ca37738c29e1c36a4a7f8