[INFO] fetching crate configrs 0.1.4... [INFO] checking configrs-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate configrs 0.1.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate configrs 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate configrs 0.1.4 [INFO] finished tweaking crates.io crate configrs 0.1.4 [INFO] tweaked toml for crates.io crate configrs 0.1.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate configrs 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7259508d3fe9d5ef73cefdf8a70a534c0a915e803e54c5b0787eb44afd13200 [INFO] running `Command { std: "docker" "start" "-a" "f7259508d3fe9d5ef73cefdf8a70a534c0a915e803e54c5b0787eb44afd13200", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7259508d3fe9d5ef73cefdf8a70a534c0a915e803e54c5b0787eb44afd13200", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7259508d3fe9d5ef73cefdf8a70a534c0a915e803e54c5b0787eb44afd13200", kill_on_drop: false }` [INFO] [stdout] f7259508d3fe9d5ef73cefdf8a70a534c0a915e803e54c5b0787eb44afd13200 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa16066a8d1b7035f1df03fabeb7459350e8b7f33006faf51025a729c5cec490 [INFO] running `Command { std: "docker" "start" "-a" "fa16066a8d1b7035f1df03fabeb7459350e8b7f33006faf51025a729c5cec490", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling smallvec v1.11.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling linux-raw-sys v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling bitflags v2.4.1 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling ena v0.14.2 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking winnow v0.5.32 [INFO] [stderr] Checking lalrpop-util v0.19.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling is-terminal v0.4.10 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Compiling parking_lot v0.12.1 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking serde_json v1.0.108 [INFO] [stderr] Checking serde_yaml v0.9.30 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Compiling env-file-reader v0.3.0 [INFO] [stderr] Checking configrs v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/config_impl.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 103 | |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let reader = std::io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | serde_json::from_reader::<_, serde_json::Value>(reader).map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/config_impl.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 249 | file_path: impl AsRef, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | ) -> Result { [INFO] [stdout] 251 | match std::fs::read_to_string(file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_impl.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 72 | fn from(value: Vec) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self::Array(value.into_iter().map(|v| v.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_impl.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 90 | fn from(value: HashMap) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Self::Map(value.into_iter().map(|(k, v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_serde_impl.rs:362:9 [INFO] [stdout] | [INFO] [stdout] 357 | fn next_value_seed(&mut self, seed: V) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | serde::de::DeserializeSeed::deserialize(seed, value).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_serde_impl.rs:456:12 [INFO] [stdout] | [INFO] [stdout] 443 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), ConfigError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | let value = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | Ok((value, self)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/config_impl.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 103 | |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let reader = std::io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | serde_json::from_reader::<_, serde_json::Value>(reader).map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `configrs` (lib test) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/config_impl.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 249 | file_path: impl AsRef, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | ) -> Result { [INFO] [stdout] 251 | match std::fs::read_to_string(file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_impl.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 72 | fn from(value: Vec) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self::Array(value.into_iter().map(|v| v.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_impl.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 90 | fn from(value: HashMap) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Self::Map(value.into_iter().map(|(k, v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_serde_impl.rs:362:9 [INFO] [stdout] | [INFO] [stdout] 357 | fn next_value_seed(&mut self, seed: V) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | serde::de::DeserializeSeed::deserialize(seed, value).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/value_serde_impl.rs:456:12 [INFO] [stdout] | [INFO] [stdout] 443 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), ConfigError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | let value = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | Ok((value, self)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `configrs` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "fa16066a8d1b7035f1df03fabeb7459350e8b7f33006faf51025a729c5cec490", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa16066a8d1b7035f1df03fabeb7459350e8b7f33006faf51025a729c5cec490", kill_on_drop: false }` [INFO] [stdout] fa16066a8d1b7035f1df03fabeb7459350e8b7f33006faf51025a729c5cec490