[INFO] fetching crate conf 0.1.0... [INFO] checking conf-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate conf 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate conf 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate conf 0.1.0 [INFO] finished tweaking crates.io crate conf 0.1.0 [INFO] tweaked toml for crates.io crate conf 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate conf 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eaf2853c24346b96ee6af2afe3a1fe998f58fda5929b30557a4ca85e7637ac3d [INFO] running `Command { std: "docker" "start" "-a" "eaf2853c24346b96ee6af2afe3a1fe998f58fda5929b30557a4ca85e7637ac3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eaf2853c24346b96ee6af2afe3a1fe998f58fda5929b30557a4ca85e7637ac3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaf2853c24346b96ee6af2afe3a1fe998f58fda5929b30557a4ca85e7637ac3d", kill_on_drop: false }` [INFO] [stdout] eaf2853c24346b96ee6af2afe3a1fe998f58fda5929b30557a4ca85e7637ac3d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dbbc588800fab773adc4ea7f8e3f7457dd5bba6615b81bf599f2aedf5319d3cf [INFO] running `Command { std: "docker" "start" "-a" "dbbc588800fab773adc4ea7f8e3f7457dd5bba6615b81bf599f2aedf5319d3cf", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking tinyvec v1.7.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling escargot v0.5.11 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling conf_derive v0.1.0 [INFO] [stderr] Checking conf v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:512:9 [INFO] [stdout] | [INFO] [stdout] 508 | pub(crate) fn into_clap_error(self, command: &Command) -> Error { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 512 | / ClapError::raw(self.error_kind(), buf) [INFO] [stdout] 513 | | .with_cmd(command) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 517 | pub(crate) fn vec_to_clap_error(mut src: Vec, command: &Command) -> Error { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 548 | / ClapError::raw(last_error_kind, buf) [INFO] [stdout] 549 | | .with_cmd(command) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_env.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn parse_env(env_vars_os: impl IntoIterator) -> ParsedEnv [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | map: env_vars_os [INFO] [stdout] | ______________^ [INFO] [stdout] 39 | | .into_iter() [INFO] [stdout] 40 | | .filter_map(|(into_key, into_val)| { [INFO] [stdout] 41 | | if let Ok(key) = into_key.into().into_string() { [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 50 | let mut command = Command::new(parser_config.name); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let mut args = Vec::::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | parser_config, [INFO] [stdout] 95 | | options, [INFO] [stdout] 96 | | id_to_option, [INFO] [stdout] 97 | | env, [INFO] [stdout] 98 | | command, [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn parse(&self, args_os: impl IntoIterator) -> Result [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 113 | | .command [INFO] [stdout] 114 | | .clone() [INFO] [stdout] 115 | | .try_get_matches_from(args_os) [INFO] [stdout] ... | [INFO] [stdout] 118 | | id_to_option: &self.id_to_option, [INFO] [stdout] 119 | | })?) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:266:12 [INFO] [stdout] | [INFO] [stdout] 174 | let mut arg = Arg::new(option.id.clone().into_owned()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | Ok(MaybeArg::Arg(arg)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 31 | args_os: impl IntoIterator, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | env_vars_os: impl IntoIterator, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | match Self::try_parse_from(args_os, env_vars_os) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 47 | args_os: impl IntoIterator, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | env_vars_os: impl IntoIterator, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let parser = Parser::new(parser_config, program_options, &parsed_env)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let parsed_args = parser.parse(args_os)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let conf_context = ConfContext::new(&parsed_args, &parsed_env); [INFO] [stdout] 61 | Self::from_conf_context(conf_context) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `conf` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "dbbc588800fab773adc4ea7f8e3f7457dd5bba6615b81bf599f2aedf5319d3cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbbc588800fab773adc4ea7f8e3f7457dd5bba6615b81bf599f2aedf5319d3cf", kill_on_drop: false }` [INFO] [stdout] dbbc588800fab773adc4ea7f8e3f7457dd5bba6615b81bf599f2aedf5319d3cf