[INFO] fetching crate concordium-std 10.1.0... [INFO] checking concordium-std-10.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate concordium-std 10.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate concordium-std 10.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate concordium-std 10.1.0 [INFO] finished tweaking crates.io crate concordium-std 10.1.0 [INFO] tweaked toml for crates.io crate concordium-std 10.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 80 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519-zebra v2.2.0 (latest: v4.0.3) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hashbrown v0.11.2 (latest: v0.14.5) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding secp256k1 v0.22.2 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.5.2 (latest: v0.10.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e08b1492f1ac02a3a4b243b3340e55ef9d1ef0a47877da7c0deae092daf695eb [INFO] running `Command { std: "docker" "start" "-a" "e08b1492f1ac02a3a4b243b3340e55ef9d1ef0a47877da7c0deae092daf695eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e08b1492f1ac02a3a4b243b3340e55ef9d1ef0a47877da7c0deae092daf695eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e08b1492f1ac02a3a4b243b3340e55ef9d1ef0a47877da7c0deae092daf695eb", kill_on_drop: false }` [INFO] [stdout] e08b1492f1ac02a3a4b243b3340e55ef9d1ef0a47877da7c0deae092daf695eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 858d4493e4d6f4c08a76a31d04ef6e7f2c8c0573ecb6ee5ec53586c7365f2f21 [INFO] running `Command { std: "docker" "start" "-a" "858d4493e4d6f4c08a76a31d04ef6e7f2c8c0573ecb6ee5ec53586c7365f2f21", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Compiling concordium-contracts-common-derive v4.1.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking concordium-contracts-common v9.1.0 [INFO] [stderr] Checking concordium-std v10.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:906:27 [INFO] [stdout] | [INFO] [stdout] 904 | self.state_api.lookup_entry(&k).map(|mut entry| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 905 | // Unwrapping is safe when using only the high-level API. [INFO] [stdout] 906 | StateRef::new(V::deserial_with_state(&self.state_api, &mut entry).unwrap_abort()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:916:14 [INFO] [stdout] | [INFO] [stdout] 915 | let entry = self.state_api.lookup_entry(&k)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 916 | Some(StateRefMut::new(entry, self.state_api.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:926:15 [INFO] [stdout] | [INFO] [stdout] 923 | pub(crate) fn insert_borrowed(&mut self, key: &K, value: V) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 926 | match self.state_api.entry(key_bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:957:15 [INFO] [stdout] | [INFO] [stdout] 954 | pub fn entry(&mut self, key: K) -> Entry<'_, K, V, S> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 957 | match self.state_api.lookup_entry(&key_bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:1125:14 [INFO] [stdout] | [INFO] [stdout] 1116 | let mut entry = self.state_iter.as_mut()?.next()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1123 | let k = K::deserial(&mut key_cursor).unwrap_abort(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1124 | let v = V::deserial_with_state(&self.state_api, &mut entry).unwrap_abort(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1125 | Some((StateRef::new(k), StateRef::new(v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:1149:14 [INFO] [stdout] | [INFO] [stdout] 1138 | let entry = self.state_iter.as_mut()?.next()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1146 | let k = K::deserial(&mut key_cursor).unwrap_abort(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1149 | Some((StateRef::new(k), StateRefMut::new(entry, self.state_api.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:1248:9 [INFO] [stdout] | [INFO] [stdout] 1229 | pub fn update(&mut self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1241 | let value = V::deserial_with_state(&self.state_api, entry).unwrap_abort(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1248 | value.serial(entry).unwrap_abort() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:1280:15 [INFO] [stdout] | [INFO] [stdout] 1278 | pub fn insert(&mut self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1279 | let key_bytes = self.key_with_set_prefix(&value); [INFO] [stdout] 1280 | match self.state_api.entry(key_bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:1367:20 [INFO] [stdout] | [INFO] [stdout] 1364 | pub(crate) fn new(value: T, state_api: S, entry: S::EntryType) -> Self { [INFO] [stdout] | -------- ------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1367 | inner: UnsafeCell::new(StateBoxInner::Loaded { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1368 | | entry, [INFO] [stdout] 1369 | | modified: true, [INFO] [stdout] 1370 | | value, [INFO] [stdout] 1371 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:1584:14 [INFO] [stdout] | [INFO] [stdout] 1576 | let entry = self.state_iter.as_mut()?.next()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1583 | let t = T::deserial_with_state(&self.state_api, &mut key_cursor).unwrap_abort(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1584 | Some(StateRef::new(t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:2980:61 [INFO] [stdout] | [INFO] [stdout] 2980 | source.read_array().map(|map_prefix| StateMap::open(state.clone(), map_prefix)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls.rs:2990:61 [INFO] [stdout] | [INFO] [stdout] 2990 | source.read_array().map(|set_prefix| StateSet::open(state.clone(), set_prefix)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_btree.rs:779:9 [INFO] [stdout] | [INFO] [stdout] 768 | fn remove_largest_key(&mut self, mut node: StateRefMut<'_, Node, StateApi>) -> K [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | node.keys.pop().unwrap_abort() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_btree.rs:887:9 [INFO] [stdout] | [INFO] [stdout] 880 | let mut node = self.get_node(node.children[child_index]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 887 | node.keys.pop().unwrap_abort() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_btree.rs:1097:14 [INFO] [stdout] | [INFO] [stdout] 1085 | let key = node.keys[*index].key.take().unwrap_abort(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1097 | Some(StateRef::new(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_btree.rs:1128:14 [INFO] [stdout] | [INFO] [stdout] 1125 | let next_key = self.key_iter.next()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1126 | let value = self.map.get(&next_key).unwrap_abort(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1127 | // Unwrap is safe, otherwise the map and the set have inconsistencies. [INFO] [stdout] 1128 | Some((next_key, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_btree.rs:1231:12 [INFO] [stdout] | [INFO] [stdout] 1230 | let key = K::deserial(source)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1231 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1232 | | key: Some(key), [INFO] [stdout] 1233 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:288:15 [INFO] [stdout] | [INFO] [stdout] 287 | fn entry + Into>(&mut self, key: K) -> EntryRaw { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | match self.lookup_entry(key.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:399:20 [INFO] [stdout] | [INFO] [stdout] 397 | pub(crate) fn new(entry: S::EntryType, state_api: S) -> Self { [INFO] [stdout] | ------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | Self { [INFO] [stdout] 399 | entry: UnsafeCell::new(entry), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:401:25 [INFO] [stdout] | [INFO] [stdout] 397 | pub(crate) fn new(entry: S::EntryType, state_api: S) -> Self { [INFO] [stdout] | ------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | lazy_value: UnsafeCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1187:23 [INFO] [stdout] | [INFO] [stdout] 1181 | pub fn new(mock_fn_return: F) -> Self [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1187 | match mock_fn_return(parameter, amount, balance, state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1234:19 [INFO] [stdout] | [INFO] [stdout] 1224 | pub fn new_v1(mock_fn_return: F) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1234 | Self::new(move |p, a, b, s| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 1235 | | mock_fn_return(p, a, b, s).map(|(modified, rv)| (modified, Some(rv))) [INFO] [stdout] 1236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1235:13 [INFO] [stdout] | [INFO] [stdout] 1224 | pub fn new_v1(mock_fn_return: F) -> Self [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1235 | mock_fn_return(p, a, b, s).map(|(modified, rv)| (modified, Some(rv))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1235:72 [INFO] [stdout] | [INFO] [stdout] 1235 | mock_fn_return(p, a, b, s).map(|(modified, rv)| (modified, Some(rv))) [INFO] [stdout] | -------------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1247:19 [INFO] [stdout] | [INFO] [stdout] 1242 | pub fn new_v0(mock_fn_return: F) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1247 | Self::new(move |p, a, b, s| mock_fn_return(p, a, b, s).map(|modified| (modified, None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1247:37 [INFO] [stdout] | [INFO] [stdout] 1242 | pub fn new_v0(mock_fn_return: F) -> Self [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1247 | Self::new(move |p, a, b, s| mock_fn_return(p, a, b, s).map(|modified| (modified, None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1247:90 [INFO] [stdout] | [INFO] [stdout] 1247 | Self::new(move |p, a, b, s| mock_fn_return(p, a, b, s).map(|modified| (modified, None))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1253:19 [INFO] [stdout] | [INFO] [stdout] 1252 | pub fn returning_ok(return_value: R) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1253 | Self::new(move |_parameter, _amount, _balance, _state| -> CallContractResult { [INFO] [stdout] | ___________________^ [INFO] [stdout] 1254 | | Ok((false, Some(return_value.clone()))) [INFO] [stdout] 1255 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1254:16 [INFO] [stdout] | [INFO] [stdout] 1252 | pub fn returning_ok(return_value: R) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1253 | Self::new(move |_parameter, _amount, _balance, _state| -> CallContractResult { [INFO] [stdout] 1254 | Ok((false, Some(return_value.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1262:13 [INFO] [stdout] | [INFO] [stdout] 1260 | pub fn returning_err(error: CallContractError) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1261 | Self::new( [INFO] [stdout] 1262 | / move |_parameter: Parameter, [INFO] [stdout] 1263 | | _amount: Amount, [INFO] [stdout] 1264 | | _balance: &mut Amount, [INFO] [stdout] 1265 | | _state: &mut State| [INFO] [stdout] 1266 | | -> CallContractResult { Err(error.clone()) }, [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1266:50 [INFO] [stdout] | [INFO] [stdout] 1260 | pub fn returning_err(error: CallContractError) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1266 | -> CallContractResult { Err(error.clone()) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1613:26 [INFO] [stdout] | [INFO] [stdout] 1606 | pub fn new(state: State, mut state_builder: StateBuilder) -> Self { [INFO] [stdout] | ------------ --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1613 | mocking_fns: Rc::new(RefCell::new(BTreeMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1830:26 [INFO] [stdout] | [INFO] [stdout] 1825 | let cloned_state_api = self.state_builder.state_api.clone_deep(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1826 | let state: State = cloned_state_api [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1830 | mocking_fns: self.mocking_fns.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure.rs:1835:28 [INFO] [stdout] | [INFO] [stdout] 1825 | let cloned_state_api = self.state_builder.state_api.clone_deep(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1826 | let state: State = cloned_state_api [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1835 | state_builder: StateBuilder { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1836 | | state_api: cloned_state_api, [INFO] [stdout] 1837 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure/trie.rs:346:71 [INFO] [stdout] | [INFO] [stdout] 346 | data: self.data.as_ref().map(|d| Rc::new(RefCell::new(d.borrow().clone()))), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_infrastructure/trie.rs:350:66 [INFO] [stdout] | [INFO] [stdout] 350 | .map(|child| child.as_ref().map(|child| Box::new(child.clone_deep()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 36 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concordium-std` (lib) due to 37 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "858d4493e4d6f4c08a76a31d04ef6e7f2c8c0573ecb6ee5ec53586c7365f2f21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "858d4493e4d6f4c08a76a31d04ef6e7f2c8c0573ecb6ee5ec53586c7365f2f21", kill_on_drop: false }` [INFO] [stdout] 858d4493e4d6f4c08a76a31d04ef6e7f2c8c0573ecb6ee5ec53586c7365f2f21