[INFO] fetching crate comrak 0.27.0... [INFO] checking comrak-0.27.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate comrak 0.27.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate comrak 0.27.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate comrak 0.27.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate comrak 0.27.0 [INFO] tweaked toml for crates.io crate comrak 0.27.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate comrak 0.27.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2d215336554c4781c5205e9d53379bc5b1e855eff641c43536e478df6c371e54 [INFO] running `Command { std: "docker" "start" "-a" "2d215336554c4781c5205e9d53379bc5b1e855eff641c43536e478df6c371e54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2d215336554c4781c5205e9d53379bc5b1e855eff641c43536e478df6c371e54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d215336554c4781c5205e9d53379bc5b1e855eff641c43536e478df6c371e54", kill_on_drop: false }` [INFO] [stdout] 2d215336554c4781c5205e9d53379bc5b1e855eff641c43536e478df6c371e54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20fa1a002960d7511f0eacbe7151e790237ea05a995714631c04a99d8c4f1780 [INFO] running `Command { std: "docker" "start" "-a" "20fa1a002960d7511f0eacbe7151e790237ea05a995714631c04a99d8c4f1780", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling syn v1.0.107 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling cc v1.0.78 [INFO] [stderr] Compiling rustix v0.36.17 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling regex-syntax v0.6.28 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling serde_derive v1.0.152 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling serde_json v1.0.91 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Compiling indexmap v1.9.2 [INFO] [stderr] Checking itoa v1.0.5 [INFO] [stderr] Checking ryu v1.0.12 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking deunicode v0.4.5 [INFO] [stderr] Checking flate2 v1.0.25 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking entities v1.0.1 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking winnow v0.3.8 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Compiling regex v1.5.5 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml_datetime v0.6.1 [INFO] [stderr] Checking serde_spanned v0.6.1 [INFO] [stderr] Checking is-terminal v0.4.5 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking toml_edit v0.19.6 [INFO] [stderr] Compiling caseless v0.2.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling toml v0.5.10 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Compiling clap_derive v4.0.21 [INFO] [stderr] Compiling ntest_test_cases v0.9.2 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Checking toml v0.7.3 [INFO] [stderr] Compiling proc-macro-crate v1.2.1 [INFO] [stderr] Compiling ntest_timeout v0.9.2 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Checking ntest v0.9.2 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Checking clap v4.0.32 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling derive_builder_core v0.20.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.0 [INFO] [stderr] Checking derive_builder v0.20.0 [INFO] [stderr] Checking syntect v5.0.0 [INFO] [stderr] Checking comrak v0.27.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:23 [INFO] [stdout] | [INFO] [stdout] 127 | let mut bw = BufWriter::new(Vec::new()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | format_html_with_plugins(root, options, &mut bw, plugins).unwrap(); [INFO] [stdout] 129 | String::from_utf8(bw.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:23 [INFO] [stdout] | [INFO] [stdout] 141 | let mut bw = BufWriter::new(Vec::new()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | format_commonmark(root, options, &mut bw).unwrap(); [INFO] [stdout] 143 | String::from_utf8(bw.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:23 [INFO] [stdout] | [INFO] [stdout] 161 | let mut bw = BufWriter::new(Vec::new()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | format_xml_with_plugins(root, options, &mut bw, plugins).unwrap(); [INFO] [stdout] 163 | String::from_utf8(bw.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cm.rs:341:34 [INFO] [stdout] | [INFO] [stdout] 341 | .map_or(true, |next| next.data.borrow().value.block()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | Lazy::new(|| Regex::new(r"[^\p{L}\p{M}\p{N}\p{Pc} -]").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:696:30 [INFO] [stdout] | [INFO] [stdout] 696 | .map(|n| n.data.borrow().value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:704:47 [INFO] [stdout] | [INFO] [stdout] 704 | node.parent().map(|n| n.data.borrow().value.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes.rs:715:41 [INFO] [stdout] | [INFO] [stdout] 715 | node.last_child().map_or(false, |n| n.data.borrow().open) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntect.rs:240:25 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn build(self) -> SyntectAdapter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | syntax_set: self [INFO] [stdout] | _________________________^ [INFO] [stdout] 241 | | .syntax_set [INFO] [stdout] 242 | | .unwrap_or_else(SyntaxSet::load_defaults_newlines), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `comrak` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:23 [INFO] [stdout] | [INFO] [stdout] 127 | let mut bw = BufWriter::new(Vec::new()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | format_html_with_plugins(root, options, &mut bw, plugins).unwrap(); [INFO] [stdout] 129 | String::from_utf8(bw.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:23 [INFO] [stdout] | [INFO] [stdout] 141 | let mut bw = BufWriter::new(Vec::new()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | format_commonmark(root, options, &mut bw).unwrap(); [INFO] [stdout] 143 | String::from_utf8(bw.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:23 [INFO] [stdout] | [INFO] [stdout] 161 | let mut bw = BufWriter::new(Vec::new()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | format_xml_with_plugins(root, options, &mut bw, plugins).unwrap(); [INFO] [stdout] 163 | String::from_utf8(bw.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cm.rs:341:34 [INFO] [stdout] | [INFO] [stdout] 341 | .map_or(true, |next| next.data.borrow().value.block()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | Lazy::new(|| Regex::new(r"[^\p{L}\p{M}\p{N}\p{Pc} -]").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:696:30 [INFO] [stdout] | [INFO] [stdout] 696 | .map(|n| n.data.borrow().value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:704:47 [INFO] [stdout] | [INFO] [stdout] 704 | node.parent().map(|n| n.data.borrow().value.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes.rs:715:41 [INFO] [stdout] | [INFO] [stdout] 715 | node.last_child().map_or(false, |n| n.data.borrow().open) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntect.rs:240:25 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn build(self) -> SyntectAdapter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | syntax_set: self [INFO] [stdout] | _________________________^ [INFO] [stdout] 241 | | .syntax_set [INFO] [stdout] 242 | | .unwrap_or_else(SyntaxSet::load_defaults_newlines), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `comrak` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "20fa1a002960d7511f0eacbe7151e790237ea05a995714631c04a99d8c4f1780", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20fa1a002960d7511f0eacbe7151e790237ea05a995714631c04a99d8c4f1780", kill_on_drop: false }` [INFO] [stdout] 20fa1a002960d7511f0eacbe7151e790237ea05a995714631c04a99d8c4f1780