[INFO] fetching crate compact-genome 3.0.0... [INFO] checking compact-genome-3.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate compact-genome 3.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate compact-genome 3.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate compact-genome 3.0.0 [INFO] finished tweaking crates.io crate compact-genome 3.0.0 [INFO] tweaked toml for crates.io crate compact-genome 3.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3045ded1415bf50c35a2ef57fcb9364e3d02410cd128ba10fa10664805a046d [INFO] running `Command { std: "docker" "start" "-a" "e3045ded1415bf50c35a2ef57fcb9364e3d02410cd128ba10fa10664805a046d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3045ded1415bf50c35a2ef57fcb9364e3d02410cd128ba10fa10664805a046d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3045ded1415bf50c35a2ef57fcb9364e3d02410cd128ba10fa10664805a046d", kill_on_drop: false }` [INFO] [stdout] e3045ded1415bf50c35a2ef57fcb9364e3d02410cd128ba10fa10664805a046d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd51388d827da4c284b624859b43cad8e0d9a583cc31421589ff6943d7cbd412 [INFO] running `Command { std: "docker" "start" "-a" "bd51388d827da4c284b624859b43cad8e0d9a583cc31421589ff6943d7cbd412", kill_on_drop: false }` [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking traitsequence v2.0.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking compact-genome v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/implementation/array_kmer.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 83 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Self { [INFO] [stdout] 85 | array: iter [INFO] [stdout] | ____________________^ [INFO] [stdout] 86 | | .into_iter() [INFO] [stdout] 87 | | .collect::>() [INFO] [stdout] 88 | | .try_into() [INFO] [stdout] 89 | | .unwrap_or_else(|error: Vec<_>| { [INFO] [stdout] 90 | | panic!("iterator is not of length k = {K}, but {}", error.len()) [INFO] [stdout] 91 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/sequence/mod.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | fn from_iter_u8>(iter: T) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / iter.into_iter() [INFO] [stdout] 144 | | .map(AlphabetType::ascii_to_character) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/sequence/mod.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 183 | fn into_iter_u8(self) -> IntoIterU8 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | self.into_iter().map(AlphabetType::character_to_ascii) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/sequence/neighbor_iterators.rs:52:33 [INFO] [stdout] | [INFO] [stdout] 48 | fn new(sequence: Sequence) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | original_character: if sequence.len() > 0 { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 53 | | sequence[0].clone() [INFO] [stdout] 54 | | } else { [INFO] [stdout] 55 | | AlphabetType::CharacterType::from_index(0).unwrap() [INFO] [stdout] 56 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/implementation/array_kmer.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 83 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Self { [INFO] [stdout] 85 | array: iter [INFO] [stdout] | ____________________^ [INFO] [stdout] 86 | | .into_iter() [INFO] [stdout] 87 | | .collect::>() [INFO] [stdout] 88 | | .try_into() [INFO] [stdout] 89 | | .unwrap_or_else(|error: Vec<_>| { [INFO] [stdout] 90 | | panic!("iterator is not of length k = {K}, but {}", error.len()) [INFO] [stdout] 91 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compact-genome` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/sequence/mod.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | fn from_iter_u8>(iter: T) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / iter.into_iter() [INFO] [stdout] 144 | | .map(AlphabetType::ascii_to_character) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/sequence/mod.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 183 | fn into_iter_u8(self) -> IntoIterU8 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | self.into_iter().map(AlphabetType::character_to_ascii) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/sequence/neighbor_iterators.rs:52:33 [INFO] [stdout] | [INFO] [stdout] 48 | fn new(sequence: Sequence) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | original_character: if sequence.len() > 0 { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 53 | | sequence[0].clone() [INFO] [stdout] 54 | | } else { [INFO] [stdout] 55 | | AlphabetType::CharacterType::from_index(0).unwrap() [INFO] [stdout] 56 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compact-genome` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bd51388d827da4c284b624859b43cad8e0d9a583cc31421589ff6943d7cbd412", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd51388d827da4c284b624859b43cad8e0d9a583cc31421589ff6943d7cbd412", kill_on_drop: false }` [INFO] [stdout] bd51388d827da4c284b624859b43cad8e0d9a583cc31421589ff6943d7cbd412