[INFO] fetching crate comp_state 0.2.8... [INFO] checking comp_state-0.2.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate comp_state 0.2.8 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate comp_state 0.2.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate comp_state 0.2.8 [INFO] finished tweaking crates.io crate comp_state 0.2.8 [INFO] tweaked toml for crates.io crate comp_state 0.2.8 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding illicit v0.9.2 (latest: v1.1.2) [INFO] [stderr] Adding illicit-macro v0.9.0 (latest: v1.0.0) [INFO] [stderr] Adding proc-macro-error v0.4.12 (latest: v1.0.4) [INFO] [stderr] Adding proc-macro-error-attr v0.4.12 (latest: v1.0.4) [INFO] [stderr] Adding slotmap v0.4.3 (latest: v1.0.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding syn-mid v0.5.4 (latest: v0.6.0) [INFO] [stderr] Adding topo v0.9.4 (latest: v0.13.2) [INFO] [stderr] Adding topo-macro v0.9.0 (latest: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 650beb735a7b577f73ed1a8958f8442506fca1da628a12e1583e5b6197963834 [INFO] running `Command { std: "docker" "start" "-a" "650beb735a7b577f73ed1a8958f8442506fca1da628a12e1583e5b6197963834", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "650beb735a7b577f73ed1a8958f8442506fca1da628a12e1583e5b6197963834", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "650beb735a7b577f73ed1a8958f8442506fca1da628a12e1583e5b6197963834", kill_on_drop: false }` [INFO] [stdout] 650beb735a7b577f73ed1a8958f8442506fca1da628a12e1583e5b6197963834 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 78f36afd853fea39f0ccc33db57a41e77cdb5beca79ea82585134a410907d306 [INFO] running `Command { std: "docker" "start" "-a" "78f36afd853fea39f0ccc33db57a41e77cdb5beca79ea82585134a410907d306", kill_on_drop: false }` [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking slotmap v0.4.3 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Compiling syn-mid v0.5.4 [INFO] [stderr] Compiling topo-macro v0.9.0 [INFO] [stderr] Compiling illicit-macro v0.9.0 [INFO] [stderr] Checking illicit v0.9.2 [INFO] [stderr] Checking topo v0.9.4 [INFO] [stderr] Checking comp_state v0.2.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `track_caller` has been stable since 1.46.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(track_caller)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `track_caller` has been stable since 1.46.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(track_caller)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:14:46 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn use_list(initial_list_fn: F) -> ListControl [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let list_access = use_state(|| List::new(initial_list_fn())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:260:24 [INFO] [stdout] | [INFO] [stdout] 253 | fn new(mut items: Vec) -> List { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | let mut sm = DenseSlotMap::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | items_map: ListKeyDenseSlotMap(sm), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unmount.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(on_unmount: impl Fn() -> () + 'static) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | on_unmount: Box::new(on_unmount), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_state T>(data_fn: F) -> StateAccess { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | topo::call_in_slot(count.get(), || use_state_current(data_fn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn set_state_with_topo_id(data: T, current_id: topo::Id) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | STORE.with(|store_refcell| { [INFO] [stdout] | ________________^ [INFO] [stdout] 67 | | store_refcell [INFO] [stdout] 68 | | .borrow_mut() [INFO] [stdout] 69 | | .set_state_with_topo_id::(data, current_id) [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn set_state_with_topo_id(data: T, current_id: topo::Id) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | STORE.with(|store_refcell| { [INFO] [stdout] 67 | / store_refcell [INFO] [stdout] 68 | | .borrow_mut() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 74 | STORE.with(|store_refcell| store_refcell.borrow().state_exists_with_topo_id::(id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:78:32 [INFO] [stdout] | [INFO] [stdout] 78 | STORE.with(|store_refcell| store_refcell.borrow_mut().mark_id_as_active(id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:189:15 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn on_unmount () + 'static>(unmount_fn: F) -> StateAccess { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | use_state(|| Unmount::new(unmount_fn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:14:46 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn use_list(initial_list_fn: F) -> ListControl [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let list_access = use_state(|| List::new(initial_list_fn())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `comp_state` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:260:24 [INFO] [stdout] | [INFO] [stdout] 253 | fn new(mut items: Vec) -> List { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | let mut sm = DenseSlotMap::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | items_map: ListKeyDenseSlotMap(sm), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unmount.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(on_unmount: impl Fn() -> () + 'static) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | on_unmount: Box::new(on_unmount), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_state T>(data_fn: F) -> StateAccess { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | topo::call_in_slot(count.get(), || use_state_current(data_fn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn set_state_with_topo_id(data: T, current_id: topo::Id) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | STORE.with(|store_refcell| { [INFO] [stdout] | ________________^ [INFO] [stdout] 67 | | store_refcell [INFO] [stdout] 68 | | .borrow_mut() [INFO] [stdout] 69 | | .set_state_with_topo_id::(data, current_id) [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn set_state_with_topo_id(data: T, current_id: topo::Id) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | STORE.with(|store_refcell| { [INFO] [stdout] 67 | / store_refcell [INFO] [stdout] 68 | | .borrow_mut() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 74 | STORE.with(|store_refcell| store_refcell.borrow().state_exists_with_topo_id::(id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:78:32 [INFO] [stdout] | [INFO] [stdout] 78 | STORE.with(|store_refcell| store_refcell.borrow_mut().mark_id_as_active(id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_functions.rs:189:15 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn on_unmount () + 'static>(unmount_fn: F) -> StateAccess { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | use_state(|| Unmount::new(unmount_fn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `comp_state` (lib test) due to 10 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "78f36afd853fea39f0ccc33db57a41e77cdb5beca79ea82585134a410907d306", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78f36afd853fea39f0ccc33db57a41e77cdb5beca79ea82585134a410907d306", kill_on_drop: false }` [INFO] [stdout] 78f36afd853fea39f0ccc33db57a41e77cdb5beca79ea82585134a410907d306