[INFO] fetching crate committer 0.10.1... [INFO] checking committer-0.10.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate committer 0.10.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate committer 0.10.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate committer 0.10.1 [INFO] finished tweaking crates.io crate committer 0.10.1 [INFO] tweaked toml for crates.io crate committer 0.10.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate committer 0.10.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c211480f4dfe2c973faef46e4706be9a434213e75b1ff924b30f09956324ea8 [INFO] running `Command { std: "docker" "start" "-a" "8c211480f4dfe2c973faef46e4706be9a434213e75b1ff924b30f09956324ea8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c211480f4dfe2c973faef46e4706be9a434213e75b1ff924b30f09956324ea8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c211480f4dfe2c973faef46e4706be9a434213e75b1ff924b30f09956324ea8", kill_on_drop: false }` [INFO] [stdout] 8c211480f4dfe2c973faef46e4706be9a434213e75b1ff924b30f09956324ea8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbf20f4573c5312e390cf541c7e1a3860a6b2510dfad6d8260241c073b6de31d [INFO] running `Command { std: "docker" "start" "-a" "cbf20f4573c5312e390cf541c7e1a3860a6b2510dfad6d8260241c073b6de31d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking committer v0.10.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helper/mod.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 16 | let latest_version = semver::Version::parse(&latest_tag_clean)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let new_version = semver::Version::new(majors, minors, patches); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(Some(new_version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompt/scope.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn prompt(scopes: HashSet) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let commit_scope_completer = CommitScopeCompleter::new(scopes); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | [INFO] [stdout] 10 | / inquire::Text::new("Scope:") [INFO] [stdout] 11 | | .with_help_message("What is the scope of the commit?") [INFO] [stdout] 12 | | .with_autocomplete(commit_scope_completer) [INFO] [stdout] 13 | | .with_placeholder("No scope") [INFO] [stdout] 14 | | .prompt() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompt/subject.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 31 | let unique_subjects: HashSet = previous_subjects.into_iter().collect(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | previous_subjects: unique_subjects.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `committer` (bin "committer" test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helper/mod.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 16 | let latest_version = semver::Version::parse(&latest_tag_clean)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let new_version = semver::Version::new(majors, minors, patches); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(Some(new_version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompt/scope.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn prompt(scopes: HashSet) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let commit_scope_completer = CommitScopeCompleter::new(scopes); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | [INFO] [stdout] 10 | / inquire::Text::new("Scope:") [INFO] [stdout] 11 | | .with_help_message("What is the scope of the commit?") [INFO] [stdout] 12 | | .with_autocomplete(commit_scope_completer) [INFO] [stdout] 13 | | .with_placeholder("No scope") [INFO] [stdout] 14 | | .prompt() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompt/subject.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 31 | let unique_subjects: HashSet = previous_subjects.into_iter().collect(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | previous_subjects: unique_subjects.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `committer` (bin "committer") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "cbf20f4573c5312e390cf541c7e1a3860a6b2510dfad6d8260241c073b6de31d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbf20f4573c5312e390cf541c7e1a3860a6b2510dfad6d8260241c073b6de31d", kill_on_drop: false }` [INFO] [stdout] cbf20f4573c5312e390cf541c7e1a3860a6b2510dfad6d8260241c073b6de31d