[INFO] fetching crate collective-score-client 0.0.9... [INFO] checking collective-score-client-0.0.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate collective-score-client 0.0.9 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate collective-score-client 0.0.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate collective-score-client 0.0.9 [INFO] finished tweaking crates.io crate collective-score-client 0.0.9 [INFO] tweaked toml for crates.io crate collective-score-client 0.0.9 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate collective-score-client 0.0.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30d7957b257e3c6db9568e5823bfdc9bf07022ca7f95ac6271c229c364205a57 [INFO] running `Command { std: "docker" "start" "-a" "30d7957b257e3c6db9568e5823bfdc9bf07022ca7f95ac6271c229c364205a57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30d7957b257e3c6db9568e5823bfdc9bf07022ca7f95ac6271c229c364205a57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30d7957b257e3c6db9568e5823bfdc9bf07022ca7f95ac6271c229c364205a57", kill_on_drop: false }` [INFO] [stdout] 30d7957b257e3c6db9568e5823bfdc9bf07022ca7f95ac6271c229c364205a57 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a63b3eab4682da5f031ec42bff0611cdcf749954740e677c4abd26b8ed3bebd5 [INFO] running `Command { std: "docker" "start" "-a" "a63b3eab4682da5f031ec42bff0611cdcf749954740e677c4abd26b8ed3bebd5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling cc v1.1.14 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking textwrap v0.13.4 [INFO] [stderr] Checking ferris-says v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling typed-builder-macro v0.20.0 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking typed-builder v0.20.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking collective-score-client v0.0.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 98 | fn into_task(self, task_name: &'static str) -> Task { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | (task_name, Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 40 | let mut progress: InnerProgress = tasks [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { progress, path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 18 | let token = match token::load(data_dir) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(user_token) => Some(Self::token_from_str(&user_token)?), [INFO] [stdout] 20 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let progress = Progress::load(data_dir, tasks)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | [INFO] [stdout] 29 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | server_base_url, [INFO] [stdout] 31 | | token, [INFO] [stdout] 32 | | progress, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn client(token: HeaderValue) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let mut headers = HeaderMap::with_capacity(1); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | / Client::builder() [INFO] [stdout] 56 | | .default_headers(headers) [INFO] [stdout] 57 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 21 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | file.write_all(token.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `collective-score-client` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 98 | fn into_task(self, task_name: &'static str) -> Task { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | (task_name, Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 40 | let mut progress: InnerProgress = tasks [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { progress, path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 18 | let token = match token::load(data_dir) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(user_token) => Some(Self::token_from_str(&user_token)?), [INFO] [stdout] 20 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let progress = Progress::load(data_dir, tasks)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | [INFO] [stdout] 29 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | server_base_url, [INFO] [stdout] 31 | | token, [INFO] [stdout] 32 | | progress, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn client(token: HeaderValue) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let mut headers = HeaderMap::with_capacity(1); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | / Client::builder() [INFO] [stdout] 56 | | .default_headers(headers) [INFO] [stdout] 57 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 21 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | file.write_all(token.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/http.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | fn test_mo8it_com(validator: impl Validator) -> Result<(), CheckErr> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | / Check::builder() [INFO] [stdout] 76 | | .description("Calling mo8it.com") [INFO] [stdout] 77 | | .validator(validator) [INFO] [stdout] 78 | | .hint("Maybe Mo fucked up?") [INFO] [stdout] 79 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `collective-score-client` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "a63b3eab4682da5f031ec42bff0611cdcf749954740e677c4abd26b8ed3bebd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a63b3eab4682da5f031ec42bff0611cdcf749954740e677c4abd26b8ed3bebd5", kill_on_drop: false }` [INFO] [stdout] a63b3eab4682da5f031ec42bff0611cdcf749954740e677c4abd26b8ed3bebd5