[INFO] fetching crate codealong 0.1.1... [INFO] checking codealong-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate codealong 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate codealong 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate codealong 0.1.1 [INFO] finished tweaking crates.io crate codealong 0.1.1 [INFO] tweaked toml for crates.io crate codealong 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 115 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.5.11 (latest: v1.0.2) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding dirs v1.0.5 (latest: v5.0.1) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding git2 v0.8.0 (latest: v0.19.0) [INFO] [stderr] Adding glob v0.2.11 (latest: v0.3.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding include_dir v0.2.1 (latest: v0.7.4) [INFO] [stderr] Adding include_dir_impl v0.2.1 (latest: v0.6.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding libgit2-sys v0.7.11 (latest: v0.17.0+1.8.1) [INFO] [stderr] Adding libssh2-sys v0.2.23 (latest: v0.3.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding proc-macro-hack v0.4.3 (latest: v0.5.20+deprecated) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding redox_users v0.3.5 (latest: v0.4.6) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding rust-argon2 v0.8.3 (latest: v2.1.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding syn v0.14.9 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a18535670cde742e7bac549fa5dc685881ad6f717ef863ff4aeef63e5e284ee6 [INFO] running `Command { std: "docker" "start" "-a" "a18535670cde742e7bac549fa5dc685881ad6f717ef863ff4aeef63e5e284ee6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a18535670cde742e7bac549fa5dc685881ad6f717ef863ff4aeef63e5e284ee6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a18535670cde742e7bac549fa5dc685881ad6f717ef863ff4aeef63e5e284ee6", kill_on_drop: false }` [INFO] [stdout] a18535670cde742e7bac549fa5dc685881ad6f717ef863ff4aeef63e5e284ee6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93eef60a2a227262482fd2c2897de8b6808e7dea628218150a00a35783f21559 [INFO] running `Command { std: "docker" "start" "-a" "93eef60a2a227262482fd2c2897de8b6808e7dea628218150a00a35783f21559", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling curl-sys v0.4.74+curl-8.9.0 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling gimli v0.29.0 [INFO] [stderr] Compiling miniz_oxide v0.7.4 [INFO] [stderr] Compiling object v0.36.4 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling rustc-demangle v0.1.24 [INFO] [stderr] Compiling proc-macro-hack-impl v0.4.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling proc-macro-hack v0.4.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling addr2line v0.22.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Compiling failure v0.1.8 [INFO] [stderr] Compiling include_dir_impl v0.2.1 [INFO] [stderr] Checking include_dir v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking git2 v0.8.0 [INFO] [stderr] Checking codealong v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/repo.rs:12:33 [INFO] [stdout] | [INFO] [stdout] 12 | pub type ProgressCallback<'a> = FnMut(usize, usize) + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type ProgressCallback<'a> = dyn FnMut(usize, usize) + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/repo.rs:12:33 [INFO] [stdout] | [INFO] [stdout] 12 | pub type ProgressCallback<'a> = FnMut(usize, usize) + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type ProgressCallback<'a> = dyn FnMut(usize, usize) + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::FixedOffset::east`: use `east_opt()` instead [INFO] [stdout] --> src/utils.rs:224:27 [INFO] [stdout] | [INFO] [stdout] 224 | let tz = FixedOffset::east(time.offset_minutes() * 60); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead [INFO] [stdout] --> src/utils.rs:225:8 [INFO] [stdout] | [INFO] [stdout] 225 | tz.timestamp(time.seconds(), 0).with_timezone(&Utc) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::FixedOffset::east`: use `east_opt()` instead [INFO] [stdout] --> src/utils.rs:224:27 [INFO] [stdout] | [INFO] [stdout] 224 | let tz = FixedOffset::east(time.offset_minutes() * 60); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead [INFO] [stdout] --> src/utils.rs:225:8 [INFO] [stdout] | [INFO] [stdout] 225 | tz.timestamp(time.seconds(), 0).with_timezone(&Utc) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config_context.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | file_config.map(|c| tags.extend(c.tags().iter().map(|s| s.to_string()))); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_analyzer.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 79 | let mut diff_opts = DiffOptions::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | diff_opts.ignore_whitespace(true); [INFO] [stdout] 81 | Ok(self.repo.diff_tree_to_tree( [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | self.parent.map(|p| p.tree().unwrap()).as_ref(), [INFO] [stdout] 83 | | Some(&self.commit.tree()?), [INFO] [stdout] 84 | | Some(&mut diff_opts), [INFO] [stdout] 85 | | )?) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_analyzer.rs:82:33 [INFO] [stdout] | [INFO] [stdout] 82 | self.parent.map(|p| p.tree().unwrap()).as_ref(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_analyzer.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 31 | let blame = get_blame(repo, diff_delta, parent, config); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | current_hunk: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_blame.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut child = Command::new("git") [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok(GitBlame { [INFO] [stdout] | ____________^ [INFO] [stdout] 47 | | reader: RefCell::new(BufReader::new( [INFO] [stdout] 48 | | child [INFO] [stdout] 49 | | .stdout [INFO] [stdout] ... | [INFO] [stdout] 60 | | line_map: RefCell::new(HashMap::new()), [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn clone_repo<'a>(&self, mut cb: Option>>) -> Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let git_config = git2::Config::open_default()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(with_authentication(url, &git_config, |f| { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | let mut rcb = RemoteCallbacks::new(); [INFO] [stdout] 49 | | rcb.credentials(f); [INFO] [stdout] ... | [INFO] [stdout] 66 | | .clone(url, &into)?) [INFO] [stdout] 67 | | })?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 48 | let mut rcb = RemoteCallbacks::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut fo = FetchOptions::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let co = CheckoutBuilder::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | Ok(RepoBuilder::new() [INFO] [stdout] | ________________^ [INFO] [stdout] 64 | | .fetch_options(fo) [INFO] [stdout] 65 | | .with_checkout(co) [INFO] [stdout] 66 | | .clone(url, &into)?) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo_analyzer.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(repo: Repository, config: RepoConfig, parent_logger: &Logger) -> RepoAnalyzer { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | logger: parent_logger.new(o!("repo" => config.repo.name.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo_analyzer.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(AnalyzedRevwalk { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | repo: &self.repo, [INFO] [stdout] 45 | | revwalk, [INFO] [stdout] 46 | | config: &self.config, [INFO] [stdout] 47 | | opts, [INFO] [stdout] 48 | | logger: self.logger.clone(), [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 40 | let config = match WorkspaceConfig::from_dir(&dir) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(config) => config, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self::new(dir, config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config_context.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | file_config.map(|c| tags.extend(c.tags().iter().map(|s| s.to_string()))); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_analyzer.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 79 | let mut diff_opts = DiffOptions::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | diff_opts.ignore_whitespace(true); [INFO] [stdout] 81 | Ok(self.repo.diff_tree_to_tree( [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | self.parent.map(|p| p.tree().unwrap()).as_ref(), [INFO] [stdout] 83 | | Some(&self.commit.tree()?), [INFO] [stdout] 84 | | Some(&mut diff_opts), [INFO] [stdout] 85 | | )?) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_analyzer.rs:82:33 [INFO] [stdout] | [INFO] [stdout] 82 | self.parent.map(|p| p.tree().unwrap()).as_ref(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_analyzer.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 31 | let blame = get_blame(repo, diff_delta, parent, config); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | current_hunk: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_blame.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut child = Command::new("git") [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok(GitBlame { [INFO] [stdout] | ____________^ [INFO] [stdout] 47 | | reader: RefCell::new(BufReader::new( [INFO] [stdout] 48 | | child [INFO] [stdout] 49 | | .stdout [INFO] [stdout] ... | [INFO] [stdout] 60 | | line_map: RefCell::new(HashMap::new()), [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn clone_repo<'a>(&self, mut cb: Option>>) -> Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let git_config = git2::Config::open_default()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(with_authentication(url, &git_config, |f| { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | let mut rcb = RemoteCallbacks::new(); [INFO] [stdout] 49 | | rcb.credentials(f); [INFO] [stdout] ... | [INFO] [stdout] 66 | | .clone(url, &into)?) [INFO] [stdout] 67 | | })?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 48 | let mut rcb = RemoteCallbacks::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut fo = FetchOptions::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let co = CheckoutBuilder::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | Ok(RepoBuilder::new() [INFO] [stdout] | ________________^ [INFO] [stdout] 64 | | .fetch_options(fo) [INFO] [stdout] 65 | | .with_checkout(co) [INFO] [stdout] 66 | | .clone(url, &into)?) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo_analyzer.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(repo: Repository, config: RepoConfig, parent_logger: &Logger) -> RepoAnalyzer { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | logger: parent_logger.new(o!("repo" => config.repo.name.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo_analyzer.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(AnalyzedRevwalk { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | repo: &self.repo, [INFO] [stdout] 45 | | revwalk, [INFO] [stdout] 46 | | config: &self.config, [INFO] [stdout] 47 | | opts, [INFO] [stdout] 48 | | logger: self.logger.clone(), [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 40 | let config = match WorkspaceConfig::from_dir(&dir) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(config) => config, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self::new(dir, config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `codealong` (lib test) due to 11 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 10 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `codealong` (lib) due to 11 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "93eef60a2a227262482fd2c2897de8b6808e7dea628218150a00a35783f21559", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93eef60a2a227262482fd2c2897de8b6808e7dea628218150a00a35783f21559", kill_on_drop: false }` [INFO] [stdout] 93eef60a2a227262482fd2c2897de8b6808e7dea628218150a00a35783f21559