[INFO] fetching crate code-product-lib 0.4.0... [INFO] checking code-product-lib-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate code-product-lib 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate code-product-lib 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate code-product-lib 0.4.0 [INFO] finished tweaking crates.io crate code-product-lib 0.4.0 [INFO] tweaked toml for crates.io crate code-product-lib 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58bf6720221732fa62c4d7868100a8dc1748ec70633c6911b3bf9aa81cc4d288 [INFO] running `Command { std: "docker" "start" "-a" "58bf6720221732fa62c4d7868100a8dc1748ec70633c6911b3bf9aa81cc4d288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58bf6720221732fa62c4d7868100a8dc1748ec70633c6911b3bf9aa81cc4d288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58bf6720221732fa62c4d7868100a8dc1748ec70633c6911b3bf9aa81cc4d288", kill_on_drop: false }` [INFO] [stdout] 58bf6720221732fa62c4d7868100a8dc1748ec70633c6911b3bf9aa81cc4d288 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd6ca74db4c7fdc558182f2f22421abeaaf05e04ebdbe1fbcf28f7613f422152 [INFO] running `Command { std: "docker" "start" "-a" "bd6ca74db4c7fdc558182f2f22421abeaaf05e04ebdbe1fbcf28f7613f422152", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking code-product-lib v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn expand_products(input: TokenStream, mode: ScopeMode) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Product::new(input).parse(mode).expand() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/product.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 20 | fn from(inner: ProductInner) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self(Rc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/product.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(input: TokenStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | / ProductInner { [INFO] [stdout] 40 | | parent: RefCell::new(Parent::Root(TokenStream::new())), [INFO] [stdout] 41 | | entries: RefCell::new(Vec::new()), [INFO] [stdout] 42 | | input: RefCell::new(TokenIter::new(input)), [INFO] [stdout] ... | [INFO] [stdout] 45 | | linear_scope: false, [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/product.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new_product_scope(parent: &Product, input: TokenStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | / ProductInner { [INFO] [stdout] 54 | | parent: RefCell::new(Parent::ParentScope(parent.clone())), [INFO] [stdout] 55 | | entries: RefCell::new(Vec::new()), [INFO] [stdout] 56 | | input: RefCell::new(TokenIter::new(input)), [INFO] [stdout] ... | [INFO] [stdout] 59 | | linear_scope: false, [INFO] [stdout] 60 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/product.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn new_linear_scope(parent: &Product, input: TokenStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | / ProductInner { [INFO] [stdout] 67 | | parent: RefCell::new(Parent::ParentScope(parent.clone())), [INFO] [stdout] 68 | | entries: RefCell::new(Vec::new()), [INFO] [stdout] 69 | | input: RefCell::new(TokenIter::new(input)), [INFO] [stdout] ... | [INFO] [stdout] 72 | | linear_scope: true, [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(input: TokenStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Self(Rc::new(RefCell::new(input.into_iter().peekable()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token.rs:166:32 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn stream(self) -> TokenStream { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | TokenStream::from_iter(self.0.borrow_mut().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `code-product-lib` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "bd6ca74db4c7fdc558182f2f22421abeaaf05e04ebdbe1fbcf28f7613f422152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd6ca74db4c7fdc558182f2f22421abeaaf05e04ebdbe1fbcf28f7613f422152", kill_on_drop: false }` [INFO] [stdout] bd6ca74db4c7fdc558182f2f22421abeaaf05e04ebdbe1fbcf28f7613f422152