[INFO] fetching crate coap-handler-implementations 0.5.1... [INFO] checking coap-handler-implementations-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate coap-handler-implementations 0.5.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate coap-handler-implementations 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate coap-handler-implementations 0.5.1 [INFO] finished tweaking crates.io crate coap-handler-implementations 0.5.1 [INFO] tweaked toml for crates.io crate coap-handler-implementations 0.5.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding embedded-io v0.4.0 (latest: v0.6.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding minicbor v0.19.1 (latest: v0.24.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c0fe9c07360fc9728800d4559e1f1e07fa419a481ed4f8112a3fcac20a546a4 [INFO] running `Command { std: "docker" "start" "-a" "8c0fe9c07360fc9728800d4559e1f1e07fa419a481ed4f8112a3fcac20a546a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c0fe9c07360fc9728800d4559e1f1e07fa419a481ed4f8112a3fcac20a546a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c0fe9c07360fc9728800d4559e1f1e07fa419a481ed4f8112a3fcac20a546a4", kill_on_drop: false }` [INFO] [stdout] 8c0fe9c07360fc9728800d4559e1f1e07fa419a481ed4f8112a3fcac20a546a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b5968c5975430f9d409a37f10e5793c5d24134f55252b7e232387168485f38c [INFO] running `Command { std: "docker" "start" "-a" "5b5968c5975430f9d409a37f10e5793c5d24134f55252b7e232387168485f38c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling minicbor v0.19.1 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking coap-numbers v0.2.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking embedded-io v0.4.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking coap-message v0.3.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking coap-handler v0.2.0 [INFO] [stderr] Checking coap-message-utils v0.3.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking windowed-infinity v0.1.4 [INFO] [stderr] Checking coap-handler-implementations v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wkc_implementation.rs:140:86 [INFO] [stdout] | [INFO] [stdout] 140 | m.set_code(M::Code::new(code).map_err(|e| WkcBuildResponseError::Wkc(e.into()))?); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wkc_implementation.rs:152:65 [INFO] [stdout] | [INFO] [stdout] 152 | .map_err(|e| WkcBuildResponseError::Wkc(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 110 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | h1: wkc::ConstantSingleRecordReport::new(handler, attributes), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 225 | let actual_path = request.options().filter(|o| o.number() == option::URI_PATH); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | / if IterOrderByBackport::cmp_by(expected_path, actual_path, |e, a| e.cmp(a.value())) [INFO] [stdout] 229 | | == core::cmp::Ordering::Equal [INFO] [stdout] 230 | | { [INFO] [stdout] 231 | | let masked = MaskingUriUpToPath(request); [INFO] [stdout] ... | [INFO] [stdout] 242 | | ) [INFO] [stdout] 243 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:309:34 [INFO] [stdout] | [INFO] [stdout] 306 | prefixed_prefix: (H1R, &'c [&'c str]), [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | ) -> ForkingRecord, H2R> { [INFO] [stdout] 308 | let (prefixed, prefix) = prefixed_prefix; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | ForkingRecord::First(PrefixedRecord { prefix, prefixed }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:440:34 [INFO] [stdout] | [INFO] [stdout] 437 | prefixed_prefix: (H1R, &'c [&'c str]), [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | ) -> ForkingRecord, H2R> { [INFO] [stdout] 439 | let (prefixed, prefix) = prefixed_prefix; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 440 | ForkingRecord::First(PrefixedRecord { prefix, prefixed }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wkc_implementation.rs:140:86 [INFO] [stdout] | [INFO] [stdout] 140 | m.set_code(M::Code::new(code).map_err(|e| WkcBuildResponseError::Wkc(e.into()))?); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coap-handler-implementations` (lib test) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wkc_implementation.rs:152:65 [INFO] [stdout] | [INFO] [stdout] 152 | .map_err(|e| WkcBuildResponseError::Wkc(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 110 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | h1: wkc::ConstantSingleRecordReport::new(handler, attributes), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 225 | let actual_path = request.options().filter(|o| o.number() == option::URI_PATH); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | / if IterOrderByBackport::cmp_by(expected_path, actual_path, |e, a| e.cmp(a.value())) [INFO] [stdout] 229 | | == core::cmp::Ordering::Equal [INFO] [stdout] 230 | | { [INFO] [stdout] 231 | | let masked = MaskingUriUpToPath(request); [INFO] [stdout] ... | [INFO] [stdout] 242 | | ) [INFO] [stdout] 243 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:309:34 [INFO] [stdout] | [INFO] [stdout] 306 | prefixed_prefix: (H1R, &'c [&'c str]), [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | ) -> ForkingRecord, H2R> { [INFO] [stdout] 308 | let (prefixed, prefix) = prefixed_prefix; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | ForkingRecord::First(PrefixedRecord { prefix, prefixed }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forking.rs:440:34 [INFO] [stdout] | [INFO] [stdout] 437 | prefixed_prefix: (H1R, &'c [&'c str]), [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | ) -> ForkingRecord, H2R> { [INFO] [stdout] 439 | let (prefixed, prefix) = prefixed_prefix; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 440 | ForkingRecord::First(PrefixedRecord { prefix, prefixed }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coap-handler-implementations` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5b5968c5975430f9d409a37f10e5793c5d24134f55252b7e232387168485f38c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b5968c5975430f9d409a37f10e5793c5d24134f55252b7e232387168485f38c", kill_on_drop: false }` [INFO] [stdout] 5b5968c5975430f9d409a37f10e5793c5d24134f55252b7e232387168485f38c