[INFO] fetching crate cntr 1.5.3... [INFO] checking cntr-1.5.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cntr 1.5.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cntr 1.5.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cntr 1.5.3 [INFO] finished tweaking crates.io crate cntr 1.5.3 [INFO] tweaked toml for crates.io crate cntr 1.5.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cntr 1.5.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7726b3d05440ede8e612dd58d1e5013ed30c6f4f3c52c4589c654641b8ffb676 [INFO] running `Command { std: "docker" "start" "-a" "7726b3d05440ede8e612dd58d1e5013ed30c6f4f3c52c4589c654641b8ffb676", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7726b3d05440ede8e612dd58d1e5013ed30c6f4f3c52c4589c654641b8ffb676", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7726b3d05440ede8e612dd58d1e5013ed30c6f4f3c52c4589c654641b8ffb676", kill_on_drop: false }` [INFO] [stdout] 7726b3d05440ede8e612dd58d1e5013ed30c6f4f3c52c4589c654641b8ffb676 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa48eadd5a22451a38dd485663cbc814a9d04178172d8f109ac9a5e03d1cea4e [INFO] running `Command { std: "docker" "start" "-a" "fa48eadd5a22451a38dd485663cbc814a9d04178172d8f109ac9a5e03d1cea4e", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling cntr-fuse-sys v0.4.1 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking simple-error v0.3.0 [INFO] [stderr] Checking cntr-fuse-abi v0.4.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking container-pid v0.2.0 [INFO] [stderr] Checking cntr-fuse v0.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking chashmap v2.2.2 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking cntr v1.5.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `inherited_capabilities` is never read [INFO] [stdout] --> src/procfs/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct ProcStatus { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub inherited_capabilities: c_ulong, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/attach/child.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | f.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 142 | let _ = f.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 71 | fn new(fd: Fd) -> Box { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Box::new(Fh { [INFO] [stdout] | __________________^ [INFO] [stdout] 73 | | magic: FH_MAGIC, [INFO] [stdout] 74 | | fd, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn new(options: &CntrMountOptions, dotcntr: Option) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let fuse_fd = try_with!(fusefd::open(), "failed to initialize fuse"); [INFO] [stdout] | ------- ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(CntrFs { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | prefix: String::from(options.prefix), [INFO] [stdout] 202 | | root_inode: open_static_dnode(cntr_fuse::FUSE_ROOT_ID, Path::new(options.prefix))?, [INFO] [stdout] 203 | | dotcntr: Arc::new(dotcntr), [INFO] [stdout] ... | [INFO] [stdout] 214 | | effective_gid: options.effective_gid, [INFO] [stdout] 215 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:538:29 [INFO] [stdout] | [INFO] [stdout] 528 | let parent_inode = self.inode(parent)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 529 | let parent_fd = parent_inode.fd.read(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | let file = unsafe { File::from_raw_fd(fd) }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | [INFO] [stdout] 538 | self.lookup_from_fd(LookupFile::Donate(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1030:54 [INFO] [stdout] | [INFO] [stdout] 1028 | reply: cntr_fuse::ReplyDirectory, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1029 | ) { [INFO] [stdout] 1030 | self.generic_readdir(ino, fh, offset as u64, ReplyDirectory::Directory(reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1041:47 [INFO] [stdout] | [INFO] [stdout] 1039 | reply: cntr_fuse::ReplyDirectoryPlus, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1040 | ) { [INFO] [stdout] 1041 | self.generic_readdir(ino, fh, offset, ReplyDirectory::DirectoryPlus(reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ipc.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 40 | let mut files: Vec = Vec::with_capacity(1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok((msg_buf, files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mountns.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 44 | fn new(old_namespace: namespace::Namespace) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mountpoint = try_with!(tmp::tempdir(), "failed to create temporary mountpoint"); [INFO] [stdout] | ---------- ------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let temp_mountpoint = try_with!(tmp::tempdir(), "failed to create temporary mountpoint"); [INFO] [stdout] | --------------- ------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(MountNamespace { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | old_namespace, [INFO] [stdout] 66 | | mountpoint: mountpoint.into_path(), [INFO] [stdout] 67 | | temp_mountpoint: temp_mountpoint.into_path(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mountns.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 91 | let (paths, mut fds) = try_with!( [INFO] [stdout] | _________________________---____- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | | sock.receive((libc::PATH_MAX * 2) as usize, &mut cmsgspace), [INFO] [stdout] 93 | | "failed to receive mount namespace" [INFO] [stdout] 94 | | ); [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let fd = fds.pop().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | Ok(MountNamespace { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | old_namespace: namespace::MOUNT.namespace_from_file(fd), [INFO] [stdout] 102 | | mountpoint: PathBuf::from(OsStr::from_bytes(paths[0])), [INFO] [stdout] 103 | | temp_mountpoint: PathBuf::from(OsStr::from_bytes(paths[1])), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/namespace.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 45 | let file = try_with!(File::open(path), "failed to open namespace file '{}'", path); [INFO] [stdout] | ---- ----------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Ok(Namespace { kind: self, file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/pty.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 225 | stdin.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 225 | let _ = stdin.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/pty.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 226 | stdout.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 226 | let _ = stdout.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/pty.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 227 | pty_file.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 227 | let _ = pty_file.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inherited_capabilities` is never read [INFO] [stdout] --> src/procfs/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct ProcStatus { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub inherited_capabilities: c_ulong, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/attach/child.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | f.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 142 | let _ = f.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 71 | fn new(fd: Fd) -> Box { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Box::new(Fh { [INFO] [stdout] | __________________^ [INFO] [stdout] 73 | | magic: FH_MAGIC, [INFO] [stdout] 74 | | fd, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn new(options: &CntrMountOptions, dotcntr: Option) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let fuse_fd = try_with!(fusefd::open(), "failed to initialize fuse"); [INFO] [stdout] | ------- ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(CntrFs { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | prefix: String::from(options.prefix), [INFO] [stdout] 202 | | root_inode: open_static_dnode(cntr_fuse::FUSE_ROOT_ID, Path::new(options.prefix))?, [INFO] [stdout] 203 | | dotcntr: Arc::new(dotcntr), [INFO] [stdout] ... | [INFO] [stdout] 214 | | effective_gid: options.effective_gid, [INFO] [stdout] 215 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:538:29 [INFO] [stdout] | [INFO] [stdout] 528 | let parent_inode = self.inode(parent)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 529 | let parent_fd = parent_inode.fd.read(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | let file = unsafe { File::from_raw_fd(fd) }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | [INFO] [stdout] 538 | self.lookup_from_fd(LookupFile::Donate(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1030:54 [INFO] [stdout] | [INFO] [stdout] 1028 | reply: cntr_fuse::ReplyDirectory, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1029 | ) { [INFO] [stdout] 1030 | self.generic_readdir(ino, fh, offset as u64, ReplyDirectory::Directory(reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1041:47 [INFO] [stdout] | [INFO] [stdout] 1039 | reply: cntr_fuse::ReplyDirectoryPlus, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1040 | ) { [INFO] [stdout] 1041 | self.generic_readdir(ino, fh, offset, ReplyDirectory::DirectoryPlus(reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ipc.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 40 | let mut files: Vec = Vec::with_capacity(1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok((msg_buf, files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mountns.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 44 | fn new(old_namespace: namespace::Namespace) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mountpoint = try_with!(tmp::tempdir(), "failed to create temporary mountpoint"); [INFO] [stdout] | ---------- ------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let temp_mountpoint = try_with!(tmp::tempdir(), "failed to create temporary mountpoint"); [INFO] [stdout] | --------------- ------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(MountNamespace { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | old_namespace, [INFO] [stdout] 66 | | mountpoint: mountpoint.into_path(), [INFO] [stdout] 67 | | temp_mountpoint: temp_mountpoint.into_path(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mountns.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 91 | let (paths, mut fds) = try_with!( [INFO] [stdout] | _________________________---____- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | | sock.receive((libc::PATH_MAX * 2) as usize, &mut cmsgspace), [INFO] [stdout] 93 | | "failed to receive mount namespace" [INFO] [stdout] 94 | | ); [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let fd = fds.pop().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | Ok(MountNamespace { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | old_namespace: namespace::MOUNT.namespace_from_file(fd), [INFO] [stdout] 102 | | mountpoint: PathBuf::from(OsStr::from_bytes(paths[0])), [INFO] [stdout] 103 | | temp_mountpoint: PathBuf::from(OsStr::from_bytes(paths[1])), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/namespace.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 45 | let file = try_with!(File::open(path), "failed to open namespace file '{}'", path); [INFO] [stdout] | ---- ----------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Ok(Namespace { kind: self, file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/pty.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 225 | stdin.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 225 | let _ = stdin.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/pty.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 226 | stdout.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 226 | let _ = stdout.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/pty.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 227 | pty_file.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 227 | let _ = pty_file.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cntr` (lib test) due to 10 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cntr` (lib) due to 10 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fa48eadd5a22451a38dd485663cbc814a9d04178172d8f109ac9a5e03d1cea4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa48eadd5a22451a38dd485663cbc814a9d04178172d8f109ac9a5e03d1cea4e", kill_on_drop: false }` [INFO] [stdout] fa48eadd5a22451a38dd485663cbc814a9d04178172d8f109ac9a5e03d1cea4e