[INFO] fetching crate cmus-status-line 1.1.1... [INFO] checking cmus-status-line-1.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cmus-status-line 1.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate cmus-status-line 1.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cmus-status-line 1.1.1 [INFO] finished tweaking crates.io crate cmus-status-line 1.1.1 [INFO] tweaked toml for crates.io crate cmus-status-line 1.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate cmus-status-line 1.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] efb99e739c98f67c9994e19729ac7762456b0e2f146185ab1758d0cb9bc74be2 [INFO] running `Command { std: "docker" "start" "-a" "efb99e739c98f67c9994e19729ac7762456b0e2f146185ab1758d0cb9bc74be2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "efb99e739c98f67c9994e19729ac7762456b0e2f146185ab1758d0cb9bc74be2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efb99e739c98f67c9994e19729ac7762456b0e2f146185ab1758d0cb9bc74be2", kill_on_drop: false }` [INFO] [stdout] efb99e739c98f67c9994e19729ac7762456b0e2f146185ab1758d0cb9bc74be2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 186db37f513eb9a3521c0efb3a005c5be0147c6b57a8090b525c689c7f6fe225 [INFO] running `Command { std: "docker" "start" "-a" "186db37f513eb9a3521c0efb3a005c5be0147c6b57a8090b525c689c7f6fe225", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking ron v0.5.1 [INFO] [stderr] Checking toml v0.5.5 [INFO] [stderr] Checking cmus-status-line v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::CmusPlaybackStatus` [INFO] [stdout] --> src/cmus_status/data/mod.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | pub use super::CmusPlaybackStatus; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CmusTime` and `Seconds` [INFO] [stdout] --> src/cmus_status/data/mod.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | pub use super::{CmusTime, Seconds}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::CmusPlaybackStatus` [INFO] [stdout] --> src/cmus_status/data/mod.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | pub use super::CmusPlaybackStatus; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CmusTime` and `Seconds` [INFO] [stdout] --> src/cmus_status/data/mod.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | pub use super::{CmusTime, Seconds}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `settings` is never read [INFO] [stdout] --> src/cmus_status/data/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct CmusData { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 25 | settings: CmusSettings, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmusData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | let config = crate::config::get_config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / StatusOutput::builder() [INFO] [stdout] 22 | | .data(cmus_data) [INFO] [stdout] 23 | | .format(config.format) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/data/playback_status.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, PartialEq, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/data/time.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, PartialEq, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/builder.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn build(self) -> MyResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(StatusOutput { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | data: self.data.ok_or(Error::CmusStatusNoData)?, [INFO] [stdout] 23 | | format: self.format.unwrap_or_else(Default::default), [INFO] [stdout] 24 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/format/mod.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 30 | let re = [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let mut parts = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { parts }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/format/format_expression.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/format/format_part.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cmus-status-line` (lib) due to 8 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `settings` is never read [INFO] [stdout] --> src/cmus_status/data/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct CmusData { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 25 | settings: CmusSettings, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmusData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | let config = crate::config::get_config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / StatusOutput::builder() [INFO] [stdout] 22 | | .data(cmus_data) [INFO] [stdout] 23 | | .format(config.format) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/data/playback_status.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, PartialEq, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/data/time.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, PartialEq, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/builder.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn build(self) -> MyResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(StatusOutput { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | data: self.data.ok_or(Error::CmusStatusNoData)?, [INFO] [stdout] 23 | | format: self.format.unwrap_or_else(Default::default), [INFO] [stdout] 24 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/format/mod.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 30 | let re = [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let mut parts = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { parts }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/format/format_expression.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmus_status/output/format/format_part.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cmus-status-line` (lib test) due to 8 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "186db37f513eb9a3521c0efb3a005c5be0147c6b57a8090b525c689c7f6fe225", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "186db37f513eb9a3521c0efb3a005c5be0147c6b57a8090b525c689c7f6fe225", kill_on_drop: false }` [INFO] [stdout] 186db37f513eb9a3521c0efb3a005c5be0147c6b57a8090b525c689c7f6fe225