[INFO] fetching crate cmdr_macro 0.3.12... [INFO] checking cmdr_macro-0.3.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cmdr_macro 0.3.12 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cmdr_macro 0.3.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cmdr_macro 0.3.12 [INFO] finished tweaking crates.io crate cmdr_macro 0.3.12 [INFO] tweaked toml for crates.io crate cmdr_macro 0.3.12 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b4e16d24d0e0b9b0df2a25ac01e67fe94d713c33750943e4588df22aa653565 [INFO] running `Command { std: "docker" "start" "-a" "6b4e16d24d0e0b9b0df2a25ac01e67fe94d713c33750943e4588df22aa653565", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b4e16d24d0e0b9b0df2a25ac01e67fe94d713c33750943e4588df22aa653565", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b4e16d24d0e0b9b0df2a25ac01e67fe94d713c33750943e4588df22aa653565", kill_on_drop: false }` [INFO] [stdout] 6b4e16d24d0e0b9b0df2a25ac01e67fe94d713c33750943e4588df22aa653565 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ba023a0740063a70c0d7b5233221de22300dce76b364924adc881e45dc1ca32 [INFO] running `Command { std: "docker" "start" "-a" "5ba023a0740063a70c0d7b5233221de22300dce76b364924adc881e45dc1ca32", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking cmdr_macro v0.3.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/commands.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if let syn::Lit::Str(string) = name_val.lit { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 232 - if let syn::Lit::Str(string) = name_val.lit { [INFO] [stdout] 232 + if let Lit::Str(string) = name_val.lit { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/commands.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if let syn::Lit::Str(string) = name_val.lit { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 232 - if let syn::Lit::Str(string) = name_val.lit { [INFO] [stdout] 232 + if let Lit::Str(string) = name_val.lit { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commands.rs:106:24 [INFO] [stdout] | [INFO] [stdout] 106 | panic!(format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 107 | | "Wrong return type for command {}, should be CommandReult", [INFO] [stdout] 108 | | method_ident [INFO] [stdout] 109 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 106 ~ panic!( [INFO] [stdout] 107 | "Wrong return type for command {}, should be CommandReult", [INFO] [stdout] 108 | method_ident [INFO] [stdout] 109 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commands.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 126 | _ => panic!(format!( [INFO] [stdout] | _____________________^ [INFO] [stdout] 127 | | "Invalid signature for command {}, expected '&mut self, args &[String]'", [INFO] [stdout] 128 | | method_ident [INFO] [stdout] 129 | | )), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 126 ~ _ => panic!( [INFO] [stdout] 127 | "Invalid signature for command {}, expected '&mut self, args &[String]'", [INFO] [stdout] 128 | method_ident [INFO] [stdout] 129 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 29 | fn normalize_signature(sig: Signature) -> Signature { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Signature { [INFO] [stdout] 31 | inputs: sig.inputs.into_pairs().map(normalize_pair).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cmdr_macro` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commands.rs:106:24 [INFO] [stdout] | [INFO] [stdout] 106 | panic!(format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 107 | | "Wrong return type for command {}, should be CommandReult", [INFO] [stdout] 108 | | method_ident [INFO] [stdout] 109 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 106 ~ panic!( [INFO] [stdout] 107 | "Wrong return type for command {}, should be CommandReult", [INFO] [stdout] 108 | method_ident [INFO] [stdout] 109 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commands.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 126 | _ => panic!(format!( [INFO] [stdout] | _____________________^ [INFO] [stdout] 127 | | "Invalid signature for command {}, expected '&mut self, args &[String]'", [INFO] [stdout] 128 | | method_ident [INFO] [stdout] 129 | | )), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 126 ~ _ => panic!( [INFO] [stdout] 127 | "Invalid signature for command {}, expected '&mut self, args &[String]'", [INFO] [stdout] 128 | method_ident [INFO] [stdout] 129 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 29 | fn normalize_signature(sig: Signature) -> Signature { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Signature { [INFO] [stdout] 31 | inputs: sig.inputs.into_pairs().map(normalize_pair).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cmdr_macro` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5ba023a0740063a70c0d7b5233221de22300dce76b364924adc881e45dc1ca32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ba023a0740063a70c0d7b5233221de22300dce76b364924adc881e45dc1ca32", kill_on_drop: false }` [INFO] [stdout] 5ba023a0740063a70c0d7b5233221de22300dce76b364924adc881e45dc1ca32