[INFO] fetching crate cmd_lib 1.9.4... [INFO] checking cmd_lib-1.9.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cmd_lib 1.9.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cmd_lib 1.9.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cmd_lib 1.9.4 [INFO] finished tweaking crates.io crate cmd_lib 1.9.4 [INFO] tweaked toml for crates.io crate cmd_lib 1.9.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate cmd_lib 1.9.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 880f95e85d619d714c95ea0b90794ebc3113cf225b8a94390f4939c229141b06 [INFO] running `Command { std: "docker" "start" "-a" "880f95e85d619d714c95ea0b90794ebc3113cf225b8a94390f4939c229141b06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "880f95e85d619d714c95ea0b90794ebc3113cf225b8a94390f4939c229141b06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "880f95e85d619d714c95ea0b90794ebc3113cf225b8a94390f4939c229141b06", kill_on_drop: false }` [INFO] [stdout] 880f95e85d619d714c95ea0b90794ebc3113cf225b8a94390f4939c229141b06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d882bb234656c4a94f5b44ad8d0c2e08f90d3ec1daee6e127f600c0d819bede [INFO] running `Command { std: "docker" "start" "-a" "3d882bb234656c4a94f5b44ad8d0c2e08f90d3ec1daee6e127f600c0d819bede", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking faccess v0.2.4 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking byte-unit v4.0.19 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling cmd_lib_macros v1.9.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking cmd_lib v1.9.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) fn file(f: File) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Self(CmdInInner::File(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) fn pipe(p: PipeReader) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Self(CmdInInner::Pipe(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:45:69 [INFO] [stdout] | [INFO] [stdout] 45 | CmdInInner::File(file) => file.try_clone().map(|f| Self(CmdInInner::File(f))), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:46:69 [INFO] [stdout] | [INFO] [stdout] 46 | CmdInInner::Pipe(pipe) => pipe.try_clone().map(|p| Self(CmdInInner::Pipe(p))), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 83 | pub(crate) fn file(f: File) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Self(CmdOutInner::File(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 87 | pub(crate) fn pipe(p: PipeWriter) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Self(CmdOutInner::Pipe(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:94:70 [INFO] [stdout] | [INFO] [stdout] 94 | CmdOutInner::File(file) => file.try_clone().map(|f| Self(CmdOutInner::File(f))), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:95:70 [INFO] [stdout] | [INFO] [stdout] 95 | CmdOutInner::Pipe(pipe) => pipe.try_clone().map(|p| Self(CmdOutInner::Pipe(p))), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn spawn_with_output(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | self.spawn(true).map(CmdChildren::into_fun_children) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 204 | let mut children: Vec = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let len = self.cmds.len(); [INFO] [stdout] 206 | let mut prev_pipe_in = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | Ok(CmdChildren::new(children, self.ignore_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cmd_lib` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3d882bb234656c4a94f5b44ad8d0c2e08f90d3ec1daee6e127f600c0d819bede", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d882bb234656c4a94f5b44ad8d0c2e08f90d3ec1daee6e127f600c0d819bede", kill_on_drop: false }` [INFO] [stdout] 3d882bb234656c4a94f5b44ad8d0c2e08f90d3ec1daee6e127f600c0d819bede