[INFO] fetching crate cluFlock 1.2.7... [INFO] checking cluFlock-1.2.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cluFlock 1.2.7 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cluFlock 1.2.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cluFlock 1.2.7 [INFO] finished tweaking crates.io crate cluFlock 1.2.7 [INFO] tweaked toml for crates.io crate cluFlock 1.2.7 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate cluFlock 1.2.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97b737dd60d9476a8c1a14a964dcb53b9949f2a478313c45f5dd81c448ec84e5 [INFO] running `Command { std: "docker" "start" "-a" "97b737dd60d9476a8c1a14a964dcb53b9949f2a478313c45f5dd81c448ec84e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97b737dd60d9476a8c1a14a964dcb53b9949f2a478313c45f5dd81c448ec84e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97b737dd60d9476a8c1a14a964dcb53b9949f2a478313c45f5dd81c448ec84e5", kill_on_drop: false }` [INFO] [stdout] 97b737dd60d9476a8c1a14a964dcb53b9949f2a478313c45f5dd81c448ec84e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54cc1aadd5cf9540e877c4e14bfd0dd6d93641bc180376245201ae28e8828ca3 [INFO] running `Command { std: "docker" "start" "-a" "54cc1aadd5cf9540e877c4e14bfd0dd6d93641bc180376245201ae28e8828ca3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Checking cluFlock v1.2.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::os_release::unix::*` [INFO] [stdout] --> src/lib.rs:141:10 [INFO] [stdout] | [INFO] [stdout] 141 | pub use crate::os_release::unix::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::os_release::unix::*` [INFO] [stdout] --> src/lib.rs:141:10 [INFO] [stdout] | [INFO] [stdout] 141 | pub use crate::os_release::unix::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 43 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | |_| next(), // TODO +- [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 43 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 43 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:67:4 [INFO] [stdout] | [INFO] [stdout] 63 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | |_| next(), // TODO +- [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 63 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 63 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:148:3 [INFO] [stdout] | [INFO] [stdout] 144 | fn next_safe_flock, F: FnOnce(FlockLock) -> R, FE: FnOnce(FlockError) -> R, R>(data: D, flag: LibcFlag, next: F, errf: FE) -... [INFO] [stdout] | ------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / |data| { [INFO] [stdout] 149 | | let safe_flock = unsafe { [INFO] [stdout] 150 | | FlockLock::force_new(data) [INFO] [stdout] 151 | | }; [INFO] [stdout] 152 | | [INFO] [stdout] 153 | | next(safe_flock) [INFO] [stdout] 154 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 43 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | |_| next(), // TODO +- [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cluFlock` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 43 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 43 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:67:4 [INFO] [stdout] | [INFO] [stdout] 63 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | |_| next(), // TODO +- [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 63 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 63 | unsafe fn unlock_fn R, FE: FnOnce(std::io::Error) -> R, R>(&mut self, next: F, errf: FE) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | |e| errf(e.into_err()) // TODO +- [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_release/unix.rs:148:3 [INFO] [stdout] | [INFO] [stdout] 144 | fn next_safe_flock, F: FnOnce(FlockLock) -> R, FE: FnOnce(FlockError) -> R, R>(data: D, flag: LibcFlag, next: F, errf: FE) -... [INFO] [stdout] | ------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / |data| { [INFO] [stdout] 149 | | let safe_flock = unsafe { [INFO] [stdout] 150 | | FlockLock::force_new(data) [INFO] [stdout] 151 | | }; [INFO] [stdout] 152 | | [INFO] [stdout] 153 | | next(safe_flock) [INFO] [stdout] 154 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cluFlock` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "54cc1aadd5cf9540e877c4e14bfd0dd6d93641bc180376245201ae28e8828ca3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54cc1aadd5cf9540e877c4e14bfd0dd6d93641bc180376245201ae28e8828ca3", kill_on_drop: false }` [INFO] [stdout] 54cc1aadd5cf9540e877c4e14bfd0dd6d93641bc180376245201ae28e8828ca3