[INFO] fetching crate cloud-mmr 0.1.0... [INFO] checking cloud-mmr-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cloud-mmr 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate cloud-mmr 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cloud-mmr 0.1.0 [INFO] finished tweaking crates.io crate cloud-mmr 0.1.0 [INFO] tweaked toml for crates.io crate cloud-mmr 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 105 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.56.0 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v0.9.1 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cexpr v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding croaring v0.4.6 (latest: v2.0.3) [INFO] [stderr] Adding croaring-sys v0.4.6 (latest: v4.1.1) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding libsm v0.5.1 (latest: v0.6.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding shlex v0.1.1 (latest: v1.3.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v3.1.1 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0206b9626a629ae8ced4e3f8e2e13c824dda3f2c282c663cdd51007b5387e569 [INFO] running `Command { std: "docker" "start" "-a" "0206b9626a629ae8ced4e3f8e2e13c824dda3f2c282c663cdd51007b5387e569", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0206b9626a629ae8ced4e3f8e2e13c824dda3f2c282c663cdd51007b5387e569", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0206b9626a629ae8ced4e3f8e2e13c824dda3f2c282c663cdd51007b5387e569", kill_on_drop: false }` [INFO] [stdout] 0206b9626a629ae8ced4e3f8e2e13c824dda3f2c282c663cdd51007b5387e569 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 719a99b22068703f7f0a1f0eb34993b40212ab6d51494b5c0f56bee9c9efad4d [INFO] running `Command { std: "docker" "start" "-a" "719a99b22068703f7f0a1f0eb34993b40212ab6d51494b5c0f56bee9c9efad4d", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling bindgen v0.56.0 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking supercow v0.1.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling liblmdb-sys v0.2.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking libsm v0.5.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking lmdb-zero v0.4.4 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling env_logger v0.8.4 [INFO] [stderr] Compiling croaring-sys v0.4.6 [INFO] [stderr] Checking croaring v0.4.6 [INFO] [stderr] Checking cloud-mmr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn read_bitmap>(file_path: P) -> io::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let mut bitmap_file = File::open(file_path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok(Bitmap::deserialize(&buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/leaf_set.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn open>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let file_path = path.as_ref(); [INFO] [stdout] 38 | let bitmap = if file_path.exists() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(LeafSet { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | path: file_path.to_path_buf(), [INFO] [stdout] 54 | | bitmap_bak: bitmap.clone(), [INFO] [stdout] 55 | | bitmap, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/leaf_set.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 107 | let mut bitmap = self.bitmap.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / bitmap [INFO] [stdout] 120 | | .flip(1..(cutoff_pos + 1)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/leaf_set.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 107 | let mut bitmap = self.bitmap.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | .and(&self.unpruned_pre_cutoff(cutoff_pos, prune_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:309:12 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn iter(&self, prefix: &[u8], deserialize: F) -> Result, Error> [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let lock = self.db.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | let tx = Arc::new(lmdb::ReadTransaction::new(self.env.clone())?); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | let cursor = Arc::new(tx.cursor(db.clone())?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | Ok(PrefixIterator::new(tx, cursor, prefix, deserialize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:319:12 [INFO] [stdout] | [INFO] [stdout] 318 | let tx = lmdb::WriteTransaction::new(self.env.clone())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | Ok(Batch { store: self, tx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:475:9 [INFO] [stdout] | [INFO] [stdout] 467 | let access = self.tx.access(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 475 | / kv.ok() [INFO] [stdout] 476 | | .filter(|(k, _)| k.starts_with(self.prefix.as_slice())) [INFO] [stdout] 477 | | .map(|(k, v)| match (self.deserialize)(k, v) { [INFO] [stdout] 478 | | Ok(v) => Some(v), [INFO] [stdout] 479 | | Err(_) => None, [INFO] [stdout] 480 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:477:33 [INFO] [stdout] | [INFO] [stdout] 477 | .map(|(k, v)| match (self.deserialize)(k, v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/pmmr.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 248 | data_dir: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let size_info = if let Some(fixed_size) = T::elmt_size() { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let hash_size_info = SizeInfo::FixedSize(Hash::LEN.try_into().unwrap()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | [INFO] [stdout] 269 | let hash_file = DataFile::open(&data_dir.join(PMMR_HASH_FILE), hash_size_info, version)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let data_file = DataFile::open(&data_dir.join(PMMR_DATA_FILE), size_info, version)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let leaf_set = LeafSet::open(&leaf_set_path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | let prune_list = PruneList::open(&data_dir.join(PMMR_PRUN_FILE))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | [INFO] [stdout] 277 | Ok(PMMRBackend { [INFO] [stdout] | ____________^ [INFO] [stdout] 278 | | data_dir: data_dir.to_path_buf(), [INFO] [stdout] 279 | | prunable, [INFO] [stdout] 280 | | hash_file, [INFO] [stdout] ... | [INFO] [stdout] 283 | | prune_list, [INFO] [stdout] 284 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/pmmr.rs:458:26 [INFO] [stdout] | [INFO] [stdout] 430 | let mut expanded = Bitmap::create(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | [INFO] [stdout] 432 | let leaf_pos_to_rm = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | (leaf_pos_to_rm, removed_excl_roots(&expanded)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/types.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 81 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | size_info: SizeInfo, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(DataFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | file: AppendOnlyFile::open(path, size_info, version)?, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/types.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | ser::deserialize(&mut &data[..], self.version, DeserializationMode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pmmr/segment.rs:544:12 [INFO] [stdout] | [INFO] [stdout] 537 | let mut leaf_data = Vec::::with_capacity(n_leaves); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 544 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 545 | | identifier, [INFO] [stdout] 546 | | hash_pos, [INFO] [stdout] 547 | | hashes, [INFO] [stdout] ... | [INFO] [stdout] 550 | | proof, [INFO] [stdout] 551 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:1147:19 [INFO] [stdout] | [INFO] [stdout] 1143 | fn visit_enum(self, data: A) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1147 | match match serde::de::EnumAccess::variant(data) { [INFO] [stdout] | ___________________^ [INFO] [stdout] 1148 | | Ok(val) => val, [INFO] [stdout] 1149 | | Err(err) => { [INFO] [stdout] 1150 | | return Err(err); [INFO] [stdout] 1151 | | } [INFO] [stdout] 1152 | | } { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cloud-mmr` (lib test) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn read_bitmap>(file_path: P) -> io::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let mut bitmap_file = File::open(file_path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok(Bitmap::deserialize(&buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/leaf_set.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn open>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let file_path = path.as_ref(); [INFO] [stdout] 38 | let bitmap = if file_path.exists() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(LeafSet { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | path: file_path.to_path_buf(), [INFO] [stdout] 54 | | bitmap_bak: bitmap.clone(), [INFO] [stdout] 55 | | bitmap, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/leaf_set.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 107 | let mut bitmap = self.bitmap.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / bitmap [INFO] [stdout] 120 | | .flip(1..(cutoff_pos + 1)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/leaf_set.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 107 | let mut bitmap = self.bitmap.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | .and(&self.unpruned_pre_cutoff(cutoff_pos, prune_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:309:12 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn iter(&self, prefix: &[u8], deserialize: F) -> Result, Error> [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let lock = self.db.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | let tx = Arc::new(lmdb::ReadTransaction::new(self.env.clone())?); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | let cursor = Arc::new(tx.cursor(db.clone())?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | Ok(PrefixIterator::new(tx, cursor, prefix, deserialize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:319:12 [INFO] [stdout] | [INFO] [stdout] 318 | let tx = lmdb::WriteTransaction::new(self.env.clone())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | Ok(Batch { store: self, tx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:475:9 [INFO] [stdout] | [INFO] [stdout] 467 | let access = self.tx.access(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 475 | / kv.ok() [INFO] [stdout] 476 | | .filter(|(k, _)| k.starts_with(self.prefix.as_slice())) [INFO] [stdout] 477 | | .map(|(k, v)| match (self.deserialize)(k, v) { [INFO] [stdout] 478 | | Ok(v) => Some(v), [INFO] [stdout] 479 | | Err(_) => None, [INFO] [stdout] 480 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/lmdb.rs:477:33 [INFO] [stdout] | [INFO] [stdout] 477 | .map(|(k, v)| match (self.deserialize)(k, v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/pmmr.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 248 | data_dir: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let size_info = if let Some(fixed_size) = T::elmt_size() { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let hash_size_info = SizeInfo::FixedSize(Hash::LEN.try_into().unwrap()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | [INFO] [stdout] 269 | let hash_file = DataFile::open(&data_dir.join(PMMR_HASH_FILE), hash_size_info, version)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let data_file = DataFile::open(&data_dir.join(PMMR_DATA_FILE), size_info, version)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let leaf_set = LeafSet::open(&leaf_set_path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | let prune_list = PruneList::open(&data_dir.join(PMMR_PRUN_FILE))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | [INFO] [stdout] 277 | Ok(PMMRBackend { [INFO] [stdout] | ____________^ [INFO] [stdout] 278 | | data_dir: data_dir.to_path_buf(), [INFO] [stdout] 279 | | prunable, [INFO] [stdout] 280 | | hash_file, [INFO] [stdout] ... | [INFO] [stdout] 283 | | prune_list, [INFO] [stdout] 284 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/pmmr.rs:458:26 [INFO] [stdout] | [INFO] [stdout] 430 | let mut expanded = Bitmap::create(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | [INFO] [stdout] 432 | let leaf_pos_to_rm = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | (leaf_pos_to_rm, removed_excl_roots(&expanded)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/types.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 81 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | size_info: SizeInfo, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(DataFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | file: AppendOnlyFile::open(path, size_info, version)?, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/types.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | ser::deserialize(&mut &data[..], self.version, DeserializationMode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pmmr/segment.rs:544:12 [INFO] [stdout] | [INFO] [stdout] 537 | let mut leaf_data = Vec::::with_capacity(n_leaves); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 544 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 545 | | identifier, [INFO] [stdout] 546 | | hash_pos, [INFO] [stdout] 547 | | hashes, [INFO] [stdout] ... | [INFO] [stdout] 550 | | proof, [INFO] [stdout] 551 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:1147:19 [INFO] [stdout] | [INFO] [stdout] 1143 | fn visit_enum(self, data: A) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1147 | match match serde::de::EnumAccess::variant(data) { [INFO] [stdout] | ___________________^ [INFO] [stdout] 1148 | | Ok(val) => val, [INFO] [stdout] 1149 | | Err(err) => { [INFO] [stdout] 1150 | | return Err(err); [INFO] [stdout] 1151 | | } [INFO] [stdout] 1152 | | } { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cloud-mmr` (lib) due to 15 previous errors [INFO] running `Command { std: "docker" "inspect" "719a99b22068703f7f0a1f0eb34993b40212ab6d51494b5c0f56bee9c9efad4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "719a99b22068703f7f0a1f0eb34993b40212ab6d51494b5c0f56bee9c9efad4d", kill_on_drop: false }` [INFO] [stdout] 719a99b22068703f7f0a1f0eb34993b40212ab6d51494b5c0f56bee9c9efad4d