[INFO] fetching crate clock-bound-d 1.0.0... [INFO] checking clock-bound-d-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate clock-bound-d 1.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate clock-bound-d 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clock-bound-d 1.0.0 [INFO] finished tweaking crates.io crate clock-bound-d 1.0.0 [INFO] tweaked toml for crates.io crate clock-bound-d 1.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate clock-bound-d 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a4881d32bfe1dff3d7e1ae1301e93f6f88881e097a3a589697a5818882a48159 [INFO] running `Command { std: "docker" "start" "-a" "a4881d32bfe1dff3d7e1ae1301e93f6f88881e097a3a589697a5818882a48159", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a4881d32bfe1dff3d7e1ae1301e93f6f88881e097a3a589697a5818882a48159", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4881d32bfe1dff3d7e1ae1301e93f6f88881e097a3a589697a5818882a48159", kill_on_drop: false }` [INFO] [stdout] a4881d32bfe1dff3d7e1ae1301e93f6f88881e097a3a589697a5818882a48159 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c5f4ec7d60357f95996e08c0a945a609fa941ef2a664438797db5a4597660b5 [INFO] running `Command { std: "docker" "start" "-a" "8c5f4ec7d60357f95996e08c0a945a609fa941ef2a664438797db5a4597660b5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling indexmap v2.2.3 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking errno v0.3.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Compiling chrony-candm-derive v0.1.0 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking clock-bound-shm v1.0.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking chrony-candm v0.1.1 [INFO] [stderr] Checking clock-bound-d v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channels.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new_channel_web(channel_ids: Vec) -> (MailBox, DispatchBox) [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut mailbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut dispatchbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | MailBox { channels: mailbox }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channels.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new_channel_web(channel_ids: Vec) -> (MailBox, DispatchBox) [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut mailbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut dispatchbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / DispatchBox { [INFO] [stdout] 33 | | channels: dispatchbox, [INFO] [stdout] 34 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shm_writer.rs:55:30 [INFO] [stdout] | [INFO] [stdout] 52 | fn new(writer: W, max_drift_ppb: u32) -> ShmUpdater { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | shm_clock_state: Box::::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:133:11 [INFO] [stdout] | [INFO] [stdout] 129 | let mut handlers = SIGNAL_HANDLERS.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | match enable_signal(sig) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clock-bound-d` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channels.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new_channel_web(channel_ids: Vec) -> (MailBox, DispatchBox) [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut mailbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut dispatchbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | MailBox { channels: mailbox }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channels.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new_channel_web(channel_ids: Vec) -> (MailBox, DispatchBox) [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut mailbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut dispatchbox = HashMap::with_capacity(channel_ids.len()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / DispatchBox { [INFO] [stdout] 33 | | channels: dispatchbox, [INFO] [stdout] 34 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chrony_poller.rs:574:15 [INFO] [stdout] | [INFO] [stdout] 569 | let mut test_phc_error_bound_file = std::fs::File::create(phc_error_bound_path) [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 574 | match std::panic::catch_unwind(|| { [INFO] [stdout] | _______________^ [INFO] [stdout] 575 | | get_phc_error_bound_from_path(&std::path::PathBuf::from(phc_error_bound_path)) [INFO] [stdout] 576 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shm_writer.rs:55:30 [INFO] [stdout] | [INFO] [stdout] 52 | fn new(writer: W, max_drift_ppb: u32) -> ShmUpdater { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | shm_clock_state: Box::::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shm_writer.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 303 | let (mut mboxes, dbox) = [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | new_channel_web(vec![ChannelId::ClockErrorBoundPoller, ChannelId::ShmWriter]); [INFO] [stdout] 305 | let mbox = mboxes.get_mailbox(&ChannelId::ShmWriter).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | ( [INFO] [stdout] 307 | / Context { [INFO] [stdout] 308 | | mbox, [INFO] [stdout] 309 | | dbox, [INFO] [stdout] 310 | | channel_id: ChannelId::ShmWriter, [INFO] [stdout] 311 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:133:11 [INFO] [stdout] | [INFO] [stdout] 129 | let mut handlers = SIGNAL_HANDLERS.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | match enable_signal(sig) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clock-bound-d` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "8c5f4ec7d60357f95996e08c0a945a609fa941ef2a664438797db5a4597660b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c5f4ec7d60357f95996e08c0a945a609fa941ef2a664438797db5a4597660b5", kill_on_drop: false }` [INFO] [stdout] 8c5f4ec7d60357f95996e08c0a945a609fa941ef2a664438797db5a4597660b5