[INFO] fetching crate cln-rpc 0.1.9... [INFO] checking cln-rpc-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cln-rpc 0.1.9 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cln-rpc 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cln-rpc 0.1.9 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate cln-rpc 0.1.9 [INFO] tweaked toml for crates.io crate cln-rpc 0.1.9 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cln-rpc 0.1.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1624ced0377b83d6198868160154fcb02774542fa2e35750f1af65d2cb125c3 [INFO] running `Command { std: "docker" "start" "-a" "d1624ced0377b83d6198868160154fcb02774542fa2e35750f1af65d2cb125c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1624ced0377b83d6198868160154fcb02774542fa2e35750f1af65d2cb125c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1624ced0377b83d6198868160154fcb02774542fa2e35750f1af65d2cb125c3", kill_on_drop: false }` [INFO] [stdout] d1624ced0377b83d6198868160154fcb02774542fa2e35750f1af65d2cb125c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 183b96d52b98483ebc8c70152830566e1b6da1ca5484b298f4d9b2eeb7e4e439 [INFO] running `Command { std: "docker" "start" "-a" "183b96d52b98483ebc8c70152830566e1b6da1ca5484b298f4d9b2eeb7e4e439", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling bitcoin-private v0.1.0 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling rustix v0.38.14 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling bitcoin v0.30.1 [INFO] [stderr] Checking linux-raw-sys v0.4.7 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Compiling secp256k1-sys v0.8.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-test v0.4.3 [INFO] [stderr] Checking bitcoin_hashes v0.12.0 [INFO] [stderr] Checking secp256k1 v0.27.0 [INFO] [stderr] Checking cln-rpc v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `JsonRpcCodec` is never constructed [INFO] [stdout] --> src/codec.rs:109:19 [INFO] [stdout] | [INFO] [stdout] 109 | pub(crate) struct JsonRpcCodec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `JsonRpcCodec` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 130 | fn from_stream(stream: UnixStream) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let (read, write) = stream.into_split(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | Ok(ClnRpc { [INFO] [stdout] | ____________^ [INFO] [stdout] 134 | | next_id: AtomicUsize::new(1), [INFO] [stdout] 135 | | read: FramedRead::new(read, JsonCodec::default()), [INFO] [stdout] 136 | | write: FramedWrite::new(write, JsonCodec::default()), [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JsonRpcCodec` is never constructed [INFO] [stdout] --> src/codec.rs:109:19 [INFO] [stdout] | [INFO] [stdout] 109 | pub(crate) struct JsonRpcCodec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `JsonRpcCodec` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 130 | fn from_stream(stream: UnixStream) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let (read, write) = stream.into_split(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | Ok(ClnRpc { [INFO] [stdout] | ____________^ [INFO] [stdout] 134 | | next_id: AtomicUsize::new(1), [INFO] [stdout] 135 | | read: FramedRead::new(read, JsonCodec::default()), [INFO] [stdout] 136 | | write: FramedWrite::new(write, JsonCodec::default()), [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:369:89 [INFO] [stdout] | [INFO] [stdout] 349 | let mut cln = ClnRpc::from_stream(uds1).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | let handle = tokio::task::spawn(async move { cln.call_raw_request(rpc_request2).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:430:68 [INFO] [stdout] | [INFO] [stdout] 407 | let mut cln = ClnRpc::from_stream(uds1).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 430 | let handle = tokio::task::spawn(async move { cln.call(req).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:469:68 [INFO] [stdout] | [INFO] [stdout] 449 | let mut cln = ClnRpc::from_stream(uds1).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | let handle = tokio::task::spawn(async move { cln.call(req).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:514:75 [INFO] [stdout] | [INFO] [stdout] 494 | let mut cln = ClnRpc::from_stream(uds1).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 514 | let handle = tokio::task::spawn(async move { cln.call_typed(&req).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:546:75 [INFO] [stdout] | [INFO] [stdout] 541 | let mut cln = ClnRpc::from_stream(uds1).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | let handle = tokio::task::spawn(async move { cln.call_typed(&req).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cln-rpc` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cln-rpc` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "183b96d52b98483ebc8c70152830566e1b6da1ca5484b298f4d9b2eeb7e4e439", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "183b96d52b98483ebc8c70152830566e1b6da1ca5484b298f4d9b2eeb7e4e439", kill_on_drop: false }` [INFO] [stdout] 183b96d52b98483ebc8c70152830566e1b6da1ca5484b298f4d9b2eeb7e4e439