[INFO] fetching crate clineup 0.2.5... [INFO] checking clineup-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate clineup 0.2.5 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate clineup 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clineup 0.2.5 [INFO] finished tweaking crates.io crate clineup 0.2.5 [INFO] tweaked toml for crates.io crate clineup 0.2.5 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate clineup 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f16ef04a621640a7675f15d9a75f18d9e3d9b3da03d20453644562e620097842 [INFO] running `Command { std: "docker" "start" "-a" "f16ef04a621640a7675f15d9a75f18d9e3d9b3da03d20453644562e620097842", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f16ef04a621640a7675f15d9a75f18d9e3d9b3da03d20453644562e620097842", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f16ef04a621640a7675f15d9a75f18d9e3d9b3da03d20453644562e620097842", kill_on_drop: false }` [INFO] [stdout] f16ef04a621640a7675f15d9a75f18d9e3d9b3da03d20453644562e620097842 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a01992cb191b5541d5f874befb25ab72e8a24e1e3b81b81afe45633e1eef14d3 [INFO] running `Command { std: "docker" "start" "-a" "a01992cb191b5541d5f874befb25ab72e8a24e1e3b81b81afe45633e1eef14d3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling openssl v0.10.60 [INFO] [stderr] Checking tokio v1.34.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling openssl-sys v0.9.96 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling rustix v0.38.26 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling portable-atomic v1.5.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking mutate_once v0.1.1 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking kamadak-exif v0.5.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking path-clean v1.0.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking bstr v1.8.0 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking predicates v3.0.4 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking h2 v0.3.22 [INFO] [stderr] Checking thiserror v1.0.50 [INFO] [stderr] Checking serde v1.0.193 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.108 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stderr] Checking clineup v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `log::debug` [INFO] [stdout] --> src/gps/nominatim.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use log::debug; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::info` [INFO] [stdout] --> src/path/formatter.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use log::info; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clean` [INFO] [stdout] --> src/utils.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | use path_clean::{clean, PathClean}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::debug` [INFO] [stdout] --> src/gps/nominatim.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use log::debug; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::info` [INFO] [stdout] --> src/path/formatter.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use log::info; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clean` [INFO] [stdout] --> src/utils.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | use path_clean::{clean, PathClean}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 184 | let re = Regex::new(r"(?P[0-9]+)(?P[KMGTP]?)[Bo]?")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Err(ClineupError::InvalidSizeFormat(size.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gps/nominatim.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | let client = reqwest::blocking::Client::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / client [INFO] [stdout] 35 | | .get(self.url.clone()) [INFO] [stdout] 36 | | .query(&[ [INFO] [stdout] 37 | | ("lat", lat.to_string()), [INFO] [stdout] ... | [INFO] [stdout] 42 | | .header("User-Agent", self.email.clone()) [INFO] [stdout] 43 | | .send() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gps/nominatim.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 103 | let response = self.provider.get_response(lat, lon)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Err(ClineupError::HttpFailedCodeError(status.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gps/nominatim.rs:250:21 [INFO] [stdout] | [INFO] [stdout] 249 | let io_error = std::io::Error::new(std::io::ErrorKind::Other, error_message); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | Err(ClineupError::IoError(io_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 184 | let re = Regex::new(r"(?P[0-9]+)(?P[KMGTP]?)[Bo]?")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Err(ClineupError::InvalidSizeFormat(size.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gps/nominatim.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | let client = reqwest::blocking::Client::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / client [INFO] [stdout] 35 | | .get(self.url.clone()) [INFO] [stdout] 36 | | .query(&[ [INFO] [stdout] 37 | | ("lat", lat.to_string()), [INFO] [stdout] ... | [INFO] [stdout] 42 | | .header("User-Agent", self.email.clone()) [INFO] [stdout] 43 | | .send() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gps/nominatim.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 103 | let response = self.provider.get_response(lat, lon)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Err(ClineupError::HttpFailedCodeError(status.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clineup` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `clineup` (lib) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a01992cb191b5541d5f874befb25ab72e8a24e1e3b81b81afe45633e1eef14d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a01992cb191b5541d5f874befb25ab72e8a24e1e3b81b81afe45633e1eef14d3", kill_on_drop: false }` [INFO] [stdout] a01992cb191b5541d5f874befb25ab72e8a24e1e3b81b81afe45633e1eef14d3