[INFO] fetching crate clicsv 0.1.4... [INFO] checking clicsv-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate clicsv 0.1.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate clicsv 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clicsv 0.1.4 [INFO] finished tweaking crates.io crate clicsv 0.1.4 [INFO] tweaked toml for crates.io crate clicsv 0.1.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate clicsv 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7ab0b4cba4e141166103898d9b5aedd20f62668155ceb1d1c1b0dd3e0c2c740 [INFO] running `Command { std: "docker" "start" "-a" "e7ab0b4cba4e141166103898d9b5aedd20f62668155ceb1d1c1b0dd3e0c2c740", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7ab0b4cba4e141166103898d9b5aedd20f62668155ceb1d1c1b0dd3e0c2c740", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7ab0b4cba4e141166103898d9b5aedd20f62668155ceb1d1c1b0dd3e0c2c740", kill_on_drop: false }` [INFO] [stdout] e7ab0b4cba4e141166103898d9b5aedd20f62668155ceb1d1c1b0dd3e0c2c740 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e66066aa04594b3ae87dfd22a29bbbe40b9f52965107a82fc6ee8be52332a3e4 [INFO] running `Command { std: "docker" "start" "-a" "e66066aa04594b3ae87dfd22a29bbbe40b9f52965107a82fc6ee8be52332a3e4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.106 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking clicsv v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/editor.rs:206:28 [INFO] [stdout] | [INFO] [stdout] 206 | | Key::Home => (self.move_position(pressed_key)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - | Key::Home => (self.move_position(pressed_key)), [INFO] [stdout] 206 + | Key::Home => self.move_position(pressed_key), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/editor.rs:206:28 [INFO] [stdout] | [INFO] [stdout] 206 | | Key::Home => (self.move_position(pressed_key)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - | Key::Home => (self.move_position(pressed_key)), [INFO] [stdout] 206 + | Key::Home => self.move_position(pressed_key), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/editor.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | let mut offset = &mut self.offset; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:99:23 [INFO] [stdout] | [INFO] [stdout] 77 | let doc = Document::open(file_name); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | terminal: Terminal::default().expect("Failed to init terminal"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | Ok(Self [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | { [INFO] [stdout] 27 | | size: Size [INFO] [stdout] 28 | | { [INFO] [stdout] ... | [INFO] [stdout] 32 | | _stdout: stdout().into_raw_mode()?, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clicsv` (bin "clicsv" test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/editor.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | let mut offset = &mut self.offset; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:99:23 [INFO] [stdout] | [INFO] [stdout] 77 | let doc = Document::open(file_name); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | terminal: Terminal::default().expect("Failed to init terminal"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | Ok(Self [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | { [INFO] [stdout] 27 | | size: Size [INFO] [stdout] 28 | | { [INFO] [stdout] ... | [INFO] [stdout] 32 | | _stdout: stdout().into_raw_mode()?, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clicsv` (bin "clicsv") due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e66066aa04594b3ae87dfd22a29bbbe40b9f52965107a82fc6ee8be52332a3e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e66066aa04594b3ae87dfd22a29bbbe40b9f52965107a82fc6ee8be52332a3e4", kill_on_drop: false }` [INFO] [stdout] e66066aa04594b3ae87dfd22a29bbbe40b9f52965107a82fc6ee8be52332a3e4