[INFO] fetching crate clickhouse-driver 0.1.0-alpha.3... [INFO] checking clickhouse-driver-0.1.0-alpha.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate clickhouse-driver 0.1.0-alpha.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate clickhouse-driver 0.1.0-alpha.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clickhouse-driver 0.1.0-alpha.3 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate clickhouse-driver 0.1.0-alpha.3 [INFO] tweaked toml for crates.io crate clickhouse-driver 0.1.0-alpha.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate clickhouse-driver 0.1.0-alpha.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd5f91c867e12d9e5a3e1193850e6fdd7dcf84b0aaf326fe43b34f1d54a24437 [INFO] running `Command { std: "docker" "start" "-a" "dd5f91c867e12d9e5a3e1193850e6fdd7dcf84b0aaf326fe43b34f1d54a24437", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd5f91c867e12d9e5a3e1193850e6fdd7dcf84b0aaf326fe43b34f1d54a24437", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd5f91c867e12d9e5a3e1193850e6fdd7dcf84b0aaf326fe43b34f1d54a24437", kill_on_drop: false }` [INFO] [stdout] dd5f91c867e12d9e5a3e1193850e6fdd7dcf84b0aaf326fe43b34f1d54a24437 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 857cd0621fc2370dec83388f424c4795020acdf90f4e0c8314a1a3f7ed51da6a [INFO] running `Command { std: "docker" "start" "-a" "857cd0621fc2370dec83388f424c4795020acdf90f4e0c8314a1a3f7ed51da6a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.38 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling pin-project-internal v0.4.23 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling regex-syntax v0.6.18 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking futures-sink v0.3.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Compiling cc v1.0.58 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking tinyvec v0.3.3 [INFO] [stderr] Checking futures-io v0.3.5 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling regex v1.3.9 [INFO] [stderr] Checking unicode-normalization v0.1.13 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking smallvec v1.4.1 [INFO] [stderr] Compiling clickhouse-driver-lz4 v0.1.0 [INFO] [stderr] Checking instant v0.1.6 [INFO] [stderr] Checking chrono v0.4.13 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking parking_lot_core v0.8.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.4.3 [INFO] [stderr] Checking lock_api v0.4.1 [INFO] [stderr] Compiling chrono-tz v0.5.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking parking_lot v0.11.0 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking clickhouse-driver-cthrs v0.1.1 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Checking tokio v0.2.22 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking pin-project v0.4.23 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking futures v0.3.5 [INFO] [stderr] Checking clickhouse-driver v0.1.0-alpha.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `lz4` [INFO] [stdout] --> src/lib.rs:52:7 [INFO] [stdout] | [INFO] [stdout] 52 | #[cfg(lz4)] [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(lz4)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(lz4)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LZ4_compress_default` [INFO] [stdout] --> src/compression/mod.rs:14:55 [INFO] [stdout] | [INFO] [stdout] 14 | LZ4_Compress, LZ4_CompressBounds, LZ4_Decompress, LZ4_compress_default, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rustc_nightly` [INFO] [stdout] --> src/protocol/mod.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | #[cfg(rustc_nightly)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rustc_nightly)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rustc_nightly)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `is_sorted` [INFO] [stdout] --> src/protocol/column.rs:554:11 [INFO] [stdout] | [INFO] [stdout] 554 | #[cfg(feature = "is_sorted")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cityhash`, `cityhash_rs`, `clickhouse-driver-cth`, `clickhouse-driver-cthrs`, `default`, `extra`, `int128`, `recycle`, `tls`, and `tokio-native-tls` [INFO] [stdout] = help: consider adding `is_sorted` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `is_sorted` [INFO] [stdout] --> src/protocol/column.rs:558:15 [INFO] [stdout] | [INFO] [stdout] 558 | #[cfg(not(feature = "is_sorted"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cityhash`, `cityhash_rs`, `clickhouse-driver-cth`, `clickhouse-driver-cthrs`, `default`, `extra`, `int128`, `recycle`, `tls`, and `tokio-native-tls` [INFO] [stdout] = help: consider adding `is_sorted` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ValueDateTime64`, `ValueDateTime`, `ValueDate`, `ValueIp4`, `ValueIp6`, and `ValueUuid` [INFO] [stdout] --> src/types/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | ValueDate, ValueDateTime, ValueDateTime64, ValueDecimal32, ValueDecimal64, ValueIp4, ValueIp6, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^ [INFO] [stdout] 5 | ValueUuid, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/types/parser.rs:287:6 [INFO] [stdout] | [INFO] [stdout] 287 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `lz4` [INFO] [stdout] --> src/lib.rs:52:7 [INFO] [stdout] | [INFO] [stdout] 52 | #[cfg(lz4)] [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(lz4)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(lz4)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LZ4_compress_default` [INFO] [stdout] --> src/compression/mod.rs:14:55 [INFO] [stdout] | [INFO] [stdout] 14 | LZ4_Compress, LZ4_CompressBounds, LZ4_Decompress, LZ4_compress_default, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rustc_nightly` [INFO] [stdout] --> src/protocol/mod.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | #[cfg(rustc_nightly)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rustc_nightly)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rustc_nightly)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `is_sorted` [INFO] [stdout] --> src/protocol/column.rs:554:11 [INFO] [stdout] | [INFO] [stdout] 554 | #[cfg(feature = "is_sorted")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cityhash`, `cityhash_rs`, `clickhouse-driver-cth`, `clickhouse-driver-cthrs`, `default`, `extra`, `int128`, `recycle`, `tls`, and `tokio-native-tls` [INFO] [stdout] = help: consider adding `is_sorted` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `is_sorted` [INFO] [stdout] --> src/protocol/column.rs:558:15 [INFO] [stdout] | [INFO] [stdout] 558 | #[cfg(not(feature = "is_sorted"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cityhash`, `cityhash_rs`, `clickhouse-driver-cth`, `clickhouse-driver-cthrs`, `default`, `extra`, `int128`, `recycle`, `tls`, and `tokio-native-tls` [INFO] [stdout] = help: consider adding `is_sorted` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ValueDateTime64`, `ValueDateTime`, `ValueDate`, `ValueIp4`, `ValueIp6`, and `ValueUuid` [INFO] [stdout] --> src/types/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | ValueDate, ValueDateTime, ValueDateTime64, ValueDecimal32, ValueDecimal64, ValueIp4, ValueIp6, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^ [INFO] [stdout] 5 | ValueUuid, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/types/parser.rs:287:6 [INFO] [stdout] | [INFO] [stdout] 287 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sync/waker_set.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | let mut inner = &mut *self.lock(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `timezone` is never read [INFO] [stdout] --> src/protocol/block.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 226 | pub struct ServerBlock { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 229 | pub(crate) timezone: Tz, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServerBlock` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Command` is never used [INFO] [stdout] --> src/protocol/packet.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) trait Command: ServerWriter {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cancel` is never constructed [INFO] [stdout] --> src/protocol/packet.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) struct Cancel; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:135:37 [INFO] [stdout] | [INFO] [stdout] 135 | .map_or(false, |socket| socket.peer_addr().is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:260:19 [INFO] [stdout] | [INFO] [stdout] 257 | pub(super) fn new(pool: Pool, mut conn: Box) -> Connection { [INFO] [stdout] | ---------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:447:50 [INFO] [stdout] | [INFO] [stdout] 445 | pub(crate) fn disconnect(mut conn: Box) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | if let Ok(handle) = tokio::runtime::Handle::try_current() { [INFO] [stdout] 447 | handle.spawn(async move { conn.cleanup().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression/mod.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | Poll::Ready(Ok(toread)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/options.rs:88:11 [INFO] [stdout] | [INFO] [stdout] 84 | fn parse_param<'a, F, T, E>(param: Cow<'a, str>, value: Cow<'a, str>, parse: F) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | match parse(value.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/block.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 239 | pub(crate) fn into_headers(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | / self.into_columns() [INFO] [stdout] 241 | | .into_iter() [INFO] [stdout] 242 | | .map(|c| c.into_header()) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 35 | fn with_timeout(fut: F, timeout: Duration) -> impl Future> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | time::timeout(timeout, fut).map_ok_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | |_| Err(crate::errors::DriverError::ConnectionTimeout.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 92 | tcpstream: R, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | reader: LZ4ReadAdapter::new_with_param( [INFO] [stdout] | _____________________^ [INFO] [stdout] 102 | | BufReader::with_capacity(capacity, tcpstream), [INFO] [stdout] 103 | | compression, [INFO] [stdout] 104 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 92 | tcpstream: R, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | columns: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clickhouse-driver` (lib) due to 11 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sync/waker_set.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | let mut inner = &mut *self.lock(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `timezone` is never read [INFO] [stdout] --> src/protocol/block.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 226 | pub struct ServerBlock { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 229 | pub(crate) timezone: Tz, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServerBlock` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Command` is never used [INFO] [stdout] --> src/protocol/packet.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) trait Command: ServerWriter {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cancel` is never constructed [INFO] [stdout] --> src/protocol/packet.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) struct Cancel; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:135:37 [INFO] [stdout] | [INFO] [stdout] 135 | .map_or(false, |socket| socket.peer_addr().is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:260:19 [INFO] [stdout] | [INFO] [stdout] 257 | pub(super) fn new(pool: Pool, mut conn: Box) -> Connection { [INFO] [stdout] | ---------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:447:50 [INFO] [stdout] | [INFO] [stdout] 445 | pub(crate) fn disconnect(mut conn: Box) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | if let Ok(handle) = tokio::runtime::Handle::try_current() { [INFO] [stdout] 447 | handle.spawn(async move { conn.cleanup().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression/mod.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | Poll::Ready(Ok(toread)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/options.rs:88:11 [INFO] [stdout] | [INFO] [stdout] 84 | fn parse_param<'a, F, T, E>(param: Cow<'a, str>, value: Cow<'a, str>, parse: F) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | match parse(value.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/block.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 239 | pub(crate) fn into_headers(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | / self.into_columns() [INFO] [stdout] 241 | | .into_iter() [INFO] [stdout] 242 | | .map(|c| c.into_header()) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 35 | fn with_timeout(fut: F, timeout: Duration) -> impl Future> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | time::timeout(timeout, fut).map_ok_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | |_| Err(crate::errors::DriverError::ConnectionTimeout.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 92 | tcpstream: R, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | reader: LZ4ReadAdapter::new_with_param( [INFO] [stdout] | _____________________^ [INFO] [stdout] 102 | | BufReader::with_capacity(capacity, tcpstream), [INFO] [stdout] 103 | | compression, [INFO] [stdout] 104 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 92 | tcpstream: R, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | columns: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/command.rs:690:13 [INFO] [stdout] | [INFO] [stdout] 690 | Ok(size).into() [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clickhouse-driver` (lib test) due to 12 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "857cd0621fc2370dec83388f424c4795020acdf90f4e0c8314a1a3f7ed51da6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "857cd0621fc2370dec83388f424c4795020acdf90f4e0c8314a1a3f7ed51da6a", kill_on_drop: false }` [INFO] [stdout] 857cd0621fc2370dec83388f424c4795020acdf90f4e0c8314a1a3f7ed51da6a