[INFO] fetching crate cleaner 0.10.1... [INFO] checking cleaner-0.10.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cleaner 0.10.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cleaner 0.10.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cleaner 0.10.1 [INFO] finished tweaking crates.io crate cleaner 0.10.1 [INFO] tweaked toml for crates.io crate cleaner 0.10.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate cleaner 0.10.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c49c22d7ff6ebf427044e185fc696b37787ce60cbaebc936c22e06112f6998ea [INFO] running `Command { std: "docker" "start" "-a" "c49c22d7ff6ebf427044e185fc696b37787ce60cbaebc936c22e06112f6998ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c49c22d7ff6ebf427044e185fc696b37787ce60cbaebc936c22e06112f6998ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c49c22d7ff6ebf427044e185fc696b37787ce60cbaebc936c22e06112f6998ea", kill_on_drop: false }` [INFO] [stdout] c49c22d7ff6ebf427044e185fc696b37787ce60cbaebc936c22e06112f6998ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f65503abe652e7fdf2fd8272719aab3203c11f26e83162d01f62a81b8aa972cf [INFO] running `Command { std: "docker" "start" "-a" "f65503abe652e7fdf2fd8272719aab3203c11f26e83162d01f62a81b8aa972cf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Compiling cc v1.0.88 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling libz-sys v1.1.15 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking crossterm v0.21.0 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking newline-converter v0.2.2 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking wildmatch v2.3.0 [INFO] [stderr] Checking inquire v0.2.1 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking git2 v0.18.2 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking version-sync v0.9.5 [INFO] [stderr] Checking cleaner v0.10.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repos.rs:282:5 [INFO] [stdout] | [INFO] [stdout] 277 | branches: impl IntoIterator, BranchType), Error>> + 'a, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | predicate: impl Fn(usize, usize) -> bool + 'a, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | ) -> impl Iterator + 'a { [INFO] [stdout] 282 | branches.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repos.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 277 | branches: impl IntoIterator, BranchType), Error>> + 'a, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | predicate: impl Fn(usize, usize) -> bool + 'a, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | .filter_map(move |branch| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 284 | | let Ok((branch, _)) = branch else { return None; }; [INFO] [stdout] 285 | | let Ok(upstream) = branch.upstream() else { return None; }; [INFO] [stdout] 286 | | let Some(oid) = branch.into_reference().target() else { return None; }; [INFO] [stdout] ... | [INFO] [stdout] 290 | | Some(predicate(branch, upstream)) [INFO] [stdout] 291 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repos.rs:393:38 [INFO] [stdout] | [INFO] [stdout] 393 | RE_MAIN_OR_MASTER.get_or_init(|| Regex::new("^(refs/heads/)?(main|master)$").unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/walkers/builds_walker.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new>(filter: &'a Selection, path: P, platforms: &'a [Platform]) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | walker: WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/walkers/empties_walker.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new>(path: P, show_hidden: bool) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | walker: WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/walkers/repos_walker.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new>(path: P) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | walker: WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cleaner` (bin "cleaner" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repos.rs:282:5 [INFO] [stdout] | [INFO] [stdout] 277 | branches: impl IntoIterator, BranchType), Error>> + 'a, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | predicate: impl Fn(usize, usize) -> bool + 'a, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | ) -> impl Iterator + 'a { [INFO] [stdout] 282 | branches.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repos.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 277 | branches: impl IntoIterator, BranchType), Error>> + 'a, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | predicate: impl Fn(usize, usize) -> bool + 'a, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | .filter_map(move |branch| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 284 | | let Ok((branch, _)) = branch else { return None; }; [INFO] [stdout] 285 | | let Ok(upstream) = branch.upstream() else { return None; }; [INFO] [stdout] 286 | | let Some(oid) = branch.into_reference().target() else { return None; }; [INFO] [stdout] ... | [INFO] [stdout] 290 | | Some(predicate(branch, upstream)) [INFO] [stdout] 291 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repos.rs:393:38 [INFO] [stdout] | [INFO] [stdout] 393 | RE_MAIN_OR_MASTER.get_or_init(|| Regex::new("^(refs/heads/)?(main|master)$").unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/walkers/builds_walker.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new>(filter: &'a Selection, path: P, platforms: &'a [Platform]) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | walker: WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/walkers/empties_walker.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new>(path: P, show_hidden: bool) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | walker: WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/walkers/repos_walker.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new>(path: P) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | walker: WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cleaner` (bin "cleaner") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "f65503abe652e7fdf2fd8272719aab3203c11f26e83162d01f62a81b8aa972cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f65503abe652e7fdf2fd8272719aab3203c11f26e83162d01f62a81b8aa972cf", kill_on_drop: false }` [INFO] [stdout] f65503abe652e7fdf2fd8272719aab3203c11f26e83162d01f62a81b8aa972cf